Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Examples and Updated Comments for SKU and Computer APIs in the swagger #6294

Merged
merged 24 commits into from
Jun 18, 2019
Merged

Added Examples and Updated Comments for SKU and Computer APIs in the swagger #6294

merged 24 commits into from
Jun 18, 2019

Conversation

hari-bodicherla
Copy link
Contributor

@hari-bodicherla hari-bodicherla commented Jun 11, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@hari-bodicherla
Added diffDiskSettings property as part of Swagger changes needed for…
fa03850 
… Ephemeral VM\VMSS
@hari-bodicherla
updated comment
2f52195
@hari-bodicherla
updated swagger specs for diffdisksettings property
3286411
@hari-bodicherla
updated swagger spec comments for diff disk settings [property
f8934d4
@hari-bodicherla
added example to create Diff OS disk scaleset
6fdc54f
@hari-bodicherla
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
1adb5e3
@hari-bodicherla
updated 2018-10-01 version specs with diffdisk property
474d5b0
@hari-bodicherla
added example file for creating VM with diffdisksettings property
59315ed
@hari-bodicherla
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
4f1e089
@hari-bodicherla
Merge remote-tracking branch 'upstream/master'
41e9b0d
@hari-bodicherla
updated swagger changes for reimage operation in single vm
80e525c
@hari-bodicherla
update examples
27378b6
@hari-bodicherla
udpated examples
af7abc6
@hari-bodicherla
fixed validation errors
adb0812
@hari-bodicherla
Merge remote-tracking branch 'upstream/master'
5dfa8d2
@hari-bodicherla
updated comments for reimage operation documentation
4711b30
@hari-bodicherla
resolved conflicts
1044260
@hari-bodicherla
Updated examples and documentation for APIs in swagger
2820ac6
@hari-bodicherla hari-bodicherla requested a review from huangpf as a code owner June 11, 2019 23:30
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 11, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from f72e642)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 11, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#3900

@AutorestCI
Copy link

AutorestCI commented Jun 11, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5044

@AutorestCI
Copy link

AutorestCI commented Jun 11, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5853

@azuresdkci azuresdkci requested a review from praries880 June 11, 2019 23:31
@AutorestCI
Copy link

AutorestCI commented Jun 11, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2630

@AutorestCI
Copy link

AutorestCI commented Jun 11, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@hari-bodicherla hari-bodicherla added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 11, 2019
sergey-shandar
sergey-shandar suggested changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix JSON examples

@hari-bodicherla
Copy link
Contributor Author

Please fix JSON examples
Hi Sergey, Fixed the examples. please review and let me know if any updates needed

This was referenced Jun 12, 2019
Merged
Closed
Closed
Merged
@hari-bodicherla hari-bodicherla removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 17, 2019
This was referenced Jun 17, 2019
Merged
Merged
@praries880 praries880 merged commit c7373f4 into Azure:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyonholee hyonholee hyonholee left review comments

@smotwani smotwani smotwani left review comments

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@praries880 praries880 praries880 approved these changes

@huangpf huangpf Awaiting requested review from huangpf

Assignees

@praries880 praries880

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hari-bodicherla @AutorestCI @azuresdkci @sergey-shandar @hyonholee @smotwani @praries880