Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview #5486

Merged
merged 14 commits into from
Mar 28, 2019
Merged

[Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview #5486

merged 14 commits into from
Mar 28, 2019

Conversation

wilcobmsft
Copy link
Member

@wilcobmsft wilcobmsft commented Mar 26, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@AutorestCI
Copy link

AutorestCI commented Mar 26, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4423

@AutorestCI
Copy link

AutorestCI commented Mar 26, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3853

@AutorestCI
Copy link

AutorestCI commented Mar 26, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1861

@AutorestCI
Copy link

AutorestCI commented Mar 26, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

This was referenced Mar 26, 2019
Closed
Merged
@azuresdkci azuresdkci requested a review from jhendrixMSFT March 26, 2019 22:57
@AutorestCI AutorestCI mentioned this pull request Mar 26, 2019
Closed
@AutorestCI AutorestCI mentioned this pull request Mar 26, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 26, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3207

@jhendrixMSFT jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 26, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 26, 2019
@adxsdknet
.NET SDK Resource Provider:'Billing'
259be18 
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Mar 26, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5602
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@259be18
adxsdknet/azure-sdk-for-net@e5c0046
adxsdknet/azure-sdk-for-net@70d4b6f
adxsdknet/azure-sdk-for-net@9c74e7d

@shahabhijeet
Copy link
Member

startbuild

@wilcobmsft
Copy link
Member Author

@majastrz Can you provide ARM feedback for this please?

@majastrz
Copy link
Member

majastrz commented Mar 28, 2019 •
edited
Loading 

      },

Another asynchronous GET #Closed

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json:436 in 90e03b4. [](commit_id = 90e03b4, deletion_comment = False)

majastrz
majastrz requested changes Mar 28, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the asynchronous GETs.

@majastrz majastrz added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 28, 2019
@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Mar 28, 2019
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 28, 2019
@adxsdknet
.NET SDK Resource Provider:'Billing'
e5c0046 
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit
jhendrixMSFT
jhendrixMSFT requested changes Mar 28, 2019
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also open a work item to track fixing your operation IDs? A lot of them don't follow the required noun_verb format making for awkward SDK APIs.

@AutorestCI AutorestCI mentioned this pull request Mar 28, 2019
Closed
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 28, 2019
@adxsdknet
.NET SDK Resource Provider:'Billing'
70d4b6f 
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 28, 2019
@adxsdknet
.NET SDK Resource Provider:'Billing'
9c74e7d 
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit
@wilcobmsft
Copy link
Member Author

@jhendrixMSFT Thanks - we've opened a bug to clean up the operation ids in a future PR (before we publish corresponding SDKs).

@jhendrixMSFT jhendrixMSFT merged commit 98aa5b9 into Azure:master Mar 28, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 28, 2019
Merged
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Mar 29, 2019
Merged
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 29, 2019
@adxsdknet @dsgouda
AutoPr-Billing-wilcobmsft-REST Spec PrNumber 5486 (#5602)
0ffb353 
* .NET SDK Resource Provider:'Billing'
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Billing'
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Billing'
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Billing'
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
AutoPr-Billing-wilcobmsft-REST Spec PrNumber 5486 (Azure#5602)
74b306a 
* .NET SDK Resource Provider:'Billing'
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Billing'
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Billing'
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Billing'
REST Spec PR 'Azure/azure-rest-api-specs#5486'
REST Spec PR Author 'wilcobmsft'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@majastrz majastrz majastrz approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wilcobmsft @AutorestCI @azuresdkci @adxsdknet @shahabhijeet @majastrz @jhendrixMSFT