Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor (but improtant) changes in Azure DevOps pipeline. #5253

Merged
merged 8 commits into from
Feb 22, 2019
Merged

Minor (but improtant) changes in Azure DevOps pipeline. #5253

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ee4ed6e
empty parameters
sergey-shandar Feb 22, 2019
1f47b36
TRAVIS_BRANCH
sergey-shandar Feb 22, 2019
9889ad6
target branch
sergey-shandar Feb 22, 2019
712e7aa
trying to set env var
sergey-shandar Feb 22, 2019
3db2d81
use shell
sergey-shandar Feb 22, 2019
8cfd57b
info
sergey-shandar Feb 22, 2019
9054ea5
more info
sergey-shandar Feb 22, 2019
0452fc6
Pull Request Number
sergey-shandar Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ trigger: none

variables:
TRAVIS: 'true'
TRAVIS_PULL_REQUEST: $(System.PullRequest.PullRequestId)
TRAVIS_BRANCH: $(System.PullRequest.TargetBranch)
TRAVIS_PULL_REQUEST: $(System.PullRequest.PullRequestNumber)
TRAVIS_REPO_SLUG: $(Build.Repository.Name)
TRAVIS_PULL_REQUEST_SLUG: $(Build.Repository.Name)
TRAVIS_PULL_REQUEST_SHA: $(Build.SourceVersion)
Expand All @@ -16,6 +17,14 @@ jobs:
pool:
vmImage: 'Ubuntu 16.04'
steps:
- script: |
echo TRAVIS: $(TRAVIS)
echo TRAVIS_BRANCH: $(TRAVIS_BRANCH)
echo TRAVIS_REPO_SLUG: $(TRAVIS_REPO_SLUG)
echo TRAVIS_PULL_REQUEST: $(TRAVIS_PULL_REQUEST)
echo TRAVIS_PULL_REQUEST_SLUG: $(TRAVIS_PULL_REQUEST_SLUG)
echo TRAVIS_PULL_REQUEST_SHA: $(TRAVIS_PULL_REQUEST_SHA)
echo PR_ONLY: $(PR_ONLY)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you already merged this (Sorry that I didn't see it earlier), but I definitely recommend putting a displayName property on each of your script steps. It just helps to know what each step does when you're looking at it on the DevOps page.

- task: Npm@1
displayName: 'npm install'
inputs:
Expand Down Expand Up @@ -71,14 +80,19 @@ jobs:
matrix:
ruby:
AZURE_SDK_REPO: azure-sdk-for-ruby
AZURE_SDK_PARAMS: ''
java:
AZURE_SDK_REPO: azure-sdk-for-java
AZURE_SDK_PARAMS: ''
javascript:
AZURE_SDK_REPO: azure-sdk-for-js
AZURE_SDK_PARAMS: ''
node:
AZURE_SDK_REPO: azure-sdk-for-node
AZURE_SDK_PARAMS: ''
python:
AZURE_SDK_REPO: azure-sdk-for-python
AZURE_SDK_PARAMS: ''
go:
AZURE_SDK_REPO: azure-sdk-for-go
AZURE_SDK_PARAMS: '-o latest'
Expand Down