[Azure Search] Add Get Documents API (a.k.a. Lookup) to data plane API spec #5169
Conversation
Note that this API already exists in the .NET SDK, but is currently implemented as custom code. We need to add transform directives for the generated code because otherwise there's no way to pass custom JsonSerializerSettings into the generated code (which is a requirement for our data plane). Also renamed some example files to be more consistent with existing naming conventions.
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
|
Big thanks to @mhko who did the majority of the work on this. |
|
Can one of the admins verify this patch? |
|
@jhendrixMSFT Some context on this change: This is not a new API, it's just that until now we've never generated code for it. This is the first of many steps we're taking to make this particular Swagger spec accurately reflect our data plane API. |
|
@brjohnstmsft do you do any local C# codegen to verify this looks ok? |
| @@ -11,7 +11,7 @@ | |||
| "highlightPostTag": "</em>", | |||
| "highlightPreTag": "<em>", | |||
| "minimumCoverage": 80, | |||
| "searchFields": ["title", "description"], | |||
| "searchFields": "title,description", | |||
There was a problem hiding this comment.
The spec still has it as an array of string
There was a problem hiding this comment.
@nschonni That's the spec for the GET version of Autocomplete. The example I updated was for POST. AutoRest uses array parameters to represent query string parameters that are comma-separated lists. So although it's a comma-separated list everywhere on the wire, in the spec it's a string for POST and an array of strings for GET.
There was a problem hiding this comment.
Gotcha, I guess it's the alias'd property here
There was a problem hiding this comment.
Almost, it's this one:
|
@jhendrixMSFT Yes, I'm working on a .NET SDK PR that I will send out once this is merged. I wrote the translation rules in tandem with changing the .NET SDK. |
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: