Updated managed instance swagger and examples #5138

stefanb995 · 2019-02-01T19:21:24Z

*Updated ProxyOverride property in swagger file with enum
*Updated examples with ProxyOverride and PublicDataEndpointEnabled

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Adding two new ManagedInstance properties

*Update of ProxyOverride property for Managed Instance *Update of examples

AutorestCI · 2019-02-01T19:23:22Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2143

AutorestCI · 2019-02-01T19:23:24Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3769

AutorestCI · 2019-02-01T19:28:56Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1135

AutorestCI · 2019-02-01T19:30:05Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4057

azuresdkci · 2019-02-01T19:33:27Z

Can one of the admins verify this patch?

jaredmoo · 2019-02-01T20:18:35Z

...urce-manager/Microsoft.Sql/preview/2015-05-01-preview/examples/ManagedInstanceCreateMax.json

@@ -48,7 +50,8 @@
          "subnetId" : "/subscriptions/20D7082A-0FC7-4468-82BD-542694D5042B/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/vnet1/subnets/subnet1",
          "state": "Ready",
          "collation": "SQL_Latin1_General_CP1_CI_AS",
-          "dnsZone": "1b4e2caff2530"
+          "dnsZone": "1b4e2caff2530",


Is publicDataEndpointEnabled intentionally not there in the response?

Yes, it's by design.

I talked with Mladen who was implementing this feature. He actually forgot to include it here. It should be in response. I'll update it and he'll make sure to update his part.

jaredmoo · 2019-02-01T20:19:01Z

...er/Microsoft.Sql/preview/2015-05-01-preview/examples/ManagedInstanceListByResourceGroup.json

@@ -47,7 +49,8 @@
                        "storageSizeInGB": 1024,
                        "licenseType": "Full",
                        "collation":  "SQL_Latin1_General_CP1_CI_AS",
-                        "dnsZone": "1b4e2caff2530"
+                        "dnsZone": "1b4e2caff2530",
+                        "publicDataEndpointEnabled" :  "false"


Is proxyOverride intentionally missing?

Updated. It should be empty string because this instance is created before this property is introduced and the value for this property is null as I have already explained.

jaredmoo · 2019-02-01T20:19:24Z

...fication/sql/resource-manager/Microsoft.Sql/preview/2015-05-01-preview/managedInstances.json

+          "x-ms-enum":{
+            "name": "ManagedInstanceProxyOverride",
+            "modelAsString": true
+		  },


Nit: please fix indentation

AutorestCI · 2019-02-01T20:19:43Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_sql/resource-manager
  stderr: 'remote: Permission to Azure/azure-sdk-for-java.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-java.git/': The requested URL returned error: 403'

AutorestCI · 2019-02-01T20:32:21Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#4181

veronicagg · 2019-02-01T21:45:08Z

@anuchandy giving you this PR as I took your other one (just a swap) thanks!

Fixed indentation.

anuchandy · 2019-02-04T02:36:16Z

@stefanb995 please fix conflicts in managedInstances.json.

nschonni · 2019-02-04T06:49:20Z

...urce-manager/Microsoft.Sql/preview/2015-05-01-preview/examples/ManagedInstanceCreateMax.json

@@ -23,7 +23,9 @@
        "storageSizeInGB": 1024,
        "licenseType": "Full",
        "collation": "SQL_Latin1_General_CP1_CI_AS",
-        "dnsZonePartner": "/subscriptions/20D7082A-0FC7-4468-82BD-542694D5042B/resourceGroups/testrg/providers/Microsoft.Sql/managedInstances/testinstance"
+        "dnsZonePartner": "/subscriptions/20D7082A-0FC7-4468-82BD-542694D5042B/resourceGroups/testrg/providers/Microsoft.Sql/managedInstances/testinstance",
+        "publicDataEndpointEnabled" : "false",


Don't think the boolean value should be quoted

Thanks. I fixed it.

Added proxyOverride in response for testcl2 managedInstance.

…ger' of https://github.com/stefanb995/azure-rest-api-specs into Add-publicDataEndpointEnabled-and-proxyOverride-to-swagger

anuchandy

@stefanb995 could you fix the conflict in managedInstances.json

Fixed indentation

stefanb995 · 2019-02-07T18:20:29Z

Fixed.

stefanb995 · 2019-02-08T09:04:18Z

Can you please approve this. I need it merged to regenerate SDK from master branch.

anuchandy · 2019-02-08T16:15:11Z

@stefanb995 it seems there are still conflicts in managedInstances.json?

…rride-to-swagger

stefanb995 · 2019-02-08T16:38:31Z

My bad. It should be fixed now.

stefanb995 added 2 commits January 30, 2019 11:49

Update managedInstances.json

45f508a

Adding two new ManagedInstance properties

Swagger change for Managed Instance

397e372

*Update of ProxyOverride property for Managed Instance *Update of examples

azuresdkci assigned veronicagg Feb 1, 2019

azuresdkci requested a review from veronicagg February 1, 2019 19:22

AutorestCI mentioned this pull request Feb 1, 2019

[AutoPR sql/resource-manager] Updated managed instance swagger and examples Azure/azure-sdk-for-ruby#2198

Closed

AutorestCI mentioned this pull request Feb 1, 2019

[AutoPR sql/resource-manager] Updated managed instance swagger and examples Azure/azure-sdk-for-python#4290

Merged

This was referenced Feb 1, 2019

[AutoPR sql/resource-manager] Updated managed instance swagger and examples Azure/azure-sdk-for-js#1080

Closed

[AutoPR sql/resource-manager] Updated managed instance swagger and examples Azure/azure-sdk-for-go#4000

Closed

stefanb995 mentioned this pull request Feb 1, 2019

.NET client update Azure/azure-sdk-for-net#5197

Merged

9 tasks

jaredmoo reviewed Feb 1, 2019

View reviewed changes

AutorestCI mentioned this pull request Feb 1, 2019

[AutoPR sql/resource-manager] Updated managed instance swagger and examples Azure/azure-sdk-for-java#2903

Closed

AutorestCI mentioned this pull request Feb 1, 2019

[AutoPR sql/resource-manager] Updated managed instance swagger and examples Azure/azure-sdk-for-node#4627

Closed

veronicagg assigned anuchandy and unassigned veronicagg Feb 1, 2019

veronicagg requested review from anuchandy and removed request for veronicagg February 1, 2019 21:44

Update managedInstances.json

ac5b71c

Fixed indentation.

nschonni reviewed Feb 4, 2019

View reviewed changes

stefanb995 added 3 commits February 4, 2019 09:27

Update ManagedInstanceListByResourceGroup.json

080eff4

Added proxyOverride in response for testcl2 managedInstance.

Updated bool values

88c55ad

Update ManagedInstanceCreateMax.json

fcaf617

stefanb995 added 5 commits February 4, 2019 19:33

Update ManagedInstanceGet.json

9f61378

Update ManagedInstanceList.json

72acebf

Update ManagedInstanceListByResourceGroup.json

a2649b9

Update ManagedInstanceUpdateMax.json

320e26d

Merge branch 'Add-publicDataEndpointEnabled-and-proxyOverride-to-swag…

743faf3

…ger' of https://github.com/stefanb995/azure-rest-api-specs into Add-publicDataEndpointEnabled-and-proxyOverride-to-swagger

jaredmoo approved these changes Feb 4, 2019

View reviewed changes

anuchandy requested changes Feb 6, 2019

View reviewed changes

Update managedInstances.json

f77f93b

Fixed indentation

AutorestCI mentioned this pull request Feb 7, 2019

[AutoPR sql/resource-manager] Updated managed instance swagger and examples Azure/azure-sdk-for-go#4050

Merged

Update managedInstances.json

5f400db

jaredmoo approved these changes Feb 7, 2019

View reviewed changes

stefanb995 added 2 commits February 7, 2019 19:32

Update managedInstances.json

00ccb04

Update managedInstances.json

c614033

Update ManagedInstanceCreateMax.json

b79620d

Merge branch 'master' into Add-publicDataEndpointEnabled-and-proxyOve…

8b90edd

…rride-to-swagger

Update managedInstances.json

b7c9ded

anuchandy approved these changes Feb 8, 2019

View reviewed changes

anuchandy merged commit be751b2 into Azure:master Feb 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated managed instance swagger and examples #5138

Updated managed instance swagger and examples #5138

stefanb995 commented Feb 1, 2019

AutorestCI commented Feb 1, 2019 •

edited

Loading

AutorestCI commented Feb 1, 2019 •

edited

Loading

AutorestCI commented Feb 1, 2019 •

edited

Loading

AutorestCI commented Feb 1, 2019 •

edited

Loading

azuresdkci commented Feb 1, 2019

jaredmoo Feb 1, 2019

stefanb995 Feb 2, 2019

stefanb995 Feb 8, 2019

jaredmoo Feb 1, 2019

stefanb995 Feb 4, 2019 •

edited

Loading

jaredmoo Feb 1, 2019

stefanb995 Feb 2, 2019

AutorestCI commented Feb 1, 2019 •

edited

Loading

AutorestCI commented Feb 1, 2019 •

edited

Loading

veronicagg commented Feb 1, 2019

anuchandy commented Feb 4, 2019

nschonni Feb 4, 2019

stefanb995 Feb 4, 2019

anuchandy left a comment

stefanb995 commented Feb 7, 2019

stefanb995 commented Feb 8, 2019

anuchandy commented Feb 8, 2019

stefanb995 commented Feb 8, 2019

Updated managed instance swagger and examples #5138

Updated managed instance swagger and examples #5138

Conversation

stefanb995 commented Feb 1, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Feb 1, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Feb 1, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Feb 1, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Feb 1, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Feb 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stefanb995 Feb 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented Feb 1, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Feb 1, 2019 • edited Loading

Automation for azure-sdk-for-node

veronicagg commented Feb 1, 2019

anuchandy commented Feb 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anuchandy left a comment

Choose a reason for hiding this comment

stefanb995 commented Feb 7, 2019

stefanb995 commented Feb 8, 2019

anuchandy commented Feb 8, 2019

stefanb995 commented Feb 8, 2019

AutorestCI commented Feb 1, 2019 •

edited

Loading

AutorestCI commented Feb 1, 2019 •

edited

Loading

AutorestCI commented Feb 1, 2019 •

edited

Loading

AutorestCI commented Feb 1, 2019 •

edited

Loading

stefanb995 Feb 4, 2019 •

edited

Loading

AutorestCI commented Feb 1, 2019 •

edited

Loading

AutorestCI commented Feb 1, 2019 •

edited

Loading