add pagable to the AppService spec #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python is broken because of: @devigned you sure some of your nextLink should have not been |
|
oh no... looks like I was a little over zealous. Fixing it. |
f248162 to
31681d8
Compare
|
@lmazuel I think we are green. |
|
@amarzavery what do you think about pulling this in? |
|
LGTM. |
This was referenced Aug 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AppService spec doesn't use x-ms-pagable to describe it's pagable operations. This creates extra models in most languages and provides a less than optimal developer experience.
@tbombach please give this a look.
@veronicagg and @vishrutshah please verify this resolves the Ruby SDK issue with get_next_page_lazy.