[DO NOT MERGE] VA List Api version edit #4257

t-robalt · 2018-10-18T10:54:48Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

t-robalt · 2018-10-18T10:55:15Z

@talhers @yaakoviyun

AutorestCI · 2018-10-18T10:55:20Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#367

AutorestCI · 2018-10-18T10:55:23Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3680

azuresdkci · 2018-10-18T10:55:23Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-18T10:55:24Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3994

AutorestCI · 2018-10-18T10:55:43Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3121

dsgouda · 2018-10-18T16:16:25Z

Reassigning due to some other deliverables

jianghaolu · 2018-10-22T16:54:44Z

...t.Sql/preview/2017-03-01-preview/examples/DatabaseVulnerabilityAssessmentListByDatabase.json

@@ -3,7 +3,7 @@
        "subscriptionId": "00000000-1111-2222-3333-444444444444",
        "resourceGroupName": "vulnerabilityaseessmenttest-4799",
        "serverName": "vulnerabilityaseessmenttest-6440",
-        "databaseName": "testdb",
+		"databaseName": "testdb",


indentation

jianghaolu · 2018-10-22T16:55:10Z

@t-robalt LGTM - but what's the purpose of deleting a bunch of examples?

t-robalt · 2018-10-24T08:48:04Z

@jianghaolu The List method of database and managed database moved to other api-versions, and there aren't any database nor managed database controllers at all in 2018-06-01 so their examples are no longer necessary there.

AutorestCI · 2018-10-24T08:53:49Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1792

AutorestCI · 2018-10-31T20:44:30Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2138

dsgouda · 2018-11-01T17:32:01Z

@jianghaolu @jaredmoo was this supposed to be merged?

yaakoviyun · 2018-11-01T17:48:23Z

Yep, the code should have reached production by now. Sent from Outlook

…

________________________________ מאת: Deepak Shankargouda <notifications@github.com> ‏‏נשלח: יום חמישי 01 נובמבר 2018 19:42:54 ‏‏אל: Azure/azure-rest-api-specs עותק: Yaakov Iyun; Mention ‏‏נושא: Re: [Azure/azure-rest-api-specs] [DO NOT MERGE] VA List Api version edit (#4257) @jianghaolu<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjianghaolu&data=02%7C01%7Cyaiyun%40microsoft.com%7Cf9bae65aba284278574a08d640217436%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636766909755353960&sdata=sT%2F3DiwFoVj%2BjxS68QTHGc1tI9%2BAwy6OyrXecBztkKE%3D&reserved=0> @jaredmoo<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjaredmoo&data=02%7C01%7Cyaiyun%40microsoft.com%7Cf9bae65aba284278574a08d640217436%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636766909755353960&sdata=XnAikyaA%2B0ClgkRm5qfvHFHErgBXAiwVPtuzgRF9KnQ%3D&reserved=0> was this supposed to be merged? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F4257%23issuecomment-435120083&data=02%7C01%7Cyaiyun%40microsoft.com%7Cf9bae65aba284278574a08d640217436%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636766909755363969&sdata=ePAWxQ9yQaJmMN409Xjg%2BQNNglg4KdCpKJlT1afpPEM%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALNgub5go2bB2W-QCrLjSMQX60e2EI4vks5uqzKegaJpZM4XtLng&data=02%7C01%7Cyaiyun%40microsoft.com%7Cf9bae65aba284278574a08d640217436%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636766909755363969&sdata=khmXiF6humGz8XO%2FY6YD%2F62Q5medes5j2E2Beax6bfU%3D&reserved=0>.

dsgouda · 2018-11-01T18:05:45Z

Thanks for confirming, I was concerned because of the title of the PR 👍

VA List Api version edit

3bff626

azuresdkci assigned dsgouda Oct 18, 2018

azuresdkci requested a review from dsgouda October 18, 2018 10:56

Updated missing tests

0b2a08c

dsgouda added the Reassign label Oct 18, 2018

azuresdkci assigned jianghaolu and unassigned dsgouda Oct 18, 2018

azuresdkci requested a review from jianghaolu October 18, 2018 16:34

jaredmoo approved these changes Oct 19, 2018

View reviewed changes

jianghaolu reviewed Oct 22, 2018

View reviewed changes

t-robalt added 3 commits October 24, 2018 11:51

Update DatabaseVulnerabilityAssessmentListByDatabase.json

0ef7fba

Update DatabaseVulnerabilityAssessmentListByDatabase.json

ca82e06

Update DatabaseVulnerabilityAssessmentListByDatabase.json

b77f5d1

This was referenced Oct 24, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] VA List Api version edit Azure/azure-sdk-for-python#3678

Merged

[AutoPR sql/resource-manager] [DO NOT MERGE] VA List Api version edit Azure/azure-sdk-for-ruby#1793

Closed

jianghaolu approved these changes Oct 31, 2018

View reviewed changes

jianghaolu merged commit 4769596 into Azure:master Oct 31, 2018

AutorestCI mentioned this pull request Oct 31, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] VA List Api version edit Azure/azure-sdk-for-java#2552

Merged

AutorestCI mentioned this pull request Oct 31, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] VA List Api version edit Azure/azure-sdk-for-js#367

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] VA List Api version edit #4257

[DO NOT MERGE] VA List Api version edit #4257

t-robalt commented Oct 18, 2018 •

edited

Loading

t-robalt commented Oct 18, 2018

AutorestCI commented Oct 18, 2018 •

edited

Loading

AutorestCI commented Oct 18, 2018 •

edited

Loading

azuresdkci commented Oct 18, 2018

AutorestCI commented Oct 18, 2018 •

edited

Loading

AutorestCI commented Oct 18, 2018 •

edited

Loading

dsgouda commented Oct 18, 2018

jianghaolu Oct 22, 2018

jianghaolu commented Oct 22, 2018

t-robalt commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 31, 2018 •

edited

Loading

dsgouda commented Nov 1, 2018

yaakoviyun commented Nov 1, 2018 via email

dsgouda commented Nov 1, 2018

[DO NOT MERGE] VA List Api version edit #4257

[DO NOT MERGE] VA List Api version edit #4257

Conversation

t-robalt commented Oct 18, 2018 • edited Loading

PR information

Quality of Swagger

t-robalt commented Oct 18, 2018

AutorestCI commented Oct 18, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Oct 18, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Oct 18, 2018

AutorestCI commented Oct 18, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Oct 18, 2018 • edited Loading

Automation for azure-sdk-for-go

dsgouda commented Oct 18, 2018

jianghaolu Oct 22, 2018

Choose a reason for hiding this comment

jianghaolu commented Oct 22, 2018

t-robalt commented Oct 24, 2018 • edited Loading

AutorestCI commented Oct 24, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Oct 31, 2018 • edited Loading

Automation for azure-sdk-for-java

dsgouda commented Nov 1, 2018

yaakoviyun commented Nov 1, 2018 via email

dsgouda commented Nov 1, 2018

t-robalt commented Oct 18, 2018 •

edited

Loading

AutorestCI commented Oct 18, 2018 •

edited

Loading

AutorestCI commented Oct 18, 2018 •

edited

Loading

AutorestCI commented Oct 18, 2018 •

edited

Loading

AutorestCI commented Oct 18, 2018 •

edited

Loading

t-robalt commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 24, 2018 •

edited

Loading

AutorestCI commented Oct 31, 2018 •

edited

Loading