Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ARMViolations for Microsoft.Solutions #3914

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Fix ARMViolations for Microsoft.Solutions #3914

merged 1 commit into from
Sep 20, 2018

Conversation

zjpjack
Copy link
Contributor

@zjpjack zjpjack commented Sep 14, 2018

Fix ARMViolations for Microsoft.Solutions

@AutorestCI
Copy link

AutorestCI commented Sep 14, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from marstr September 14, 2018 23:50
@AutorestCI
Copy link

AutorestCI commented Sep 14, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Sep 14, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3647

This was referenced Sep 14, 2018
Merged
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 14, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2758

@AutorestCI
Copy link

AutorestCI commented Sep 14, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@zjpjack
Copy link
Contributor Author

zjpjack commented Sep 17, 2018

@marstr Can you please take a look at this validation error? It is not related with my change. It seems that in the file, we have path "/{applianceId}" and "/{applianceDefinitionId}", and validation thinks they are the same path.

@marstr
Copy link
Member

marstr commented Sep 18, 2018

Seems like this must be a long-standing issue, as running a git log on this file only shows the activity of me creating it in December as part of a refactor. Because you're not introducing that error, I'm not going to block this PR on that failure.

@marstr marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 18, 2018
marstr
marstr approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, making properties optional after they're required can break what we code-gen. However, because this is in the preview folder, we do not block on breaking changes.

@marstr
Copy link
Member

marstr commented Sep 18, 2018

@sergey-shandar, is this a known issue?

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 18, 2018
@zjpjack
Copy link
Contributor Author

zjpjack commented Sep 18, 2018

@marstr Thanks, please merge this PR.

@marstr marstr merged commit 3b01760 into Azure:master Sep 20, 2018
@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI AutorestCI mentioned this pull request Sep 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstr marstr marstr approved these changes

Assignees

@marstr marstr

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zjpjack @AutorestCI @azuresdkci @marstr @ravbhatnagar