sdk, fix service-dir #32843
sdk, fix service-dir #32843
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
| @@ -1,6 +1,6 @@ | |||
| parameters: | |||
| "service-dir": | |||
| default: "sdk/informatica" | |||
| default: "sdk/informaticadatamanagement" | |||
There was a problem hiding this comment.
if this is only for python and java, i prefer the original default which makes more sense to me.
There was a problem hiding this comment.
The failure is caused by out automation to handle the different service-dir and here is the issue to track that: Azure/azure-sdk-tools#9946.
There was a problem hiding this comment.
if this is only for python and java, i prefer the original default which makes more sense to me.
Original default is informaticadatamanagement, as approved by namespace review:
https://github.com/Azure/azure-sdk-pr/issues/1731
service-dir usually conforms to package name, unless specifically mentioned otherwise, and I haven't seen such case before..
There was a problem hiding this comment.
.net
https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/informaticadatamanagement
go also not "informaticadata" (but they got a slightly different tree)
https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/resourcemanager/informaticadatamgmt
So seems only JS is "informaticadata"?
Interesting, JS automation actually parse the file yourself?
Java's (and I think Go, maybe Python too) would do
- generate the code
- do a "git status" to see whether code get generated, and use that folder/package
It's not great, though...
(previously in script time, we actually have Ray return the folder in output of his script -- but that gone after tsp-client)
SDK configuration pull request
Purpose of this PR
Some service-dir got changed after SDK released packages.
https://github.com/Azure/azure-rest-api-specs/pull/30578/files#diff-5235c0db2ec5ace38abfa31236a348c893d67cfc16a833e4fdb3e6701276c18f
Change back for consistency.
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
tspconfig.yamltemplates:Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.