Adding Vulnerability Assessment APIs on managed instance

[yaakoviyun]

Adding Vulnerability Assessment APIs on managed instance

Those APIs are the same as the Vulnerability Assessment APIs on regular Azure db with the difference of using "/managedInstances/{managed instance name}/" instead of "/servers/{server name}/"

The Vulnerability Assessment APIs on regular Azure db are approved and can be found at:

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessmentBaselines.json

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessments.json

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/databaseVulnerabilityAssessmentScans.json

[azuresdkciprbot]

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/sql/resource-manager/readme.md

⚠️0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[azuresdkciprbot]

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/sql/resource-manager/readme.md

⚠️0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[jaredmoo]

The linter validation failed with a few errors.

https://travis-ci.org/Azure/azure-rest-api-specs/jobs/379065871#L761

{
  "Channel": "fatal",
  "Text": "Error: '$.definitions.DatabaseVulnerabilityAssessmentScanExportProperties.description' has incompatible values (---\nProperties of the export operation’s result.\n, ---\nProperties of the export operation's result.\n)."
}
(node:6908) UnhandledPromiseRejectionWarning: Error: '$.definitions.DatabaseVulnerabilityAssessmentScanExportProperties.description' has incompatible values (---
Properties of the export operation’s result.
, ---
Properties of the export operation's result.
).

Very subtle difference but the first description has a ’ character, second has ' character.

[AutorestCI]

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2049

[AutorestCI]

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2715

[AutorestCI]

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#9

[AutorestCI]

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmplhnevnnm/rest/specification/sql/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmplhnevnnm/sdk', '--use=@microsoft.azure/autorest.python@~3.0', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4280).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0->3.0.51)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmplhnevnnm/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/managedDatabaseVulnerabilityAssessments.json:224:4 ($.definitions.DatabaseVulnerabilityAssessmentProperties)
    - file:///tmp/tmplhnevnnm/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/databaseVulnerabilityAssessmentScans.json:280:4 ($.definitions.DatabaseVulnerabilityAssessmentProperties)
    - file:///tmp/tmplhnevnnm/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessments.json:212:4 ($.definitions.DatabaseVulnerabilityAssessmentProperties)
Process() cancelled due to exception : Cancellation requested.
  Cancellation requested.

[jaredmoo]

Linter looks good now but there are also example validation errors in https://travis-ci.org/Azure/azure-rest-api-specs/jobs/381382464 , can you fix? :)

[jaredmoo]

One last model warning: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/381535630#L768

I am waiting to approve until the API is ready in production. @ravbhatnagar , please approve design.

[jhendrixMSFT]

Are we still waiting on ARM review for this?

[yaakoviyun]

@jhendrixMSFT - yes.

And the API is now exposed so we can merge it

[jhendrixMSFT]

@yaakoviyun great I'll wrap up my review shortly. There are a few model validation errors, could you have a quick look here.

[jhendrixMSFT]

Ping @yaakoviyun there is just one model validation failure, it's in an example. Not blocking but would be great to have this clean before merging.

[jaredmoo]

Is there a possibility in the future of adding master baselines? I want to avoid having a similar breaking change in MI like we did in DB when master was added.

[yaakoviyun]

The APIs are not yet ready for exposure.

This got a low priority tag now.
I'm closing the PR and will send a new one once we will fix the APIs.

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby