Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Migrate/Microsoft.Migrate to add version stable/2023-03-15 #26562

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

srilipta-swain
Copy link
Member

@srilipta-swain srilipta-swain commented Nov 6, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification
    • This is a swagger fix to an API version which was recently pushed, but has not been made public yet.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
migrate.json 2023-03-15(30ce569) 2023-03-15(main)
Rule Message
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: AssessmentProjects/stable/2023-03-15/migrate.json#L6268:11
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L6190:11
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'recommendedDiskSizeGigabytes' renamed or removed?
New: AssessmentProjects/stable/2023-03-15/migrate.json#L5156:7
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L5157:7
1041 - AddedPropertyInResponse The new version has a new property 'gigabytesForRecommendedDiskSize' in response that was not found in the old version.
New: AssessmentProjects/stable/2023-03-15/migrate.json#L5156:7
Old: AssessmentProjects/stable/2023-03-15/migrate.json#L5157:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-migrate-2023-03 package-migrate-2023-03(30ce569) package-migrate-2023-03(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L5154


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L128
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L135
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L141
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L164
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L167
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L180
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L203
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L206
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L209
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L222
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L245
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L248
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L251
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L272
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L290
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L293
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L296
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L339
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L361
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L364
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L367
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L411
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L433
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L436
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L439
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L460
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L480
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L483
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L486
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: AssessmentProjects/stable/2023-03-15/migrate.json#L507
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/migrate/armmigrate - Approved - 2.0.0
-	Field `GigabytesForRecommendedDiskSize` of struct `AssessedDisk` has been removed
azure-sdk-for-js - @azure/arm-migrate - Approved - 3.0.0
-	Interface AssessedDisk no longer has parameter gigabytesForRecommendedDiskSize
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs]Release - Generate from d686188. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  • Azure.ResourceManager.Migrate [View full logs]  [Release SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from d686188. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/migrate/armmigrate [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    info	[Changelog] - New struct `AssessedSQLInstanceDiskDetails`
    info	[Changelog] - New struct `AssessedSQLInstanceStorageDetails`
    info	[Changelog] - New struct `AssessedSQLInstanceSummary`
    info	[Changelog] - New struct `AssessedSQLInstanceV2`
    info	[Changelog] - New struct `AssessedSQLInstanceV2ListResult`
    info	[Changelog] - New struct `AssessedSQLInstanceV2Properties`
    info	[Changelog] - New struct `AssessedSQLMachine`
    info	[Changelog] - New struct `AssessedSQLMachineListResult`
    info	[Changelog] - New struct `AssessedSQLMachineProperties`
    info	[Changelog] - New struct `AssessedSQLRecommendedEntity`
    info	[Changelog] - New struct `AssessedSQLRecommendedEntityListResult`
    info	[Changelog] - New struct `AssessedSQLRecommendedEntityProperties`
    info	[Changelog] - New struct `AssessmentListResult`
    info	[Changelog] - New struct `AssessmentOptionsListResult`
    info	[Changelog] - New struct `AssessmentProject`
    info	[Changelog] - New struct `AssessmentProjectListResult`
    info	[Changelog] - New struct `AssessmentProjectSummary`
    info	[Changelog] - New struct `AssessmentProjectSummaryListResult`
    info	[Changelog] - New struct `AssessmentProjectSummaryProperties`
    info	[Changelog] - New struct `AssessmentProjectUpdate`
    info	[Changelog] - New struct `AssessmentProjectUpdateProperties`
    info	[Changelog] - New struct `AvsAssessedDisk`
    info	[Changelog] - New struct `AvsAssessedMachine`
    info	[Changelog] - New struct `AvsAssessedMachineListResult`
    info	[Changelog] - New struct `AvsAssessedMachineProperties`
    info	[Changelog] - New struct `AvsAssessedNetworkAdapter`
    info	[Changelog] - New struct `AvsAssessment`
    info	[Changelog] - New struct `AvsAssessmentListResult`
    info	[Changelog] - New struct `AvsAssessmentOptions`
    info	[Changelog] - New struct `AvsAssessmentOptionsListResult`
    info	[Changelog] - New struct `AvsAssessmentOptionsProperties`
    info	[Changelog] - New struct `AvsAssessmentProperties`
    info	[Changelog] - New struct `AvsSKUOptions`
    info	[Changelog] - New struct `AzureManagedDiskSKUDTO`
    info	[Changelog] - New struct `AzureQuorumWitnessDTO`
    info	[Changelog] - New struct `AzureResourceProperties`
    info	[Changelog] - New struct `AzureSQLIaasSKUDTO`
    info	[Changelog] - New struct `AzureSQLPaasSKUDTO`
    info	[Changelog] - New struct `AzureVirtualMachineSKUDTO`
    info	[Changelog] - New struct `CollectorAgentPropertiesBase`
    info	[Changelog] - New struct `CollectorAgentSpnPropertiesBase`
    info	[Changelog] - New struct `CollectorPropertiesBase`
    info	[Changelog] - New struct `CollectorPropertiesBaseWithAgent`
    info	[Changelog] - New struct `CostComponent`
    info	[Changelog] - New struct `EntityUptime`
    info	[Changelog] - New struct `Error`
    info	[Changelog] - New struct `ErrorAdditionalInfo`
    info	[Changelog] - New struct `ErrorDetail`
    info	[Changelog] - New struct `ErrorResponse`
    info	[Changelog] - New struct `ErrorSummary`
    info	[Changelog] - New struct `GroupListResult`
    info	[Changelog] - New struct `HypervCollector`
    info	[Changelog] - New struct `HypervCollectorListResult`
    info	[Changelog] - New struct `ImpactedAssessmentObject`
    info	[Changelog] - New struct `ImportCollectorListResult`
    info	[Changelog] - New struct `MachineAssessmentProperties`
    info	[Changelog] - New struct `MachineListResult`
    info	[Changelog] - New struct `MigrationGuidelineContext`
    info	[Changelog] - New struct `OperationListResult`
    info	[Changelog] - New struct `PrivateEndpoint`
    info	[Changelog] - New struct `PrivateEndpointConnectionListResult`
    info	[Changelog] - New struct `PrivateLinkResourceListResult`
    info	[Changelog] - New struct `ProcessorInfo`
    info	[Changelog] - New struct `ProductSupportStatus`
    info	[Changelog] - New struct `ProxyResource`
    info	[Changelog] - New struct `Resource`
    info	[Changelog] - New struct `SQLAssessedNetworkAdapter`
    info	[Changelog] - New struct `SQLAssessmentMigrationIssue`
    info	[Changelog] - New struct `SQLAssessmentOptions`
    info	[Changelog] - New struct `SQLAssessmentOptionsListResult`
    info	[Changelog] - New struct `SQLAssessmentOptionsProperties`
    info	[Changelog] - New struct `SQLAssessmentV2`
    info	[Changelog] - New struct `SQLAssessmentV2IaasSuitabilityData`
    info	[Changelog] - New struct `SQLAssessmentV2ListResult`
    info	[Changelog] - New struct `SQLAssessmentV2PaasSuitabilityData`
    info	[Changelog] - New struct `SQLAssessmentV2Properties`
    info	[Changelog] - New struct `SQLAssessmentV2Summary`
    info	[Changelog] - New struct `SQLAssessmentV2SummaryData`
    info	[Changelog] - New struct `SQLAssessmentV2SummaryListResult`
    info	[Changelog] - New struct `SQLAssessmentV2SummaryProperties`
    info	[Changelog] - New struct `SQLAvailabilityGroupDataOverview`
    info	[Changelog] - New struct `SQLAvailabilityReplicaSummary`
    info	[Changelog] - New struct `SQLCollector`
    info	[Changelog] - New struct `SQLCollectorListResult`
    info	[Changelog] - New struct `SQLDbSettings`
    info	[Changelog] - New struct `SQLFCIMetadata`
    info	[Changelog] - New struct `SQLMiSettings`
    info	[Changelog] - New struct `SQLMigrationGuideline`
    info	[Changelog] - New struct `SQLPaaSTargetOptions`
    info	[Changelog] - New struct `SQLRecommendationReasoning`
    info	[Changelog] - New struct `SQLRecommendationReasoningContext`
    info	[Changelog] - New struct `SQLVMSettings`
    info	[Changelog] - New struct `ServerCollectorListResult`
    info	[Changelog] - New struct `SharedResourcesDTO`
    info	[Changelog] - New struct `SystemData`
    info	[Changelog] - New struct `TrackedResource`
    info	[Changelog] - New struct `UltraDiskAssessmentOptions`
    info	[Changelog] - New struct `VMFamilyOptions`
    info	[Changelog] - New struct `VmwareCollector`
    info	[Changelog] - New struct `VmwareCollectorListResult`
    info	[Changelog] - New struct `WorkloadSummary`
    info	[Changelog] - New field `RecommendDiskThroughputInMbps`, `RecommendedDiskIops` in struct `AssessedDisk`
    info	[Changelog] - New field `SystemData` in struct `AssessedMachine`
    info	[Changelog] - New field `CostComponents`, `Errors`, `HostProcessor`, `MonthlyStandardSsdStorageCost`, `MonthlyUltraStorageCost`, `OperatingSystemArchitecture`, `ProductSupportStatus`, `Type` in struct `AssessedMachineProperties`
    info	[Changelog] - New field `SystemData` in struct `Assessment`
    info	[Changelog] - New field `SystemData`, `Type` in struct `AssessmentOptions`
    info	[Changelog] - New field `PremiumDiskVMFamilies`, `SavingsPlanSupportedLocations`, `SavingsPlanVMFamilies`, `UltraDiskVMFamilies` in struct `AssessmentOptionsProperties`
    info	[Changelog] - New field `SystemData` in struct `Group`
    info	[Changelog] - New field `ProvisioningState`, `SupportedAssessmentTypes` in struct `GroupProperties`
    info	[Changelog] - New field `SystemData` in struct `ImportCollector`
    info	[Changelog] - New field `SystemData` in struct `Machine`
    info	[Changelog] - New field `Errors`, `HostProcessor`, `ProductSupportStatus`, `SQLInstances`, `WebApplications`, `WorkloadSummary` in struct `MachineProperties`
    info	[Changelog] - New field `ActionType`, `IsDataAction` in struct `Operation`
    info	[Changelog] - New anonymous field `OperationListResult` in struct `OperationsClientListResponse`
    info	[Changelog] - New field `SystemData` in struct `PrivateEndpointConnection`
    info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnectionProperties`
    info	[Changelog] - New field `SystemData` in struct `PrivateLinkResource`
    info	[Changelog] - New field `SystemData` in struct `ServerCollector`
    info	[Changelog]
    info	[Changelog] Total 178 breaking change(s), 1076 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from d686188. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-migrate [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM192IsV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM208MsV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM208SV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM3216Ms
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM328Ms
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM32DmsV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM32Ls
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM32Ms
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM32MsV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM32Ts
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM416208MsV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM416208SV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM416MsV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM416SV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM64
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM6416Ms
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM6432Ms
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM64DmsV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM64DsV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM64Ls
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM64M
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM64MsV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM64SV2
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM82Ms
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM84Ms
    info	[Changelog]   - Enum KnownAzureVmSize has a new value StandardM8Ms
    info	[Changelog]   - Enum KnownAzureVmSuitabilityExplanation has a new value NoEaPriceFoundForVmSize
    info	[Changelog]   - Enum KnownAzureVmSuitabilityExplanation has a new value NoVmSizeFoundForOfferCurrencyReservedInstance
    info	[Changelog]   - Enum KnownAzureVmSuitabilityExplanation has a new value NoVmSizeInSelectedFamilyFound
    info	[Changelog]   - Enum KnownMachineBootType has a new value NotSpecified
    info	[Changelog]   - Enum KnownProvisioningState has a new value Canceled
    info	[Changelog]   - Enum KnownProvisioningState has a new value Provisioning
    info	[Changelog]   - Enum KnownProvisioningState has a new value Updating
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Removed operation group AssessedMachines
    info	[Changelog]   - Removed operation group Assessments
    info	[Changelog]   - Removed operation group Groups
    info	[Changelog]   - Removed operation group HyperVCollectors
    info	[Changelog]   - Removed operation group ImportCollectors
    info	[Changelog]   - Removed operation group Machines
    info	[Changelog]   - Removed operation group Projects
    info	[Changelog]   - Removed operation group ServerCollectors
    info	[Changelog]   - Removed operation group VMwareCollectors
    info	[Changelog]   - Removed operation PrivateEndpointConnectionOperations.listByProject
    info	[Changelog]   - Removed operation PrivateEndpointConnectionOperations.update
    info	[Changelog]   - Removed operation PrivateLinkResourceOperations.listByProject
    info	[Changelog]   - Operation PrivateEndpointConnectionOperations.delete has a new signature
    info	[Changelog]   - Operation PrivateEndpointConnectionOperations.get has a new signature
    info	[Changelog]   - Operation PrivateLinkResourceOperations.get has a new signature
    info	[Changelog]   - Deleted Class AzureMigrateV2
    info	[Changelog]   - Interface AssessedMachine no longer has parameter eTag
    info	[Changelog]   - Interface AssessedMachine no longer has parameter id
    info	[Changelog]   - Interface AssessedMachine no longer has parameter name
    info	[Changelog]   - Interface AssessedMachine no longer has parameter properties
    info	[Changelog]   - Interface AssessedMachine no longer has parameter type
    info	[Changelog]   - Interface Assessment no longer has parameter eTag
    info	[Changelog]   - Interface Assessment no longer has parameter id
    info	[Changelog]   - Interface Assessment no longer has parameter name
    info	[Changelog]   - Interface Assessment no longer has parameter properties
    info	[Changelog]   - Interface Assessment no longer has parameter type
    info	[Changelog]   - Interface AssessmentOptions no longer has parameter id
    info	[Changelog]   - Interface AssessmentOptions no longer has parameter name
    info	[Changelog]   - Interface AssessmentOptions no longer has parameter properties
    info	[Changelog]   - Interface Group no longer has parameter eTag
    info	[Changelog]   - Interface Group no longer has parameter id
    info	[Changelog]   - Interface Group no longer has parameter name
    info	[Changelog]   - Interface Group no longer has parameter properties
    info	[Changelog]   - Interface Group no longer has parameter type
    info	[Changelog]   - Interface ImportCollector no longer has parameter eTag
    info	[Changelog]   - Interface ImportCollector no longer has parameter id
    info	[Changelog]   - Interface ImportCollector no longer has parameter name
    info	[Changelog]   - Interface ImportCollector no longer has parameter properties
    info	[Changelog]   - Interface ImportCollector no longer has parameter type
    info	[Changelog]   - Interface Machine no longer has parameter eTag
    info	[Changelog]   - Interface Machine no longer has parameter id
    info	[Changelog]   - Interface Machine no longer has parameter name
    info	[Changelog]   - Interface Machine no longer has parameter properties
    info	[Changelog]   - Interface Machine no longer has parameter type
    info	[Changelog]   - Interface PrivateEndpointConnection no longer has parameter eTag
    info	[Changelog]   - Interface PrivateEndpointConnection no longer has parameter id
    info	[Changelog]   - Interface PrivateEndpointConnection no longer has parameter name
    info	[Changelog]   - Interface PrivateEndpointConnection no longer has parameter properties
    info	[Changelog]   - Interface PrivateEndpointConnection no longer has parameter type
    info	[Changelog]   - Interface PrivateLinkResource no longer has parameter id
    info	[Changelog]   - Interface PrivateLinkResource no longer has parameter name
    info	[Changelog]   - Interface PrivateLinkResource no longer has parameter properties
    info	[Changelog]   - Interface PrivateLinkResource no longer has parameter type
    info	[Changelog]   - Interface ProjectProperties no longer has parameter lastAssessmentTimestamp
    info	[Changelog]   - Interface ProjectProperties no longer has parameter numberOfAssessments
    info	[Changelog]   - Interface ProjectProperties no longer has parameter numberOfGroups
    info	[Changelog]   - Interface ProjectProperties no longer has parameter numberOfMachines
    info	[Changelog]   - Interface ServerCollector no longer has parameter eTag
    info	[Changelog]   - Interface ServerCollector no longer has parameter id
    info	[Changelog]   - Interface ServerCollector no longer has parameter name
    info	[Changelog]   - Interface ServerCollector no longer has parameter properties
    info	[Changelog]   - Interface ServerCollector no longer has parameter type
    info	[Changelog]   - Parameter assessmentReportUrl of interface DownloadUrl is now required
    info	[Changelog]   - Parameter expirationTime of interface DownloadUrl is now required
    info	[Changelog]   - Type of parameter groupType of interface GroupProperties is changed from string to GroupType
    info	[Changelog]   - Type of parameter origin of interface Operation is changed from string to Origin
    info	[Changelog]   - Type of parameter status of interface PrivateLinkServiceConnectionState is changed from PrivateLinkServiceConnectionStateStatus to PrivateEndpointServiceConnectionStatus
    info	[Changelog]   - Removed Enum KnownCurrency
    info	[Changelog]   - Removed Enum KnownPrivateEndpointConnectionPropertiesProvisioningState
    info	[Changelog]   - Removed Enum KnownPrivateLinkServiceConnectionStateStatus
    info	[Changelog]   - Removed Enum KnownReservedInstance
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE10
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE15
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE20
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE30
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE4
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE40
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE50
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE6
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE60
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE70
    info	[Changelog]   - Enum KnownAzureDiskSize no longer has value StandardSSDE80
    info	[Changelog]   - Enum KnownProvisioningState no longer has value Creating
    info	[Changelog]   - Enum KnownProvisioningState no longer has value Moving
️❌ azure-resource-manager-schemas failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from d686188. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.3
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.3` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
    cannot force update branch 'sdkAuto/migrate' as it is the current HEAD of the repository.
    Error: cannot force update branch 'sdkAuto/migrate' as it is the current HEAD of the repository.
  • ️✔️migrate [View full logs
  • ️✔️migrate [View full logs
    error	Fatal error: cannot force update branch 'sdkAuto/migrate' as it is the current HEAD of the repository.
    error	The following packages are still pending:
    error		migrate
    error		migrate
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from d686188. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.migrate.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.migrate.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/migrate/armmigrate https://apiview.dev/Assemblies/Review/fe784a9a111241e39e51665ad275b310
JavaScript @azure/arm-migrate https://apiview.dev/Assemblies/Review/aac9d0db1d554b8d904d1f589a5ae9c7

@srilipta-swain srilipta-swain marked this pull request as ready for review November 6, 2023 05:30
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Nov 6, 2023
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Nov 6, 2023
@kuchatur-ms
Copy link
Contributor

link to breaking change review ado item. https://msazure.visualstudio.com/One/_workitems/edit/25725210

@mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 6, 2023
@kuchatur-ms kuchatur-ms added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 6, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 6, 2023
@zizw123 zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 7, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 7, 2023
@Alancere Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Nov 7, 2023
@kuchatur-ms
Copy link
Contributor

/pr RequestMerge

@zizw123 zizw123 merged commit d686188 into main Nov 8, 2023
@zizw123 zizw123 deleted the srilipta-swain-migrate-Microsoft.Migrate-2023-03-15 branch November 8, 2023 18:09
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants