migrate from apis in private repo to preview (new pricing model api and migration apis) #2618

frankguodongchen · 2018-03-08T20:19:11Z

The PR approved in private repo are:
https://github.com/Azure/azure-rest-api-specs-pr/pull/275
https://github.com/Azure/azure-rest-api-specs-pr/pull/356

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-03-08T20:20:08Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2487

AutorestCI · 2018-03-08T20:22:07Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1352

AutorestCI · 2018-03-08T20:43:27Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2022

lmazuel · 2018-03-09T00:09:07Z

specification/applicationinsights/resource-manager/readme.md

@@ -318,6 +330,7 @@ go:
 ``` yaml $(go) && $(multiapi)
 batch:
  - tag: package-2015-05
+  - tag: pacakge-2017-10


AutorestCI · 2018-03-19T17:51:25Z

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp_zg53742/rest/specification/applicationinsights/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmp_zg53742/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4259; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4259/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4259)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.49)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/applicationinsights/implementation/FavoritesInner.java
   at AutoRest.Core.CodeGenerator.<Write>d__13.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.<Generate>d__6.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISHedxhk\164_20180307T193002\autorest.java\src\azurefluent\CodeGeneratorJvaf.cs:line 57
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISHedxhk\164_20180307T193002\autorest.java\src\Program.cs:line 115
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
Process() cancelled due to exception : Plugin java reported failure.
  Error: Plugin java reported failure.

lmazuel · 2018-03-19T22:04:18Z

...pplicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/components_API.json

          }
        },
        "x-ms-examples": {
          "ComponentPurge": {
            "$ref": "./examples/ComponentsPurge.json"
          }
-        }
+        },
+        "x-ms-long-running-operation": true


This is likely the wrong thing to do if we look at the exampl

lmazuel · 2018-03-19T22:04:49Z

...ghts/resource-manager/microsoft.insights/preview/2017-10-01/eaSubscriptionMigration_API.json

@@ -0,0 +1,193 @@
+{


I don't find the private version of this file in the two private PRs you mention? Am I missing something?

Ok found it

lmazuel · 2018-03-19T22:05:43Z

.../resource-manager/microsoft.insights/preview/2017-10-01/componentFeaturesAndPricing_API.json

@@ -0,0 +1,258 @@
+{


This one looks like the one in https://github.com/Azure/azure-rest-api-specs-pr/pull/275/files

This reverts commit 7c3b723.

This reverts commit 2685ce7.

This reverts commit 450ec6d.

lmazuel · 2018-03-20T16:47:45Z

@frankguodongchen I found the issue, there is an extra space in the example :/. I'm fixing it in your PR directly, since I truly think it will be the LAST change :)

lmazuel · 2018-03-20T16:58:19Z

A few final comments:

PR was reviewed in the private side, I just took a quick look to see if it was the same file, but nothing deep
Swagger files are not plugged into the Readme on purpose for now, since it's preview folder and @frankguodongchen prefers to work on some scenario for C# first. I find this reasonable. @frankguodongchen , please do another PR to add this to the Readme when you feel comfortable that all customers of all languages can take benefits of your Swaggers.

frankguodongchen added 6 commits January 25, 2018 16:57

add capabilities related apis

993a387

remove unnecesary change in pacakge.json

6b47658

update for code review feedback

2c6ec69

merge from upstream and resolve conflict

64718ec

merge from upstream

5c2c430

add preview api for new pricing version and migration related api

0853566

azuresdkci assigned lmazuel Mar 8, 2018

lmazuel reviewed Mar 9, 2018

View reviewed changes

frankguodongchen added 3 commits March 9, 2018 10:07

fix typo

af65a96

merge from upstream

7cf51c4

fix for x-ms-long-running-operation required for purge api

450ec6d

frankguodongchen requested a review from a user March 19, 2018 17:46

frankguodongchen requested review from kay-owolabi and tiffanyachen as code owners March 19, 2018 17:46

AutorestCI mentioned this pull request Mar 19, 2018

[AutoPR applicationinsights/resource-manager] migrate from apis in private repo to preview (new pricing model api and migration apis) Azure/azure-sdk-for-python#2218

Merged

Merge remote-tracking branch 'upstream/master'

c020c37

lmazuel reviewed Mar 19, 2018

View reviewed changes

Revert "Fix AppInsights x-ms-parameter-location (Azure#2680)"

2685ce7

This reverts commit 7c3b723.

AutorestCI mentioned this pull request Mar 19, 2018

[AutoPR applicationinsights/resource-manager] migrate from apis in private repo to preview (new pricing model api and migration apis) Azure/azure-sdk-for-node#2471

Merged

frankguodongchen added 4 commits March 19, 2018 15:18

Revert "Revert "Fix AppInsights x-ms-parameter-location (Azure#2680)""

5fa14d6

This reverts commit 2685ce7.

Revert "fix for x-ms-long-running-operation required for purge api"

cb90d73

This reverts commit 450ec6d.

change microsoft.insights to Microsoft.Insights

c374857

fix ova error and remove preview api from go sdk

15fb387

AutorestCI mentioned this pull request Mar 19, 2018

[AutoPR applicationinsights/resource-manager] migrate from apis in private repo to preview (new pricing model api and migration apis) Azure/azure-sdk-for-go#1345

Merged

Remove extra space

6143261

lmazuel approved these changes Mar 20, 2018

View reviewed changes

lmazuel merged commit cb3e2a7 into Azure:master Mar 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate from apis in private repo to preview (new pricing model api and migration apis) #2618

migrate from apis in private repo to preview (new pricing model api and migration apis) #2618

frankguodongchen commented Mar 8, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 8, 2018 •

edited

Loading

AutorestCI commented Mar 8, 2018 •

edited

Loading

AutorestCI commented Mar 8, 2018 •

edited

Loading

lmazuel Mar 9, 2018

AutorestCI commented Mar 19, 2018 •

edited

Loading

lmazuel Mar 19, 2018

lmazuel Mar 19, 2018

lmazuel Mar 19, 2018

lmazuel Mar 19, 2018

lmazuel commented Mar 20, 2018

lmazuel commented Mar 20, 2018

migrate from apis in private repo to preview (new pricing model api and migration apis) #2618

migrate from apis in private repo to preview (new pricing model api and migration apis) #2618

Conversation

frankguodongchen commented Mar 8, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Mar 8, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Mar 8, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Mar 8, 2018 • edited Loading

Automation for azure-sdk-for-python

lmazuel Mar 9, 2018

Choose a reason for hiding this comment

AutorestCI commented Mar 19, 2018 • edited Loading

Automation for azure-libraries-for-java

lmazuel Mar 19, 2018

Choose a reason for hiding this comment

lmazuel Mar 19, 2018

Choose a reason for hiding this comment

lmazuel Mar 19, 2018

Choose a reason for hiding this comment

lmazuel Mar 19, 2018

Choose a reason for hiding this comment

lmazuel commented Mar 20, 2018

lmazuel commented Mar 20, 2018

frankguodongchen commented Mar 8, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 8, 2018 •

edited

Loading

AutorestCI commented Mar 8, 2018 •

edited

Loading

AutorestCI commented Mar 8, 2018 •

edited

Loading

AutorestCI commented Mar 19, 2018 •

edited

Loading