-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Query Parameter to GenerateSshKeyPair API #26090
Changes from all commits
68d4334
b62b295
219ca89
1f89059
16f37d0
4516197
aac28ae
b3754cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"parameters": { | ||
"subscriptionId": "{subscription-id}", | ||
"resourceGroupName": "myResourceGroup", | ||
"api-version": "2023-09-01", | ||
"sshPublicKeyName": "mySshPublicKeyName", | ||
"parameters": { | ||
"encryptionType": "RSA" | ||
} | ||
}, | ||
"responses": { | ||
"200": { | ||
"body": { | ||
"privateKey": "{ssh private key}", | ||
"publicKey": "{ssh-rsa public key}", | ||
"id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/SshPublicKeys/mySshPublicKeyName" | ||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"parameters": { | ||
"subscriptionId": "{subscription-id}", | ||
"resourceGroupName": "myResourceGroup", | ||
"api-version": "2023-09-01", | ||
"sshPublicKeyName": "mySshPublicKeyName", | ||
"parameters": { | ||
"encryptionType": "RSA" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Encryption Type should be Ed25519? |
||
} | ||
}, | ||
"responses": { | ||
"200": { | ||
"body": { | ||
"privateKey": "{ed25519 private key}", | ||
"publicKey": "{ed25519 public key}", | ||
"id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/SshPublicKeys/mySshPublicKeyName" | ||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -371,6 +371,15 @@ | |
"type": "string", | ||
"description": "The name of the SSH public key." | ||
}, | ||
{ | ||
"name": "parameters", | ||
"in": "body", | ||
"required": false, | ||
"schema": { | ||
"$ref": "#/definitions/SshGenerateKeyPairInputParameters" | ||
}, | ||
"description": "Parameters supplied to generate the SSH public key." | ||
}, | ||
{ | ||
"$ref": "../../../common-types/v1/common.json#/parameters/ApiVersionParameter" | ||
}, | ||
|
@@ -395,6 +404,12 @@ | |
"x-ms-examples": { | ||
"Generate an SSH key pair.": { | ||
"$ref": "./examples/sshPublicKeyExamples/SshPublicKey_GenerateKeyPair.json" | ||
}, | ||
"Generate an SSH key pair with RSA encryption.": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Generate a instead of an There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please update this occurrence in other places in this file |
||
"$ref": "./examples/sshPublicKeyExamples/SshPublicKey_GenerateKeyPair_EncryptionWithRSA.json" | ||
}, | ||
"Generate an SSH key pair with Ed25519 encryption.": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above Generate a instead of an |
||
"$ref": "./examples/sshPublicKeyExamples/SshPublicKey_GenerateKeyPair_EncryptionWithEd25519.json" | ||
} | ||
} | ||
} | ||
|
@@ -480,6 +495,24 @@ | |
"value" | ||
], | ||
"description": "The list SSH public keys operation response." | ||
}, | ||
"SshGenerateKeyPairInputParameters": { | ||
"type": "object", | ||
"properties": { | ||
"encryptionType": { | ||
"type": "string", | ||
"description": "The encryption type of the SSH keys to be generated. See SshEncryptionTypes for possible set of values. If not provided, will default to RSA", | ||
"enum": [ | ||
"RSA", | ||
"Ed25519" | ||
], | ||
"x-ms-enum": { | ||
"name": "SshEncryptionTypes", | ||
"modelAsString": true | ||
} | ||
} | ||
}, | ||
"description": "Parameters for GenerateSshKeyPair." | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example is for ED25519, but i think the example is for RSA . content is probably switched ?