Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Query Parameter to GenerateSshKeyPair API #26090

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Adding Query Parameter to GenerateSshKeyPair API #26090

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
68d4334
init
kamusta-msft Oct 4, 2023
b62b295
PR comments
kamusta-msft Oct 23, 2023
219ca89
Turning this into a POST
kamusta-msft Oct 26, 2023
1f89059
fix
kamusta-msft Oct 26, 2023
16f37d0
another fix
kamusta-msft Oct 27, 2023
4516197
fixes
kamusta-msft Oct 31, 2023
aac28ae
fixes
kamusta-msft Nov 1, 2023
b3754cf
fix
kamusta-msft Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .../stable/2023-09-01/examples/sshPublicKeyExamples/SshPublicKey_GenerateKeyPairEd25519.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"parameters": {
"subscriptionId": "{subscription-id}",
"resourceGroupName": "myResourceGroup",
"api-version": "2023-09-01",
"sshPublicKeyName": "mySshPublicKeyName",
"encryption": "ed25519"
},
"responses": {
"200": {
"body": {
"privateKey": "{ssh private key}",
"publicKey": "{ssh-rsa public key}",
"id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/SshPublicKeys/mySshPublicKeyName?api-version=2023-09-01&encryption=ed25519"
}
}
}
}
10 changes: 10 additions & 0 deletions .../compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2023-09-01/sshPublicKey.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,13 @@
"type": "string",
"description": "The name of the SSH public key."
},
{
"name": "encryption",
"in": "query",
"required": false,
"type": "string",
"description": "SshKey pair encryption type. Options available are: ed25519 or rsa [encryption=ed25519 or encryption=rsa]. Default is RSA."
},
{
"$ref": "../../../common-types/v1/common.json#/parameters/ApiVersionParameter"
},
Expand All @@ -395,6 +402,9 @@
"x-ms-examples": {
"Generate an SSH key pair.": {
"$ref": "./examples/sshPublicKeyExamples/SshPublicKey_GenerateKeyPair.json"
},
"Generate an SSH key pair with Ed25519 encryption.": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above Generate a instead of an

"$ref": "./examples/sshPublicKeyExamples/SshPublicKey_GenerateKeyPairEd25519.json"
}
}
}
Expand Down