Firewall Policy - IDPS profiles #25666

NiviShenker · 2023-09-05T19:47:37Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- Added new property to firewall policy intrusion detection

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-09-05T19:47:40Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-09-05T19:47:41Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
firewallPolicy.json	2023-06-01(578d4b0)	2023-05-01(main)

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.5)	new version	base version
package-2023-06	package-2023-06(578d4b0)	package-2023-06(release-network-Microsoft.Network-official-2023-06-01)

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ PageableOperation	Based on the response model schema, operation 'FirewallPolicyIdpsSignaturesOverrides_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Network/stable/2023-06-01/firewallPolicy.json#L897

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-05T19:47:42Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 7091a6f5c00fdfe5851df39621159a8f209e9293. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Network [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Network.26.0.0.nupkg
- Microsoft.Azure.Management.Network.26.0.0.symbols.nupkg

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 7091a6f5c00fdfe5851df39621159a8f209e9293. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Network [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.Network.1.6.0-alpha.20230924.1.nupkg
```
info	[Changelog]
```

️❌ azure-sdk-for-python-track2 failed [Detail]

❌Code Generator Failed [Logs] Generate from 7091a6f5c00fdfe5851df39621159a8f209e9293. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 7091a6f5c00fdfe5851df39621159a8f209e9293. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 7091a6f5c00fdfe5851df39621159a8f209e9293. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `BastionHostSKUNameDeveloper` added to enum type `BastionHostSKUName`
info	[Changelog] - New value `FirewallPolicyIDPSSignatureDirectionFour`, `FirewallPolicyIDPSSignatureDirectionThree` added to enum type `FirewallPolicyIDPSSignatureDirection`
info	[Changelog] - New enum type `FirewallPolicyIntrusionDetectionProfileType` with values `FirewallPolicyIntrusionDetectionProfileTypeAdvanced`, `FirewallPolicyIntrusionDetectionProfileTypeBasic`, `FirewallPolicyIntrusionDetectionProfileTypeExtended`, `FirewallPolicyIntrusionDetectionProfileTypeStandard`
info	[Changelog] - New function `*ManagementClient.BeginDeleteBastionShareableLinkByToken(context.Context, string, string, BastionShareableLinkTokenListRequest, *ManagementClientBeginDeleteBastionShareableLinkByTokenOptions) (*runtime.Poller[ManagementClientDeleteBastionShareableLinkByTokenResponse], error)`
info	[Changelog] - New struct `BastionShareableLinkTokenListRequest`
info	[Changelog] - New field `Profile` in struct `FirewallPolicyIntrusionDetection`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 12 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 7091a6f5c00fdfe5851df39621159a8f209e9293. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [View full logs] [Preview SDK Changes]

azure-arm-network-32.3.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface BastionShareableLinkTokenListRequest
info	[Changelog]   - Added Interface DeleteBastionShareableLinkByTokenOptionalParams
info	[Changelog]   - Added Type Alias FirewallPolicyIntrusionDetectionProfileType
info	[Changelog]   - Interface FirewallPolicyIntrusionDetection has a new optional parameter profile
info	[Changelog]   - Added Enum KnownFirewallPolicyIntrusionDetectionProfileType
info	[Changelog]   - Enum KnownBastionHostSkuName has a new value Developer

️🔄 azure-resource-manager-schemas inProgress [Detail]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 7091a6f5c00fdfe5851df39621159a8f209e9293. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.network.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.network.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-05T19:47:42Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	Create ApiView failed. Please ask PR assignee for help
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/d5bf310430714f0ba33ed408161adc84
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/6161c68e6b4f428ebb91e59f6dabad5a
.Net	Azure.ResourceManager.Network	https://apiview.dev/Assemblies/Review/492169fde3cd47849911853892952ff6
Swagger	Microsoft.Network	https://apiview.dev/Assemblies/Review/96ac75160f464ad3b78a7b49fffdbb22

specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/firewallPolicy.json

openapi-workflow-bot · 2023-09-16T01:36:02Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/firewallPolicy.json

visingla-ms · 2023-09-24T20:12:03Z

/azp run

azure-pipelines · 2023-09-24T20:12:17Z

Azure Pipelines successfully started running 2 pipeline(s).

NiviShenker · 2023-09-24T20:59:34Z

/pr RequestMerge

* Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * Add missing DeleteBastionShareableLinkByToken API back to swagger (#25599) * add DeleteBastionShareableLinkByToken endpoint * fix location link format * Adding Developer Sku (#25887) * Firewall Policy - IDPS profiles (#25666) * add profile to put example * fixed RuleCollectionGroupWithHttpHeadersToInsert example * add profile to Policy model * description change * indentation * ListIdpsSignatures description change * direction description+enum fix * fix FirewallPolicyIDPSSignatureSeverity description * hostnames for l4 listeners (#25982) * added ergwscale support (#25969) * Fixed examples for gateway load balancer (#26058) * Add support for JSChallenge action in Application Gateway Web application Firewall (#26149) * Add support for JSChallenge action Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules * Update WafPolicyGet.json * Update WafPolicyCreateOrUpdate.json * DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (#26248) * fixes * making changes in new api version --------- Co-authored-by: Manas Chakka <manaschakka@microsoft.com> * [NVA] Internet Ingress Parameters (#26262) * [NVA] Internet Ingress Parameters * LintDiff Fix * Minor Fix * Added description for each of the enums for ApplicationGatewayProtocol (#26437) * Added description for each of the enums for ApplicationGatewayProtocol * Spacing for prettier checks * Remove routingConfigNfv (#25962) * remove routingConfigNfv * remove api from older versions * remove PUT nvaconnection from older versions * apply prettier check * add suppression for modelValidation * remove suppression due to approval * Fix lint errors & add supressions (#26494) * fix lint error * add supression for ResourceNameRestriction & LroErrorContent * fix example accordingly --------- Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com> Co-authored-by: Sijie Lin <97983749+msftsijielin@users.noreply.github.com> Co-authored-by: anvrao1 <109107918+anvrao1@users.noreply.github.com> Co-authored-by: NiviShenker <99583088+NiviShenker@users.noreply.github.com> Co-authored-by: gdhillon24 <105729965+gdhillon24@users.noreply.github.com> Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: Manas Chakka <mchakka@gmail.com> Co-authored-by: Manas Chakka <manaschakka@microsoft.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: rutuja-s <42910715+rutuja-s@users.noreply.github.com>

NiviShenker added 3 commits September 5, 2023 22:25

add profile to put example

69ed33b

fixed RuleCollectionGroupWithHttpHeadersToInsert example

a278612

add profile to Policy model

983c517

NiviShenker marked this pull request as ready for review September 5, 2023 19:47

NiviShenker requested a review from Joanna-Yang-Art as a code owner September 5, 2023 19:47

openapi-assignment-bot bot assigned rkmanda Sep 5, 2023

azure-sdk mentioned this pull request Sep 5, 2023

[AutoPR sdk/resourcemanager/network/armnetwork] Firewall Policy - IDPS profiles azure-sdk/azure-sdk-for-go#7202

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 5, 2023

description change

95eb9ee

NiviShenker force-pushed the nivishenker/IDPS-profiles branch from e93c15c to 95eb9ee Compare September 10, 2023 10:27

NiviShenker and others added 4 commits September 10, 2023 13:34

indentation

36f1364

ListIdpsSignatures description change

4cf2c26

direction description+enum fix

a2406c9

fix FirewallPolicyIDPSSignatureSeverity description

578d4b0

rkmanda reviewed Sep 16, 2023

View reviewed changes

specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/firewallPolicy.json Show resolved Hide resolved

rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 16, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2023

bewatersmsft removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 21, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 21, 2023

visingla-ms reviewed Sep 22, 2023

View reviewed changes

specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/firewallPolicy.json Show resolved Hide resolved

visingla-ms added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 22, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 22, 2023

visingla-ms added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Sep 24, 2023

openapi-workflow-bot bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Sep 24, 2023

visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 24, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 24, 2023

This comment was marked as duplicate.

Sign in to view

github-actions bot added the MergeRequested label Sep 24, 2023

visingla-ms approved these changes Sep 25, 2023

View reviewed changes

visingla-ms merged commit daba446 into Azure:release-network-Microsoft.Network-official-2023-06-01 Sep 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Firewall Policy - IDPS profiles #25666

Firewall Policy - IDPS profiles #25666

NiviShenker commented Sep 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 5, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 5, 2023 •

edited

Loading

openapi-workflow-bot bot commented Sep 16, 2023

visingla-ms commented Sep 24, 2023

azure-pipelines bot commented Sep 24, 2023

NiviShenker commented Sep 24, 2023

This comment was marked as duplicate.

Firewall Policy - IDPS profiles #25666

Firewall Policy - IDPS profiles #25666

Conversation

NiviShenker commented Sep 5, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Sep 5, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Sep 5, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 5, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 5, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Sep 16, 2023

visingla-ms commented Sep 24, 2023

azure-pipelines bot commented Sep 24, 2023

NiviShenker commented Sep 24, 2023

This comment was marked as duplicate.

NiviShenker commented Sep 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 5, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 5, 2023 •

edited

Loading