Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java mgmt api center, fix service-name case #25534

Merged
merged 1 commit into from
Aug 25, 2023
Merged

java mgmt api center, fix service-name case #25534

merged 1 commit into from
Aug 25, 2023

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao added the Mgmt This issue is related to a management-plane library. label Aug 25, 2023
@XiaofeiCao XiaofeiCao self-assigned this Aug 25, 2023
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 25, 2023 •
edited
Loading

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 25, 2023 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.4) new version base version
default default(6080684) default(main)
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 25, 2023 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/apicenter/armapicenter - Approved - 0.2.0
+	Function `*ServicesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, Service, *ServicesClientCreateOrUpdateOptions)` to `(context.Context, string, string, Service, *ServicesClientCreateOrUpdateOptions)`
+	Function `*ServicesClient.Delete` parameter(s) have been changed from `(context.Context, string, *ServicesClientDeleteOptions)` to `(context.Context, string, string, *ServicesClientDeleteOptions)`
+	Function `*ServicesClient.Get` parameter(s) have been changed from `(context.Context, string, *ServicesClientGetOptions)` to `(context.Context, string, string, *ServicesClientGetOptions)`
+	Function `*ServicesClient.Update` parameter(s) have been changed from `(context.Context, string, ServiceUpdate, *ServicesClientUpdateOptions)` to `(context.Context, string, string, ServiceUpdate, *ServicesClientUpdateOptions)`
+	Function `NewClientFactory` parameter(s) have been changed from `(string, string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, azcore.TokenCredential, *arm.ClientOptions)`
+	Function `NewServicesClient` parameter(s) have been changed from `(string, string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, azcore.TokenCredential, *arm.ClientOptions)`
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 5d2f32d. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
cmderr	[automation_generate.sh] npm notice
warn	No file changes detected after generation
warn	No package detected after generation
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 5d2f32d. SDK Automation 14.0.0 
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-apicenter [View full logs]  [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 5d2f32d. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/apicenter/armapicenter [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `NewClientFactory` parameter(s) have been changed from `(string, string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, azcore.TokenCredential, *arm.ClientOptions)`
info	[Changelog] - Function `NewServicesClient` parameter(s) have been changed from `(string, string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, azcore.TokenCredential, *arm.ClientOptions)`
info	[Changelog] - Function `*ServicesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, Service, *ServicesClientCreateOrUpdateOptions)` to `(context.Context, string, string, Service, *ServicesClientCreateOrUpdateOptions)`
info	[Changelog] - Function `*ServicesClient.Delete` parameter(s) have been changed from `(context.Context, string, *ServicesClientDeleteOptions)` to `(context.Context, string, string, *ServicesClientDeleteOptions)`
info	[Changelog] - Function `*ServicesClient.Get` parameter(s) have been changed from `(context.Context, string, *ServicesClientGetOptions)` to `(context.Context, string, string, *ServicesClientGetOptions)`
info	[Changelog] - Function `*ServicesClient.Update` parameter(s) have been changed from `(context.Context, string, ServiceUpdate, *ServicesClientUpdateOptions)` to `(context.Context, string, string, ServiceUpdate, *ServicesClientUpdateOptions)`
info	[Changelog]
info	[Changelog] Total 6 breaking change(s), 0 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 5d2f32d. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-apicenter [View full logs]  [Release SDK Changes] 
    info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 5d2f32d. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
  • ️✔️apicenter [View full logs] 
️❌ azure-powershell failed [Detail]
  • ❌Pipeline Framework Failed [Logs]Release - Generate from 5d2f32d. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.apicenter.DefaultTag [View full logs]  
    error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.apicenter.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 25, 2023 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/apicenter/armapicenter https://apiview.dev/Assemblies/Review/4a7fd5ff51a44ba3b6ae9be43d01bf7b
Java azure-resourcemanager-apicenter https://apiview.dev/Assemblies/Review/a5cd57e735e04866a5edfb1278b4ff61
JavaScript @azure/arm-apicenter https://apiview.dev/Assemblies/Review/1b1d2c2503be49028398083f0e4574a4

@azure-sdk azure-sdk mentioned this pull request Aug 25, 2023
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 25, 2023
@XiaofeiCao XiaofeiCao removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMReview labels Aug 25, 2023
This was referenced Aug 25, 2023
Closed
Closed
@XiaofeiCao
Copy link
Contributor Author

For java mgmt codegen. No modification for existing swagger files.

@XiaofeiCao XiaofeiCao added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Aug 25, 2023
@XiaofeiCao XiaofeiCao merged commit 5d2f32d into Azure:main Aug 25, 2023
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

This was referenced Aug 25, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

Assignees

@XiaofeiCao XiaofeiCao

Labels
Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go CI-BreakingChange-Go Mgmt This issue is related to a management-plane library. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XiaofeiCao @weidongxu-microsoft @AzureRestAPISpecReview