[Fleet] fix typespec validation - operationId warning #25109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serbrech
commented
Aug 2, 2023
- remove unecessary operationid annotation for ListBySubscription
- suppress warning for Fleets_CreateOrUpdate operationid
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"details":"The generated swagger file 2022-09-02-preview/fleets.json from typespec specification/containerservice/Fleet.Management is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2022-09-02-preview/fleets.json' in PR, please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log." |
|
"details":"The generated swagger file 2023-03-15-preview/fleets.json from typespec specification/containerservice/Fleet.Management is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/containerservice/resource-manager/Microsoft.ContainerService/fleet/preview/2023-03-15-preview/fleets.json' in PR, please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log." |
|
"details":"The generated swagger file 2023-06-15-preview/fleets.json from typespec specification/containerservice/Fleet.Management is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/containerservice/resource-manager/Microsoft.ContainerService/fleet/preview/2023-06-15-preview/fleets.json' in PR, please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log." |
️⌛PR Summary pending [Detail]
️⌛Automated merging requirements met pending [Detail]
|
Hi, @serbrech! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Generation Artifacts
|
Generated ApiView
|
61c0c14 to
43124d8
Compare
FumingZhang
approved these changes
Aug 2, 2023
ms-henglu
pushed a commit
that referenced
this pull request
Aug 25, 2023
* Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview * Updates readme * Updates API version in new specs and examples * [Fleet][Dev] API 0615 changes (#25020) * Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview * Updates readme * Updates API version in new specs and examples * sync with ADO repo * exclude unneeded file changes * revert tsp config * revert helpers.tsp * remove package files * remove package files * add known word containerd * format * remove .npmrc * revert custom word * revert package-lock.json * re-generate json * add example * add example * fix read-only fields * fix read-only fields * re-generate json with latest compiler * add custom word back * re-generate json * restore config * add examples * add examples * add examples * add examples * add examples * add examples * prettier * fix examples * git ignore * review commoents * fix examples * make node image selection optional * fix warnings * fix warnings * fix warnings * fix docs * revert package changes * compile * fix tspconfig (#25031) * [Fleet][readmes] Dev aks fleet 2023 06 15 preview readmes (#25033) * update readmes * fix readme mistake * fix operationid warnings (#25109) * tsp format (#25111) * Fix aks fleet 2023 06 15 preview patchasync from 0615 (#25131) * do the breaking change only from 0615 * fix patch * compile to get examples * remove sample * fix member upate operation (#25134) * revert extension removal (#25189) * generate with type spec v0.47.0 (#25484) --------- Co-authored-by: Stéphane Erbrech <stephane.erbrech@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.