-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused property required from Jobs ARM resource. #24053
Conversation
…preview to version 2023-04-01-preview
…me (Azure#23496) * Support SubPath in volume mount and mount options for azure file volume * update description
* add replica/container running state * spell error fix
* add event trigger for Container Jobs 2023-04-01-preview * prettier and avocado fix --------- Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
* Resolve Comments for Event driven jobs * change scaling rule to azure-servicebus * update example --------- Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Hi, @trajkobal Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
AuthConfigs.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
AuthConfigs.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
AvailableWorkloadProfiles.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
AvailableWorkloadProfiles.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
BillingMeters.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
BillingMeters.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
CommonDefinitions.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
CommonDefinitions.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
ConnectedEnvironments.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
ConnectedEnvironments.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
ConnectedEnvironmentsCertificates.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
ConnectedEnvironmentsCertificates.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
ConnectedEnvironmentsDaprComponents.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
ConnectedEnvironmentsDaprComponents.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
ConnectedEnvironmentsStorages.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
ConnectedEnvironmentsStorages.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
ContainerApps.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
ContainerApps.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
ContainerAppsRevisions.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
ContainerAppsRevisions.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
Diagnostics.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
Diagnostics.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
Global.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
Global.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
ManagedEnvironments.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
ManagedEnvironments.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
ManagedEnvironmentsDaprComponents.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
ManagedEnvironmentsDaprComponents.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
ManagedEnvironmentsStorages.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
ManagedEnvironmentsStorages.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
SourceControls.json | 2023-04-01-preview(9f1cdfc) | 2022-10-01(main) |
SourceControls.json | 2023-04-01-preview(9f1cdfc) | 2022-11-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/9f1cdfcb46de5c4cb096fa4cd4458363d29828ab/specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/Jobs.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/Jobs.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.53/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=/mnt/vss/_work/1/cross-version-c93b354fd9c14905bb574a8834c4d69b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/Jobs.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Schema violation: Array is too short (0), minimum 1\n - file:///mnt/vss/_work/1/cross-version-c93b354fd9c14905bb574a8834c4d69b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/Jobs.json:791:6 ($.definitions.Job.required)\nFATAL: swagger-document/individual/schema-validator - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.\n" |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 1 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.2) | new version | base version |
---|---|---|
package-preview-2023-04 | package-preview-2023-04(9f1cdfc) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L712 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/AuthConfigs.json#L18 |
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/AuthConfigs.json#L67 |
ResourceNameRestriction |
The resource name parameter 'authConfigName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/AuthConfigs.json#L67 |
PutResponseSchemaDescription |
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.App/preview/2023-04-01-preview/AuthConfigs.json#L160 |
DefinitionsPropertiesNamesCamelCase |
Property name should be camel case. Location: Microsoft.App/preview/2023-04-01-preview/AuthConfigs.json#L547 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.App/preview/2023-04-01-preview/BillingMeters.json#L37 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironments.json#L100 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironments.json#L182 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironments.json#L198 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironments.json#L255 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironments.json#L311 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsCertificates.json#L18 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsCertificates.json#L68 |
ResourceNameRestriction |
The resource name parameter 'certificateName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsCertificates.json#L68 |
PutResponseSchemaDescription |
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsCertificates.json#L161 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsDaprComponents.json#L18 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsDaprComponents.json#L67 |
ResourceNameRestriction |
The resource name parameter 'componentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsDaprComponents.json#L67 |
PutResponseSchemaDescription |
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsDaprComponents.json#L160 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsDaprComponents.json#L235 |
ResourceNameRestriction |
The resource name parameter 'componentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsDaprComponents.json#L235 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsStorages.json#L18 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsStorages.json#L47 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsStorages.json#L65 |
ResourceNameRestriction |
The resource name parameter 'storageName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsStorages.json#L65 |
PutResponseSchemaDescription |
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.App/preview/2023-04-01-preview/ConnectedEnvironmentsStorages.json#L159 |
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/ContainerApps.json#L99 |
NoErrorCodeResponses |
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.App/preview/2023-04-01-preview/ContainerApps.json#L131 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.App/preview/2023-04-01-preview/ContainerApps.json#L182 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/ContainerApps.json#L198 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The JSON file has a circular reference. readme: specification/app/resource-manager/readme.md json: Microsoft.App/preview/2023-04-01-preview/CommonDefinitions.json |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @trajkobal, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi, @trajkobal, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
Hi, @trajkobal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @trajkobal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @trajkobal. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
Hi, @trajkobal. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.