Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emitter name in sdk auto config #23312

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

raych1
Copy link
Member

@raych1 raych1 commented Mar 27, 2023

updated schema of config too.

@openapi-workflow-bot
Copy link

Hi, @raych1 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 27, 2023

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/639179af4f5234faac62bf5340d0fc3c5ced2bcd/specificationRepositoryConfiguration.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specificationRepositoryConfiguration.json",
    "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.48/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=/mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: File 'file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')\n Error: File 'file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')\n"
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    unacceptable kind of an object to dump [object Error] "role":"Model Validation",
    "url":"https://github.com/Azure/azure-rest-api-specs/blob/639179af4f5234faac62bf5340d0fc3c5ced2bcd/specificationRepositoryConfiguration.json"
    ️❌SemanticValidation: 8 Errors, 0 Warnings failed [Detail]
    Rule Message
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: swagger
    JsonUrl: azure-rest-api-specs/blob/639179af4f5234faac62bf5340d0fc3c5ced2bcd/specificationRepositoryConfiguration.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: info
    JsonUrl: azure-rest-api-specs/blob/639179af4f5234faac62bf5340d0fc3c5ced2bcd/specificationRepositoryConfiguration.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: paths
    JsonUrl: azure-rest-api-specs/blob/639179af4f5234faac62bf5340d0fc3c5ced2bcd/specificationRepositoryConfiguration.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: $schema
    JsonUrl: azure-rest-api-specs/blob/639179af4f5234faac62bf5340d0fc3c5ced2bcd/specificationRepositoryConfiguration.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: pipelineName
    JsonUrl: azure-rest-api-specs/blob/639179af4f5234faac62bf5340d0fc3c5ced2bcd/specificationRepositoryConfiguration.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: sdkRepositoryMappings
    JsonUrl: azure-rest-api-specs/blob/639179af4f5234faac62bf5340d0fc3c5ced2bcd/specificationRepositoryConfiguration.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: overrides
    JsonUrl: azure-rest-api-specs/blob/639179af4f5234faac62bf5340d0fc3c5ced2bcd/specificationRepositoryConfiguration.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: typespecEmitterToSdkRepositoryMapping
    JsonUrl: azure-rest-api-specs/blob/639179af4f5234faac62bf5340d0fc3c5ced2bcd/specificationRepositoryConfiguration.json
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 27, 2023

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @raych1 raych1 assigned MaryGao and chunyu3 and unassigned archerzz Mar 27, 2023
    Copy link
    Member

    @MaryGao MaryGao left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @raych1 raych1 added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation Approved-SemanticValidation labels Mar 28, 2023
    @raych1
    Copy link
    Member Author

    raych1 commented Mar 28, 2023

    Approved CI checks because the change they're false alarms.

    @raych1 raych1 merged commit 3f8ca33 into main Mar 28, 2023
    @raych1 raych1 deleted the user/raych1/sdk-auto-config branch March 28, 2023 02:49
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation Approved-SemanticValidation
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants