[EventHubs]: Adding appropriate identifiers to array properties #23066

damodaravadhani · 2023-03-14T07:08:01Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2023-03-14T07:08:05Z

Hi, @damodaravadhani Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-03-14T07:08:07Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
ApplicationGroups.json	2022-01-01-preview(989ce52)	2022-01-01-preview(main)
networkrulessets-preview.json	2022-01-01-preview(989ce52)	2022-01-01-preview(main)
ApplicationGroups.json	2022-10-01-preview(989ce52)	2022-10-01-preview(main)
networkrulessets-preview.json	2022-10-01-preview(989ce52)	2022-10-01-preview(main)

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌LintDiff: 2 Errors, 0 Warnings failed [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-01-preview	package-2022-01-preview(989ce52)	package-2022-01-preview(main)
package-2022-10-preview	package-2022-10-preview(989ce52)	package-2022-10-preview(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
`❌` XmsIdentifierValidation	Missing identifier /properties/subnet/id in array item property Location: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json#L238
`❌` XmsIdentifierValidation	Missing identifier /properties/subnet/id in array item property Location: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json#L238

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L82
`❌` ResourceNameRestriction	The resource name parameter 'applicationGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L82
`❌` TrackedResourcePatchOperation	Tracked resource 'ApplicationGroup' must have patch operation that at least supports the update of tags. Location: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L82
`❌` OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'ApplicationGroup' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L87
`❌` AllResourcesMustHaveDelete	The resource NetworkRuleSet does not have a corresponding delete operation. Location: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json#L37
`❌` TrackedResourcePatchOperation	Tracked resource 'NetworkRuleSet' must have patch operation that at least supports the update of tags. Location: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json#L128
`❌` MissingTypeObject	The schema 'Subnet' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json#L172
`❌` MissingTypeObject	The schema 'NWRuleSetIpRules' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json#L181
`❌` MissingTypeObject	The schema 'NWRuleSetVirtualNetworkRules' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json#L202
`❌` MissingTypeObject	The schema 'NetworkRuleSet' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json#L216
`❌` MissingTypeObject	The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json#L218
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/ApplicationGroups.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/ApplicationGroups.json#L82
`❌` ResourceNameRestriction	The resource name parameter 'applicationGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/ApplicationGroups.json#L82
`❌` TrackedResourcePatchOperation	Tracked resource 'ApplicationGroup' must have patch operation that at least supports the update of tags. Location: Microsoft.EventHub/preview/2022-10-01-preview/ApplicationGroups.json#L82
`❌` OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'ApplicationGroup' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.EventHub/preview/2022-10-01-preview/ApplicationGroups.json#L87
`❌` AllResourcesMustHaveDelete	The resource NetworkRuleSet does not have a corresponding delete operation. Location: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json#L37
`❌` TrackedResourcePatchOperation	Tracked resource 'NetworkRuleSet' must have patch operation that at least supports the update of tags. Location: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json#L128
`❌` MissingTypeObject	The schema 'Subnet' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json#L172
`❌` MissingTypeObject	The schema 'NWRuleSetIpRules' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json#L181
`❌` MissingTypeObject	The schema 'NWRuleSetVirtualNetworkRules' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json#L202
`❌` MissingTypeObject	The schema 'NetworkRuleSet' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json#L216
`❌` MissingTypeObject	The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json#L218
⚠️ PreviewVersionOverOneYear	The API version:2022-01-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L6
⚠️ OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationGroupModel'. Consider using the plural form of 'ApplicationGroup' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L42

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` INVALID_REQUEST_PARAMETER	api-version 2022-10-01-preview is not equal to swagger version Url: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L38:14 ExampleUrl: 2022-01-01-preview/examples/ApplicationGroup/ApplicationGroupListByNamespace.json#L2:17
`❌` INVALID_REQUEST_PARAMETER	api-version 2022-10-01-preview is not equal to swagger version Url: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L83:14 ExampleUrl: 2022-01-01-preview/examples/ApplicationGroup/ApplicationGroupCreate.json#L2:17
`❌` INVALID_REQUEST_PARAMETER	api-version 2022-10-01-preview is not equal to swagger version Url: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L136:17 ExampleUrl: 2022-01-01-preview/examples/ApplicationGroup/ApplicationGroupDelete.json#L2:17
`❌` INVALID_REQUEST_PARAMETER	api-version 2022-10-01-preview is not equal to swagger version Url: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json#L179:14 ExampleUrl: 2022-01-01-preview/examples/ApplicationGroup/ApplicationGroupGet.json#L2:17

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️❌PrettierCheck: 4 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` HowToFix	Code style issues found path: Microsoft.EventHub/preview/2022-01-01-preview/ApplicationGroups.json
`❌` HowToFix	Code style issues found path: Microsoft.EventHub/preview/2022-01-01-preview/networkrulessets-preview.json
`❌` HowToFix	Code style issues found path: Microsoft.EventHub/preview/2022-10-01-preview/ApplicationGroups.json
`❌` HowToFix	Code style issues found path: Microsoft.EventHub/preview/2022-10-01-preview/networkrulessets-preview.json

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-03-14T07:08:08Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/eventhub/armeventhub - 1.1.0-beta.2

+	Field `Location` of struct `NetworkSecurityPerimeterConfiguration` has been removed
+	Field `Tags` of struct `NetworkSecurityPerimeterConfiguration` has been removed

❌azure-sdk-for-js - @azure/arm-eventhub - 6.0.0-beta.1

+	Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter skip
+	Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter top
+	Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter skip
+	Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter top
+	Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter skip
+	Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter top

❌azure-sdk-for-python-track2 - track2_azure-mgmt-eventhub - 11.0.0b1

+	Model NetworkSecurityPerimeterConfiguration no longer has parameter location
+	Model NetworkSecurityPerimeterConfiguration no longer has parameter tags

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from d34308fae5d3b21d05583315567a3be9478bd3dd. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.EventHubs [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.EventHubs.1.1.0-alpha.20230314.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from d34308fae5d3b21d05583315567a3be9478bd3dd. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.6.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-eventhub [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model Eventhub has a new parameter retention_description
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model NetworkSecurityPerimeterConfiguration no longer has parameter location
info	[Changelog]   - Model NetworkSecurityPerimeterConfiguration no longer has parameter tags

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from d34308fae5d3b21d05583315567a3be9478bd3dd. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-eventhubs-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from d34308fae5d3b21d05583315567a3be9478bd3dd. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/eventhub/armeventhub [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `Location` of struct `NetworkSecurityPerimeterConfiguration` has been removed
info	[Changelog] - Field `Tags` of struct `NetworkSecurityPerimeterConfiguration` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New type alias `CleanupPolicyRetentionDescription` with values `CleanupPolicyRetentionDescriptionCompaction`, `CleanupPolicyRetentionDescriptionDelete`
info	[Changelog] - New struct `RetentionDescription`
info	[Changelog] - New field `RetentionDescription` in struct `Properties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 6 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from d34308fae5d3b21d05583315567a3be9478bd3dd. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-eventhub [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-eventhub-6.0.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ApplicationGroupOperations
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationOperations
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurations
info	[Changelog]   - Added Interface ApplicationGroup
info	[Changelog]   - Added Interface ApplicationGroupCreateOrUpdateApplicationGroupOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupDeleteOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupGetOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceNextOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListResult
info	[Changelog]   - Added Interface ApplicationGroupPolicy
info	[Changelog]   - Added Interface NetworkSecurityPerimeter
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfiguration
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationList
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationListOptionalParams
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesProfile
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface NspAccessRule
info	[Changelog]   - Added Interface NspAccessRuleProperties
info	[Changelog]   - Added Interface NspAccessRulePropertiesSubscriptionsItem
info	[Changelog]   - Added Interface ProvisioningIssue
info	[Changelog]   - Added Interface ProvisioningIssueProperties
info	[Changelog]   - Added Interface RetentionDescription
info	[Changelog]   - Added Interface ThrottlingPolicy
info	[Changelog]   - Added Type Alias ApplicationGroupCreateOrUpdateApplicationGroupResponse
info	[Changelog]   - Added Type Alias ApplicationGroupGetResponse
info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceNextResponse
info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceResponse
info	[Changelog]   - Added Type Alias ApplicationGroupPolicyType
info	[Changelog]   - Added Type Alias ApplicationGroupPolicyUnion
info	[Changelog]   - Added Type Alias CleanupPolicyRetentionDescription
info	[Changelog]   - Added Type Alias MetricId
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationListResponse
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationProvisioningState
info	[Changelog]   - Added Type Alias NspAccessRuleDirection
info	[Changelog]   - Added Type Alias PublicNetworkAccess
info	[Changelog]   - Added Type Alias ResourceAssociationAccessMode
info	[Changelog]   - Added Type Alias TlsVersion
info	[Changelog]   - Interface Cluster has a new optional parameter supportsScaling
info	[Changelog]   - Interface EHNamespace has a new optional parameter minimumTlsVersion
info	[Changelog]   - Interface EHNamespace has a new optional parameter publicNetworkAccess
info	[Changelog]   - Interface Eventhub has a new optional parameter retentionDescription
info	[Changelog]   - Added Enum KnownApplicationGroupPolicyType
info	[Changelog]   - Added Enum KnownCleanupPolicyRetentionDescription
info	[Changelog]   - Added Enum KnownMetricId
info	[Changelog]   - Added Enum KnownNetworkSecurityPerimeterConfigurationProvisioningState
info	[Changelog]   - Added Enum KnownNspAccessRuleDirection
info	[Changelog]   - Added Enum KnownPublicNetworkAccess
info	[Changelog]   - Added Enum KnownResourceAssociationAccessMode
info	[Changelog]   - Added Enum KnownTlsVersion
info	[Changelog]   - Enum KnownPublicNetworkAccessFlag has a new value SecuredByPerimeter
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter skip
info	[Changelog]   - Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter skip
info	[Changelog]   - Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter skip
info	[Changelog]   - Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter top

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from d34308fae5d3b21d05583315567a3be9478bd3dd. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️eventhub [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from d34308fae5d3b21d05583315567a3be9478bd3dd. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.EventHub [View full logs] [Preview SDK Changes]
- Az.EventHub.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-03-14T07:08:08Z

Generated ApiView

Language	Package Name	ApiView Link
swagger	Microsoft.EventHub	https://apiview.dev/Assemblies/Review/6116b198e1af470a8f0ecd02aa7b486c
Go	sdk/resourcemanager/eventhub/armeventhub	https://apiview.dev/Assemblies/Review/893dd8a7569241529759dda2f9f2c96c
Java	azure-resourcemanager-eventhubs-generated	https://apiview.dev/Assemblies/Review/9b43acf5456b4b6083b6491c7e489bbd
.Net	Azure.ResourceManager.EventHubs	There is no API change compared with the previous version
JavaScript	@azure/arm-eventhub	https://apiview.dev/Assemblies/Review/62e7f5c0be604eb1885c2ac91e43c6a0

openapi-workflow-bot · 2023-03-14T07:16:02Z

Hi @damodaravadhani, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

ArcturusZhang · 2023-03-14T07:17:51Z

Hi @damodaravadhani could you fix the failed checks?
Please refer to this comment and the details on those pipelines for guidance.

damodaravadhani · 2023-03-15T13:57:15Z

@ArcturusZhang, according to https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers, we have provided for an identifier in format "/properties/subnet/id". But LintDiff says this is invalid, can you help figure out what might be wrong with this format ? Thanks in advance.

damodaravadhani · 2023-03-20T05:44:57Z

@ArcturusZhang , any help here would be appreciated ? Thanks !

ghost · 2023-04-09T16:03:35Z

Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2023-04-24T05:02:50Z

Hi, @damodaravadhani. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

adding appropriate identifiers

989ce52

damodaravadhani requested review from v-Ajnava and dsouzaarun as code owners March 14, 2023 07:08

openapi-assignment-bot bot assigned ArcturusZhang Mar 14, 2023

ghost added the Event Hubs label Mar 14, 2023

azure-sdk mentioned this pull request Mar 14, 2023

[AutoPR sdk/resourcemanager/eventhub/armeventhub] [EventHubs]: Adding appropriate identifiers to array properties azure-sdk/azure-sdk-for-go#4811

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Mar 14, 2023

AzureRestAPISpecReview added CI-FixRequiredOnFailure resource-manager labels Mar 14, 2023

ArcturusZhang approved these changes Mar 14, 2023

View reviewed changes

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Mar 14, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Mar 14, 2023

azure-sdk mentioned this pull request Mar 14, 2023

[AutoPR Azure.ResourceManager.EventHubs] [EventHubs]: Adding appropriate identifiers to array properties azure-sdk/azure-sdk-for-net#2985

Closed

konrad-jamrozik mentioned this pull request Mar 28, 2023

LintDiff support request by Dapeng Zhang: id validation failure Azure/azure-sdk-tools#5799

Closed

schaudhari6254888 mentioned this pull request Mar 29, 2023

Feature-request for inner property identifier Azure/aaz-dev-tools#223

Open

ghost added the no-recent-activity label Apr 9, 2023

ghost closed this Apr 24, 2023

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EventHubs]: Adding appropriate identifiers to array properties #23066

[EventHubs]: Adding appropriate identifiers to array properties #23066

damodaravadhani commented Mar 14, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-workflow-bot bot commented Mar 14, 2023

openapi-pipeline-app bot commented Mar 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 14, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Mar 14, 2023 •

edited

Loading

openapi-workflow-bot bot commented Mar 14, 2023

ArcturusZhang commented Mar 14, 2023

damodaravadhani commented Mar 15, 2023

damodaravadhani commented Mar 20, 2023

ghost commented Apr 9, 2023

ghost commented Apr 24, 2023

[EventHubs]: Adding appropriate identifiers to array properties #23066

[EventHubs]: Adding appropriate identifiers to array properties #23066

Conversation

damodaravadhani commented Mar 14, 2023 • edited by openapi-workflow-bot bot Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 14, 2023

openapi-pipeline-app bot commented Mar 14, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 14, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Mar 14, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Mar 14, 2023

ArcturusZhang commented Mar 14, 2023

damodaravadhani commented Mar 15, 2023

damodaravadhani commented Mar 20, 2023

ghost commented Apr 9, 2023

ghost commented Apr 24, 2023

damodaravadhani commented Mar 14, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Mar 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 14, 2023 •

edited

Loading