Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Devices to add version preview/2023-03-01-preview #22648

Conversation

WendyCaiMS
Copy link
Contributor

@WendyCaiMS WendyCaiMS commented Feb 15, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    04/28/2023
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    04/28/2023
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @WendyCaiMS Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 15, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 20 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    iotdps.json 2023-03-01-preview(b8b3cf0) 2022-12-12(main)
    iotdps.json 2023-03-01-preview(b8b3cf0) 2020-09-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ArmIdentity' removed or renamed?
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L1624:3
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1607:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EncryptionPropertiesDescription' removed or renamed?
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L1624:3
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1607:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EncryptionKeyIdentity' removed or renamed?
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L1624:3
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1607:3
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L189:13
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L189:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L1809:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1776:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v5/managedidentity.json#L69:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1945:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v5/managedidentity.json#L13:7
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1948:11
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L1633:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1616:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L2310:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L2345:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/managedidentity.json#L54:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1931:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/managedidentity.json#L60:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1936:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/managedidentity.json#L22:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1958:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v5/managedidentity.json#L28:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1963:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'integer' than the previous one 'string'.
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L2310:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L2345:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L1739:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1714:9
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'certificate' renamed or removed?
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L1687:7
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1656:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'encryption' renamed or removed?
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L1827:7
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1794:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identityType' renamed or removed?
    New: common-types/resource-management/v5/managedidentity.json#L53:7
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1930:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'type' that was not found in the old version.
    New: common-types/resource-management/v5/managedidentity.json#L53:7
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1930:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'type' that was not found in the old version.
    New: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L1809:9
    Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1776:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 1 Errors, 0 Warnings failed [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-03 package-preview-2023-03(b8b3cf0) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L519
    RPC-Patch-V1-11


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Devices/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L60
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L64
    ResourceNameRestriction The resource name parameter 'provisioningServiceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L76
    ResourceNameRestriction The resource name parameter 'certificateName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L76
    ParametersOrder The parameters:certificateName,resourceGroupName,provisioningServiceName should be kept in the same order as they present in the path.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L77
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L135
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L208
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L349
    ResourceNameRestriction The resource name parameter 'provisioningServiceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L358
    ParametersOrder The parameters:provisioningServiceName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L359
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L400
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L414
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L474
    PatchSkuProperty The patch operation body parameter schema should contains property 'sku'.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L519
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L532
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L532
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L547
    ParametersOrder The parameters:provisioningServiceName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L547
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L587
    MissingXmsErrorResponse Response code 404 is defined without a x-ms-error-response.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L596
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L599
    ResourceNameRestriction The resource name parameter 'provisioningServiceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L608
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L653
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L690
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L740
    ResourceNameRestriction The resource name parameter 'provisioningServiceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L752
    ParametersOrder The parameters:operationId,resourceGroupName,provisioningServiceName should be kept in the same order as they present in the path.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L753
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L812
    ResourceNameRestriction The resource name parameter 'provisioningServiceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L821
    ParametersOrder The parameters:provisioningServiceName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Devices/preview/2023-03-01-preview/iotdps.json#L822
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.Devices' for api version '2023-03-01-preview'. The supported api-versions are '2015-08-15-preview,
    2016-02-03,
    2017-01-19,
    2017-07-01,
    2018-01-22,
    2018-04-01,
    2018-12-01-preview,
    2019-03-22-preview,
    2019-03-22,
    2019-07-01-preview,
    2019-11-04,
    2020-03-01,
    2020-04-01,
    2020-06-15,
    2020-07-10-preview,
    2020-08-01,
    2020-08-31-preview,
    2020-08-31,
    2021-02-01-preview,
    2021-03-03-preview,
    2021-03-31,
    2021-07-01-preview,
    2021-07-01,
    2021-07-02-preview,
    2021-07-02,
    2022-04-30-preview'."
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 15, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/deviceprovisioningservices/armdeviceprovisioningservices - 2.0.0-beta.1
    +	Type of `ErrorDetails.Code` has been changed from `*string` to `*int32`

    azure-sdk-for-js - @azure/arm-deviceprovisioningservices - 6.0.0-beta.1
    +	Type of parameter code of interface ErrorDetails is changed from string to number
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2c09a4b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.3
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.3>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.3` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-iothubprovisioningservices [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model IotDpsPropertiesDescription has a new parameter portal_operations_host_name
      info	[Changelog]   - Model ProvisioningServiceDescription has a new parameter identity
      info	[Changelog]   - Model ProvisioningServiceDescription has a new parameter resourcegroup
      info	[Changelog]   - Model ProvisioningServiceDescription has a new parameter subscriptionid
      info	[Changelog]   - Model Resource has a new parameter resourcegroup
      info	[Changelog]   - Model Resource has a new parameter subscriptionid
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2c09a4b. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.
      cmderr	[generate.py] [ForkJoinPool-1-worker-7] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.
      cmderr	[generate.py] [ForkJoinPool-1-worker-1] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.
      cmderr	[generate.py] [ForkJoinPool-1-worker-5] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.
    • ️✔️azure-resourcemanager-deviceprovisioningservices [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2c09a4b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/deviceprovisioningservices/armdeviceprovisioningservices [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `ErrorDetails.Code` has been changed from `*string` to `*int32`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
      info	[Changelog] - New struct `ManagedServiceIdentity`
      info	[Changelog] - New struct `UserAssignedIdentity`
      info	[Changelog] - New field `PortalOperationsHostName` in struct `IotDpsPropertiesDescription`
      info	[Changelog] - New field `Identity` in struct `ProvisioningServiceDescription`
      info	[Changelog] - New field `Resourcegroup` in struct `ProvisioningServiceDescription`
      info	[Changelog] - New field `Subscriptionid` in struct `ProvisioningServiceDescription`
      info	[Changelog] - New field `Resourcegroup` in struct `Resource`
      info	[Changelog] - New field `Subscriptionid` in struct `Resource`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 12 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2c09a4b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-deviceprovisioningservices [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface ManagedServiceIdentity
      info	[Changelog]   - Added Interface UserAssignedIdentity
      info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
      info	[Changelog]   - Interface IotDpsPropertiesDescription has a new optional parameter portalOperationsHostName
      info	[Changelog]   - Interface ProvisioningServiceDescription has a new optional parameter identity
      info	[Changelog]   - Interface Resource has a new optional parameter resourcegroup
      info	[Changelog]   - Interface Resource has a new optional parameter subscriptionid
      info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Type of parameter code of interface ErrorDetails is changed from string to number
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2c09a4b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️deviceprovisioningservices [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 2c09a4b. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.deviceprovisioningservices.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 15, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/deviceprovisioningservices/armdeviceprovisioningservices https://apiview.dev/Assemblies/Review/591a48a2fec04431a5e2e4f79774b1ad
    .Net Azure.ResourceManager.DeviceProvisioningServices https://apiview.dev/Assemblies/Review/0ca71b42a5e74963a6cd8fc7d6143cc0
    Java azure-resourcemanager-deviceprovisioningservices https://apiview.dev/Assemblies/Review/14d7b3bdefee467aad62108c4cf2f991
    JavaScript @azure/arm-deviceprovisioningservices https://apiview.dev/Assemblies/Review/6fbdd435832743f7b4d49df237d8aef0

    @WendyCaiMS WendyCaiMS marked this pull request as ready for review February 16, 2023 22:14
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview CI-FixRequiredOnFailure WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 16, 2023
    @openapi-workflow-bot
    Copy link

    Hi @WendyCaiMS, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @zzvswxy
    Copy link
    Member

    zzvswxy commented Feb 17, 2023

    Hi @WendyCaiMS as there are LintDiff errors, can you fix it?
    And for ApiReadinessCheck error, is service release date confirmed? Or we can merge the PR after the service release? Thanks

    @WendyCaiMS WendyCaiMS removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 17, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 17, 2023
    @TimLovellSmith
    Copy link
    Member

    @WendyCaiMS you can open a breaking changes request and or contact Breaking Changes Reviewers to discuss changing sync to async.

    @TimLovellSmith – We see some services are not supporting PATCH for this functionality. Do you know if this is a recent change in the requirements for MSI onboarding for RPs?

    @anushprabhu No, I do not know. /cc @pilor

    @TimLovellSmith TimLovellSmith requested a review from pilor March 17, 2023 21:13
    @TimLovellSmith TimLovellSmith added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 17, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 17, 2023
    @pilor pilor removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 24, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 24, 2023
    @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 24, 2023
    @WendyCaiMS
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @WendyCaiMS
    Copy link
    Contributor Author

    Hi @zzvswxy, we got the ARM signoff and our service release date is targeted for 04/28/2023. What are next steps for the PR approval process?

    @zzvswxy
    Copy link
    Member

    zzvswxy commented Mar 28, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @zzvswxy
    Copy link
    Member

    zzvswxy commented Mar 28, 2023

    Hi @lirenhe can you help me for following the PR. Thanks

    @WendyCaiMS
    Copy link
    Contributor Author

    Hi @lirenhe can you help me for following the PR. Thanks

    Hi @zzvswxy, @lirenhe just wanted to follow up on this PR. Our target release date is 04/28/2023. What else do we need to get approval for this PR?

    @lirenhe lirenhe merged commit 2c09a4b into main Apr 3, 2023
    @lirenhe lirenhe deleted the WendyCaiMS-deviceprovisioningservices-Microsoft.Devices-2023-03-01-preview branch April 3, 2023 02:32
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    …review/2023-03-01-preview (Azure#22648)
    
    * Adds base for updating Microsoft.Devices from version stable/2022-12-12 to version 2023-03-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * added identity property to json and examples
    
    * add DPSUpdate example and update identity values
    
    * added identity to PATCH response
    
    * fixed typo
    
    * change to use common managedidentity type
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    10 participants