-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASE New API version 2023-01-01-preview Changes #22054
ASE New API version 2023-01-01-preview Changes #22054
Conversation
Hi, @sameerpatro Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.2)] | new version | base version |
---|---|---|
databoxedge.json | 2023-01-01-preview(b3e0ef6) | 2022-03-01(main) |
databoxedge.json | 2023-01-01-preview(b3e0ef6) | 2022-12-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Rule | Message |
---|---|
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'IoTAddon' removed or renamed? New: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L4621:3 Old: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L4159:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'IoTAddonProperties' removed or renamed? New: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L4621:3 Old: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L4159:3 |
1044 - XmsLongRunningOperationChanged |
The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L292:7 Old: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L292:7 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 50 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-2023-01-01-preview | package-2023-01-01-preview(b3e0ef6) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceImageOfferModel'. Consider using the plural form of 'MarketplaceImageOffer' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1371 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1382 |
||
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: OrderGet Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1556 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceImagePublisherModel'. Consider using the plural form of 'MarketplaceImagePublisher' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1720 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1731 |
||
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: OrderGet Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1757 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceImageOfferModel'. Consider using the plural form of 'MarketplaceImageOffer' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1770 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1781 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1789 |
||
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: OrderGet Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1815 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceImageSkuModel'. Consider using the plural form of 'MarketplaceImageSku' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1828 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1839 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1847 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1855 |
||
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: OrderGet Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1881 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceImageVersionModel'. Consider using the plural form of 'MarketplaceImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1894 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1905 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1913 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1921 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1929 |
||
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: OrderGet Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1955 |
||
The response of operation:'MarketplaceImageVersion_GetParticularImage' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1963 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceImageVersionModel'. Consider using the plural form of 'MarketplaceImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1968 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1976 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1983 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1990 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L1997 |
||
Parameter should have a description. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L2004 |
||
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: OrderGet Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L2029 |
||
OperationId should contain the verb: 'generatesastoken' in:'MarketplaceImageSasToken_GetSASToken'. Consider updating the operationId Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L2042 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L188 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L189 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L236 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L292 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L336 |
PatchSkuProperty |
The patch operation body parameter schema should contains property 'sku'. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L350 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L390 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L391 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L439 |
ParametersOrder |
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L440 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L492 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L493 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L541 |
ParametersOrder |
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L542 |
CreateOperationAsyncResponseValidation |
An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L593 |
ParametersOrder |
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L593 |
CreateOperationAsyncResponseValidation |
An async PUT operation must return 201. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L633 |
CreateOperationAsyncResponseValidation |
Only 201 is the supported response code for PUT async response. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L640 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L640 |
DeleteOperationAsyncResponseValidation |
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L657 |
ParametersOrder |
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L657 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L692 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L713 |
PostOperationAsyncResponseValidation |
An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L714 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L755 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L779 |
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'DeviceCapacityInfo' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L785 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L825 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L826 |
CreateOperationAsyncResponseValidation |
An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.DataBoxEdge/preview/2023-01-01-preview/databoxedge.json#L870 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌
ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
API Readiness check failed. Please make sure your service is deployed. |
"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.DataBoxEdge' for api version '2023-01-01-preview'. The supported api-versions are '2017-09-01, 2018-07-01, 2019-03-01, 2019-07-01, 2019-08-01, 2020-01-01, 2020-05-01-preview, 2020-06-01, 2020-07-01, 2020-07-01-preview, 2020-09-01, 2020-09-01-preview, 2020-12-01, 2021-02-01-preview, 2021-02-01, 2021-06-01, 2021-06-01-preview, 2022-03-01, 2022-04-01-preview'." |
️❌
~[Staging] ServiceAPIReadinessTest: 83 Errors, 0 Warnings failed [Detail]
Tag package-2023-01-01-preview; Prod region: Not deployed; Canary region: Deployed
Test run on region: eastus2euap; Operation coverage: total: 84, untested: 0, failed: 83, passed: 1
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
CLIENT_ERROR |
"statusCode: 400, errorCode: NoRegisteredProviderFound, errorMessage: No registered resource provider found for location 'eastus2euap' and API version '2023-01-01-preview' for type 'DataBoxEdgeDevices'. The supported api-versions are '2017-09-01, 2018-07-01, 2019-03-01, 2019-07-01, 2019-08-01, 2020-01-01, 2020-05-01-preview, 2020-06-01, 2020-07-01, 2020-07-01-preview, 2020-09-01, 2020-09-01-preview, 2020-12-01, 2021-02-01-preview, 2021-02-01, 2021-06-01, 2021-06-01-preview, 2022-03-01, 2022-04-01-preview'. The supported locations are 'eastus, westeurope, southeastasia, eastus2euap, centraluseuap'." |
CLIENT_ERROR |
"statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'DataBoxEdgeDevices' could not be found in the namespace 'Microsoft.DataBoxEdge' for api version '2023-01-01-preview'. The supported api-versions are '2017-09-01, 2018-07-01, 2019-03-01, 2019-07-01, 2019-08-01, 2020-01-01, 2020-05-01-preview, 2020-06-01, 2020-07-01, 2020-07-01-preview, 2020-09-01, 2020-09-01-preview, 2020-12-01, 2021-02-01-preview, 2021-02-01, 2021-06-01, 2021-06-01-preview, 2022-03-01, 2022-04-01-preview'." |
CLIENT_ERROR |
"statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'DataBoxEdgeDevices' could not be found in the namespace 'Microsoft.DataBoxEdge' for api version '2023-01-01-preview'. The supported api-versions are '2017-09-01, 2018-07-01, 2019-03-01, 2019-07-01, 2019-08-01, 2020-01-01, 2020-05-01-preview, 2020-06-01, 2020-07-01, 2020-07-01-preview, 2020-09-01, 2020-09-01-preview, 2020-12-01, 2021-02-01-preview, 2021-02-01, 2021-06-01, 2021-06-01-preview, 2022-03-01, 2022-04-01-preview'." |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBoxEdge/DataBoxEdgeDevices/devicenadh6j7c' under resource group 'apiTest-QMrSKS-22054' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
️️✔️
~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi, @sameerpatro your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
The breaking changes were part of previous review. Here is the breaking change approved task and the PR. Task: https://msazure.visualstudio.com/One/_workitems/edit/14008883 Swagger PR: #18529 |
Hi @sameerpatro, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi, @sameerpatro, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
@sameerpatro - It looks like the latest checked-in version of this spec is 2022-12-01-preview. Please make your base commit on files from that version, so we can see all changes to now. If some of the intermediate API versions were already reviewed/signed off by ARM, please provide links to those PRs: we don't want to re-review those changes. |
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
@sameerpatro, the PR contains breaking changes compared with the last stable version, please follow the below guide for review. Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki. |
I have created another PR with the base commit. Here is the PR: #22072. |
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.