-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Hub Geo DR - New API version 2023-01-01-preview #21994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2387ca3.
This reverts commit 2c77503.
…ies." This reverts commit caf5d9e.
…zaarun/azure-rest-api-specs into ardsouza/main/EH/2022-10-01
This reverts commit 2d60d5c.
/pr RequestMerge |
Swagger Generation Artifacts
|
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
definitions.json | 1.0(d92cb5e) | 1.0(main) |
Rule | Message |
---|---|
1036 - ConstraintChanged |
The new version has a different 'pattern' value than the previous one. New: resource-manager/common/v1/definitions.json#L149:5 Old: resource-manager/common/v1/definitions.json#L149:5 |
️🔄
Breaking Change(Cross-Version) inProgress [Detail]
️⌛
CredScan pending [Detail]
️⌛
LintDiff pending [Detail]
️🔄
Avocado inProgress [Detail]
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️⌛
TypeSpecAPIView pending [Detail]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⌛
PoliCheck pending [Detail]
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️🔄
SpellCheck inProgress [Detail]
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️⌛
PR Summary pending [Detail]
️⌛
Automated merging requirements met pending [Detail]
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
definitions.json | 1.0(d92cb5e) | 1.0(main) |
Rule | Message |
---|---|
1036 - ConstraintChanged |
The new version has a different 'pattern' value than the previous one. New: resource-manager/common/v1/definitions.json#L149:5 Old: resource-manager/common/v1/definitions.json#L149:5 |
️🔄
Breaking Change(Cross-Version) inProgress [Detail]
️⌛
CredScan pending [Detail]
️⌛
LintDiff pending [Detail]
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️⌛
TypeSpecAPIView pending [Detail]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⌛
PoliCheck pending [Detail]
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️🔄
SpellCheck inProgress [Detail]
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️⌛
PR Summary pending [Detail]
️⌛
Automated merging requirements met pending [Detail]
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
definitions.json | 1.0(d92cb5e) | 1.0(main) |
Rule | Message |
---|---|
1036 - ConstraintChanged |
The new version has a different 'pattern' value than the previous one. New: resource-manager/common/v1/definitions.json#L149:5 Old: resource-manager/common/v1/definitions.json#L149:5 |
️🔄
Breaking Change(Cross-Version) inProgress [Detail]
️⌛
CredScan pending [Detail]
️⌛
LintDiff pending [Detail]
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️🔄
TypeSpecAPIView inProgress [Detail]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⌛
PoliCheck pending [Detail]
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️🔄
SpellCheck inProgress [Detail]
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️⌛
PR Summary pending [Detail]
️⌛
Automated merging requirements met pending [Detail]
/pr RequestMerge |
rkmanda
approved these changes
Aug 11, 2023
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
pipelines are stuck |
/azp run |
Next Steps to Merge |
Azure Pipelines successfully started running 2 pipeline(s). |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Aug 16, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
Approved-SdkBreakingChange-Go
Approve the breaking change tracking for azure-sdk-for-go
Approved-SdkBreakingChange-JavaScript
Approved-SdkBreakingChange-Python
Approved-Suppression
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
CI-BreakingChange-Go
CI-BreakingChange-JavaScript
CI-MissingBaseCommit
DoNotMerge
<valid label in PR review process> use to hold merge after approval
Event Hubs
new-api-version
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
SuppressionReviewRequired
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.