[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-10-01 #21448

shesamian · 2022-11-07T08:44:15Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…w/2022-09-30-preview to version 2022-10-01

openapi-workflow-bot · 2022-11-07T08:44:17Z

Hi, @shesamian Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-11-07T08:44:21Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.2)]	new version	base version
registeredidentities.json	2022-10-01(cb2f819)	2022-09-10(main)
registeredidentities.json	2022-10-01(cb2f819)	2022-09-30-preview(main)
replicationusages.json	2022-10-01(cb2f819)	2022-09-10(main)
replicationusages.json	2022-10-01(cb2f819)	2022-09-30-preview(main)
vaults.json	2022-10-01(cb2f819)	2022-09-10(main)
vaults.json	2022-10-01(cb2f819)	2022-09-30-preview(main)
vaultusages.json	2022-10-01(cb2f819)	2022-09-10(main)
vaultusages.json	2022-10-01(cb2f819)	2022-09-30-preview(main)

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 2 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-10	package-2022-10(cb2f819)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2022-10-01/vaults.json#L944
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2022-10-01/vaults.json#L958

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/certificates/{certificateName}' Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L21
`❌` ResourceNameRestriction	The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L21
`❌` ResourceNameRestriction	The resource name parameter 'certificateName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L21
`❌` SubscriptionsAndResourceGroupCasing	The path segment Subscriptions should be subscriptions. Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L21
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L64
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/registeredIdentities/{identityName}' Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L80
`❌` ResourceNameRestriction	The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L80
`❌` ResourceNameRestriction	The resource name parameter 'identityName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L80
`❌` SubscriptionsAndResourceGroupCasing	The path segment Subscriptions should be subscriptions. Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L80
`❌` DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L108
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L108
`❌` DefinitionsPropertiesNamesCamelCase	Property name should be camel case. Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L243
`❌` NestedResourcesMustHaveListOperation	The nested resource 'VaultCertificateResponse' does not have list operation, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L300
`❌` XmsParameterLocation	The parameter 'SubscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L327
`❌` XmsParameterLocation	The parameter 'ApiVersion' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.RecoveryServices/stable/2022-10-01/registeredidentities.json#L350
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/replicationUsages' Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L21
`❌` ResourceNameRestriction	The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L21
`❌` SubscriptionsAndResourceGroupCasing	The path segment Subscriptions should be subscriptions. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L21
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L45
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L70
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L74
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L78
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L88
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L92
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L96
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L100
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L104
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L108
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L126
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-10-01/replicationusages.json#L130

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 31 Errors, 0 Warnings failed [Detail]

Tag package-2022-10; Prod region: Deployed

Test run on region: westcentralus; Operation coverage: total: 20, untested: 0, failed: 13, passed: 7

Service API Readiness Test failed. Check pipeline artifact for detail report.

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'locations/checkNameAvailability' could not be found in the namespace 'Microsoft.RecoveryServices' for api version '2022-10-01'. The supported api-versions are '2018-01-10'."
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: identityUrl"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: identityUrl"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: location"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: tags"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: identity"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: sku"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: location"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: tags"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: identity"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: sku"
`❌` CLIENT_ERROR	"statusCode: 412, errorCode: undefined, errorMessage: undefined"
`❌` INVALID_RESPONSE_BODY	"Body is required in response but not provided"
`❌` CLIENT_ERROR	"statusCode: 400, errorCode: undefined, errorMessage: undefined"
`❌` INVALID_RESPONSE_CODE	"The swagger file does not define '400' response code"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: ResourceNotFound, errorMessage: Could not perform the operation as VM no longer exists. Stop protecting virtual machine without deleting backup data. More details at http://go.microsoft.com/fwlink/?LinkId=808124 "
`❌` INVALID_RESPONSE_CODE	"The swagger file does not define '404' response code"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: monitoringSummary"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: jobsSummary"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: protectedItemsSummary"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: storageAccountsCountSummary"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: protectedItemCount"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: registeredServersCount"
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: recoveryPlanCount"
`❌` CLIENT_ERROR	"statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.RecoveryServices/locations/capabilities/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials."
`❌` SERVER_ERROR	"statusCode: 500, errorCode: CloudInternalError, errorMessage: Microsoft Azure Backup encountered an internal error. Wait for a few minutes and then try the operation again. If the issue persists, please contact Microsoft support."
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: innerError"
`❌` SERVER_ERROR	"statusCode: 500, errorCode: CloudInternalError, errorMessage: Microsoft Azure Backup encountered an internal error. Wait for a few minutes and then try the operation again. If the issue persists, please contact Microsoft support."
`❌` OBJECT_ADDITIONAL_PROPERTIES	"Additional properties not allowed: innerError"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: undefined, errorMessage: undefined"

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-11-07T08:44:22Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 59dd84d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.RecoveryServices [View full logs] [Release SDK Changes]
- Azure.ResourceManager.RecoveryServices.1.0.0-alpha.20221124.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 59dd84d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.1.2` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-recoveryservices [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation RecoveryServicesOperations.capabilities
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter group_ids
info	[Changelog]   - Model VaultProperties has a new parameter public_network_access
info	[Changelog]   - Model VaultProperties has a new parameter security_settings

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 59dd84d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-recoveryservices [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 59dd84d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/recoveryservices/armrecoveryservices [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Struct `CloudError` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `CrossRegionRestoreDisabled`
info	[Changelog] - New const `CrossRegionRestoreEnabled`
info	[Changelog] - New const `ImmutabilityStateDisabled`
info	[Changelog] - New const `ImmutabilityStateLocked`
info	[Changelog] - New const `ImmutabilityStateUnlocked`
info	[Changelog] - New const `PublicNetworkAccessDisabled`
info	[Changelog] - New const `PublicNetworkAccessEnabled`
info	[Changelog] - New const `StandardTierStorageRedundancyGeoRedundant`
info	[Changelog] - New const `StandardTierStorageRedundancyLocallyRedundant`
info	[Changelog] - New const `StandardTierStorageRedundancyZoneRedundant`
info	[Changelog] - New const `VaultSubResourceTypeAzureBackup`
info	[Changelog] - New const `VaultSubResourceTypeAzureBackupSecondary`
info	[Changelog] - New const `VaultSubResourceTypeAzureSiteRecovery`
info	[Changelog] - New type alias `CrossRegionRestore`
info	[Changelog] - New type alias `ImmutabilityState`
info	[Changelog] - New type alias `PublicNetworkAccess`
info	[Changelog] - New type alias `StandardTierStorageRedundancy`
info	[Changelog] - New type alias `VaultSubResourceType`
info	[Changelog] - New function `*Client.Capabilities(context.Context, string, ResourceCapabilities, *ClientCapabilitiesOptions) (ClientCapabilitiesResponse, error)`
info	[Changelog] - New function `PossibleCrossRegionRestoreValues() []CrossRegionRestore`
info	[Changelog] - New function `PossibleImmutabilityStateValues() []ImmutabilityState`
info	[Changelog] - New function `PossiblePublicNetworkAccessValues() []PublicNetworkAccess`
info	[Changelog] - New function `PossibleStandardTierStorageRedundancyValues() []StandardTierStorageRedundancy`
info	[Changelog] - New function `PossibleVaultSubResourceTypeValues() []VaultSubResourceType`
info	[Changelog] - New struct `CapabilitiesProperties`
info	[Changelog] - New struct `CapabilitiesResponse`
info	[Changelog] - New struct `CapabilitiesResponseProperties`
info	[Changelog] - New struct `ClientCapabilitiesOptions`
info	[Changelog] - New struct `ClientCapabilitiesResponse`
info	[Changelog] - New struct `DNSZone`
info	[Changelog] - New struct `DNSZoneResponse`
info	[Changelog] - New struct `ImmutabilitySettings`
info	[Changelog] - New struct `ResourceCapabilities`
info	[Changelog] - New struct `ResourceCapabilitiesBase`
info	[Changelog] - New struct `SecuritySettings`
info	[Changelog] - New struct `VaultPropertiesRedundancySettings`
info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `AADAudience` in struct `ResourceCertificateAndAADDetails`
info	[Changelog] - New field `PublicNetworkAccess` in struct `VaultProperties`
info	[Changelog] - New field `RedundancySettings` in struct `VaultProperties`
info	[Changelog] - New field `SecuritySettings` in struct `VaultProperties`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 51 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 59dd84d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-recoveryservices [View full logs] [Release SDK Changes]

azure-arm-recoveryservices-5.2.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation RecoveryServices.capabilities
info	[Changelog]   - Added Interface CapabilitiesProperties
info	[Changelog]   - Added Interface CapabilitiesResponse
info	[Changelog]   - Added Interface CapabilitiesResponseProperties
info	[Changelog]   - Added Interface DNSZone
info	[Changelog]   - Added Interface DNSZoneResponse
info	[Changelog]   - Added Interface ImmutabilitySettings
info	[Changelog]   - Added Interface RecoveryServicesCapabilitiesOptionalParams
info	[Changelog]   - Added Interface ResourceCapabilities
info	[Changelog]   - Added Interface ResourceCapabilitiesBase
info	[Changelog]   - Added Interface SecuritySettings
info	[Changelog]   - Added Type Alias ImmutabilityState
info	[Changelog]   - Added Type Alias PublicNetworkAccess
info	[Changelog]   - Added Type Alias RecoveryServicesCapabilitiesResponse
info	[Changelog]   - Added Type Alias VaultSubResourceType
info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter groupIds
info	[Changelog]   - Interface VaultProperties has a new optional parameter publicNetworkAccess
info	[Changelog]   - Interface VaultProperties has a new optional parameter securitySettings
info	[Changelog]   - Added Enum KnownImmutabilityState
info	[Changelog]   - Added Enum KnownPublicNetworkAccess
info	[Changelog]   - Added Enum KnownVaultSubResourceType

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 59dd84d. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️recoveryservices [View full logs] [Release Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 59dd84d. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.RecoveryServices [View full logs] [Release SDK Changes]
- Az.RecoveryServices.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-11-07T08:44:23Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/recoveryservices/armrecoveryservices	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Python	track2_azure-mgmt-recoveryservices	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-recoveryservices	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net	Azure.ResourceManager.RecoveryServices	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-recoveryservices	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

rkmanda · 2022-11-12T01:59:23Z

...overyservices/resource-manager/Microsoft.RecoveryServices/stable/2022-10-01/vaultusages.json

+  "swagger": "2.0",
+  "info": {
+    "version": "2022-10-01",
+    "title": "RecoveryServicesClient",


Is not clear what new changes are being introduced with this API version.

The first commit needs to be the previous api version and the new changes should only be added in the subsequent commits. This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version . Please remove the "ARMChangesRequested" label once you have fixed this issue.

Hi @rkmanda, thank you so much for the review.

The first commit is indeed generated by the OpenAPI Hub.

There are no significant changes because it's just for complaint. The actual changes were done in recoveryservicessiterecovery PR: [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-10-01 #20998

This PR along with recoveryservicesbackup are just for compliance.

3 PRs: https://github.com/Azure/azure-rest-api-specs/pulls/shesamian

openapi-workflow-bot · 2022-11-12T01:59:48Z

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

viananth · 2022-11-15T00:28:12Z

/azp run

azure-pipelines · 2022-11-15T00:28:21Z

Azure Pipelines successfully started running 1 pipeline(s).

shesamian · 2022-11-15T08:37:51Z

/azp run

azure-pipelines · 2022-11-15T08:37:56Z

Commenter does not have sufficient privileges for PR 21448 in repo Azure/azure-rest-api-specs

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2022-10-01/vaults.json

TimLovellSmith

TimLovellSmith · 2022-11-22T17:42:59Z

I literally can't see any changes for ARM to approve at this point, so I guess this is approved.

shesamian · 2022-11-23T01:52:21Z

/azp run

azure-pipelines · 2022-11-23T01:52:27Z

Commenter does not have sufficient privileges for PR 21448 in repo Azure/azure-rest-api-specs

viananth · 2022-11-23T05:19:12Z

/azp run

azure-pipelines · 2022-11-23T05:19:21Z

Azure Pipelines successfully started running 1 pipeline(s).

raych1 · 2022-11-24T00:56:48Z

Synced up with @shesamian offline, he created work item in backlog to investigate the API readiness test failures so that the production release won't be blocked.
https://msazure.visualstudio.com/One/_workitems/edit/16375051

…soft.RecoveryServices to add version stable/2022-10-01 (#2673) Create to sync Azure/azure-rest-api-specs#21448 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/recoveryservices?expand=1)

…version stable/2022-10-01 (Azure#21448) * Adds base for updating Microsoft.RecoveryServices from version preview/2022-09-30-preview to version 2022-10-01 * Updates readme * Updates API version in new specs and examples * Minor markdown linting issue * Modified the formatting * used common parameters

shesamian and others added 4 commits November 7, 2022 00:51

Adds base for updating Microsoft.RecoveryServices from version previe…

40572b5

…w/2022-09-30-preview to version 2022-10-01

Updates readme

d58c782

Updates API version in new specs and examples

5ee3c6a

Minor markdown linting issue

9473d89

openapi-assignment-bot bot assigned raych1 Nov 7, 2022

ghost added the RecoveryServices label Nov 7, 2022

azure-sdk mentioned this pull request Nov 7, 2022

[AutoPR sdk/resourcemanager/recoveryservices/armrecoveryservices] [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-10-01 azure-sdk/azure-sdk-for-go#3444

Closed

rkmanda reviewed Nov 12, 2022

View reviewed changes

rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 12, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 12, 2022

Modified the formatting

f9fa234

TimLovellSmith reviewed Nov 18, 2022

View reviewed changes

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2022-10-01/vaults.json Outdated Show resolved Hide resolved

TimLovellSmith added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 18, 2022

used common parameters

cb2f819

raych1 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 21, 2022

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 21, 2022

shesamian requested a review from TimLovellSmith November 21, 2022 23:18

TimLovellSmith approved these changes Nov 22, 2022

View reviewed changes

TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 22, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 22, 2022

raych1 approved these changes Nov 24, 2022

View reviewed changes

raych1 merged commit 59dd84d into Azure:main Nov 24, 2022

azure-sdk mentioned this pull request Nov 24, 2022

[ReleasePR sdk/resourcemanager/recoveryservices/armrecoveryservices] [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-06-01 Azure/azure-sdk-for-go#19185

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-10-01 #21448

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-10-01 #21448

shesamian commented Nov 7, 2022 •

edited

Loading

openapi-workflow-bot bot commented Nov 7, 2022

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading

rkmanda Nov 12, 2022

amir734jj Nov 14, 2022

openapi-workflow-bot bot commented Nov 12, 2022

viananth commented Nov 15, 2022

azure-pipelines bot commented Nov 15, 2022

shesamian commented Nov 15, 2022

azure-pipelines bot commented Nov 15, 2022

TimLovellSmith left a comment

TimLovellSmith commented Nov 22, 2022

shesamian commented Nov 23, 2022

azure-pipelines bot commented Nov 23, 2022

viananth commented Nov 23, 2022

azure-pipelines bot commented Nov 23, 2022

raych1 commented Nov 24, 2022

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-10-01 #21448

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-10-01 #21448

Conversation

shesamian commented Nov 7, 2022 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Nov 7, 2022

openapi-pipeline-app bot commented Nov 7, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 7, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 7, 2022 • edited Loading

Generated ApiView

rkmanda Nov 12, 2022

Choose a reason for hiding this comment

amir734jj Nov 14, 2022

Choose a reason for hiding this comment

openapi-workflow-bot bot commented Nov 12, 2022

viananth commented Nov 15, 2022

azure-pipelines bot commented Nov 15, 2022

shesamian commented Nov 15, 2022

azure-pipelines bot commented Nov 15, 2022

TimLovellSmith left a comment

Choose a reason for hiding this comment

TimLovellSmith commented Nov 22, 2022

shesamian commented Nov 23, 2022

azure-pipelines bot commented Nov 23, 2022

viananth commented Nov 23, 2022

azure-pipelines bot commented Nov 23, 2022

raych1 commented Nov 24, 2022

shesamian commented Nov 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading