-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ariflakhani/add plan is system extension property #21188
Merged
ruowan
merged 10 commits into
Azure:main
from
Arif-lakhani:ariflakhani/add-plan-isSystemExtension-property
Nov 12, 2022
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3f86011
Copied API version 2022-07-01 to 2022-11-01
6423be5
updating the API version to 2022-11-01
227b247
udpated plan info and isSystemExtension property
4d0790e
Add tags for packages
b1fd88a
Add currentVersion, deprecate installedVersion
nikkomiu 4a5c6c2
Merge branch 'ariflakhani/add-plan-isSystemExtension-property' of htt…
nikkomiu 2dabd45
Remove deprecated from installed version
nikkomiu a516063
Build error fixes
89038f5
Seperate Get extension with plan and add current version property to …
2debfda
Remove Installed Version
nikkomiu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
111 changes: 111 additions & 0 deletions
111
...manager/Microsoft.KubernetesConfiguration/stable/2022-11-01/examples/CreateExtension.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,111 @@ | ||
{ | ||
"parameters": { | ||
"subscriptionId": "subId1", | ||
"resourceGroupName": "rg1", | ||
"clusterRp": "Microsoft.Kubernetes", | ||
"clusterResourceName": "connectedClusters", | ||
"extensionName": "ClusterMonitor", | ||
"api-version": "2022-11-01", | ||
"clusterName": "clusterName1", | ||
"extension": { | ||
"properties": { | ||
"extensionType": "azuremonitor-containers", | ||
"autoUpgradeMinorVersion": true, | ||
"releaseTrain": "Preview", | ||
"scope": { | ||
"cluster": { | ||
"releaseNamespace": "kube-system" | ||
} | ||
}, | ||
"configurationSettings": { | ||
"omsagent.secret.wsid": "a38cef99-5a89-52ed-b6db-22095c23664b", | ||
"omsagent.env.clusterName": "clusterName1" | ||
}, | ||
"configurationProtectedSettings": { | ||
"omsagent.secret.key": "secretKeyValue01" | ||
} | ||
} | ||
} | ||
}, | ||
"responses": { | ||
"201": { | ||
"headers": { | ||
"Operation-Location": "/subscriptions/subId1/resourceGroups/rg1/providers/Microsoft.Kubernetes/connectedClusters/clusterName1/providers/Microsoft.KubernetesConfiguration/extensions/ClusterMonitor/operations/{operationId}", | ||
"x-ms-async-operation-timeout": "PT48H", | ||
"Azure-AsyncOperation": "http://management.azure.com/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Kubernetes/ConnectedClusters/clusterName1/providers/Microsoft.KubernetesConfiguration/extensions/ClusterMonitor/operations/operationId?api-version=2022-11-01" | ||
}, | ||
"description": "Details of the Kubernetes Extension's current status.", | ||
"body": { | ||
"id": "/subscriptions/subId1/resourceGroups/rg1/providers/Microsoft.Kubernetes/connectedClusters/clusterName1/providers/Microsoft.KubernetesConfiguration/extensions/ClusterMonitor", | ||
"type": "Microsoft.KubernetesConfiguration/extensions", | ||
"name": "ClusterMonitor", | ||
"systemData": { | ||
"createdBy": "string", | ||
"createdByType": "Application", | ||
"createdAt": "2021-09-08T05:10:57.027Z", | ||
"lastModifiedBy": "string", | ||
"lastModifiedByType": "Application", | ||
"lastModifiedAt": "2021-09-08T05:10:57.027Z" | ||
}, | ||
"properties": { | ||
"extensionType": "azuremonitor-containers", | ||
"autoUpgradeMinorVersion": false, | ||
"releaseTrain": "Preview", | ||
"version": "0.1.4", | ||
"scope": { | ||
"cluster": { | ||
"releaseNamespace": "kube-system" | ||
} | ||
}, | ||
"configurationSettings": { | ||
"omsagent.secret.wsid": "a38cef99-5a89-52ed-b6db-22095c23664b", | ||
"omsagent.env.clusterName": "clusterName1" | ||
}, | ||
"provisioningState": "Creating", | ||
"installedVersion": null, | ||
"statuses": [], | ||
"isSystemExtension": false | ||
} | ||
} | ||
}, | ||
"200": { | ||
"headers": { | ||
"Operation-Location": "/subscriptions/subId1/resourceGroups/rg1/providers/Microsoft.Kubernetes/connectedClusters/clusterName1/providers/Microsoft.KubernetesConfiguration/extensions/ClusterMonitor/operations/{operationId}", | ||
"x-ms-async-operation-timeout": "PT48H" | ||
}, | ||
"description": "Details of the Kubernetes Extension's current status.", | ||
"body": { | ||
"id": "/subscriptions/subId1/resourceGroups/rg1/providers/Microsoft.Kubernetes/connectedClusters/clusterName1/providers/Microsoft.KubernetesConfiguration/extensions/ClusterMonitor", | ||
"type": "Microsoft.KubernetesConfiguration/extensions", | ||
"name": "ClusterMonitor", | ||
"systemData": { | ||
"createdBy": "string", | ||
"createdByType": "Application", | ||
"createdAt": "2021-09-08T05:10:57.027Z", | ||
"lastModifiedBy": "string", | ||
"lastModifiedByType": "Application", | ||
"lastModifiedAt": "2021-09-08T05:10:57.027Z" | ||
}, | ||
"properties": { | ||
"extensionType": "azuremonitor-containers", | ||
"autoUpgradeMinorVersion": false, | ||
"releaseTrain": "Preview", | ||
"version": "0.1.4", | ||
"scope": { | ||
"cluster": { | ||
"releaseNamespace": "kube-system" | ||
} | ||
}, | ||
"configurationSettings": { | ||
"omsagent.secret.wsid": "a38cef99-5a89-52ed-b6db-22095c23664b", | ||
"omsagent.env.clusterName": "clusterName1" | ||
}, | ||
"provisioningState": "Succeeded", | ||
"installedVersion": "0.1.4", | ||
"statuses": [], | ||
"isSystemExtension": false | ||
} | ||
} | ||
} | ||
} | ||
} |
104 changes: 104 additions & 0 deletions
104
...Microsoft.KubernetesConfiguration/stable/2022-11-01/examples/CreateExtensionWithPlan.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,104 @@ | ||
{ | ||
"parameters": { | ||
"subscriptionId": "subId1", | ||
"resourceGroupName": "rg1", | ||
"clusterRp": "Microsoft.Kubernetes", | ||
"clusterResourceName": "connectedClusters", | ||
"extensionName": "azureVote", | ||
"api-version": "2022-11-01", | ||
"clusterName": "clusterName1", | ||
"extension": { | ||
"properties": { | ||
"extensionType": "azure-vote", | ||
"autoUpgradeMinorVersion": true, | ||
"releaseTrain": "Preview" | ||
}, | ||
"plan": { | ||
"name": "azure-vote-standard", | ||
"publisher": "Microsoft", | ||
"product": "azure-vote-standard-offer-id" | ||
} | ||
} | ||
}, | ||
"responses": { | ||
"201": { | ||
"headers": { | ||
"Operation-Location": "/subscriptions/subId1/resourceGroups/rg1/providers/Microsoft.Kubernetes/connectedClusters/clusterName1/providers/Microsoft.KubernetesConfiguration/extensions/azureVote/operations/{operationId}", | ||
"x-ms-async-operation-timeout": "PT48H", | ||
"Azure-AsyncOperation": "http://management.azure.com/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Kubernetes/ConnectedClusters/clusterName1/providers/Microsoft.KubernetesConfiguration/extensions/azureVote/operations/operationId?api-version=2022-04-01-preview" | ||
}, | ||
"description": "Details of the Kubernetes Extension's current status.", | ||
"body": { | ||
"id": "/subscriptions/subId1/resourceGroups/rg1/providers/Microsoft.Kubernetes/connectedClusters/clusterName1/providers/Microsoft.KubernetesConfiguration/extensions/azureVote", | ||
"type": "Microsoft.KubernetesConfiguration/extensions", | ||
"name": "azureVote", | ||
"systemData": { | ||
"createdBy": "string", | ||
"createdByType": "Application", | ||
"createdAt": "2021-09-08T05:10:57.027Z", | ||
"lastModifiedBy": "string", | ||
"lastModifiedByType": "Application", | ||
"lastModifiedAt": "2021-09-08T05:10:57.027Z" | ||
}, | ||
"plan": { | ||
"name": "azure-vote-standard", | ||
"publisher": "Microsoft", | ||
"product": "azure-vote-standard-offer-id" | ||
}, | ||
"properties": { | ||
"extensionType": "azure-vote", | ||
"autoUpgradeMinorVersion": true, | ||
"releaseTrain": "Preview", | ||
"version": "0.1.4", | ||
"scope": { | ||
"cluster": { | ||
"releaseNamespace": "kube-system" | ||
} | ||
}, | ||
"provisioningState": "Creating", | ||
"statuses": [], | ||
"isSystemExtension": false | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add currentVersion property as well. #Closed |
||
} | ||
}, | ||
"200": { | ||
"headers": { | ||
"Operation-Location": "/subscriptions/subId1/resourceGroups/rg1/providers/Microsoft.Kubernetes/connectedClusters/clusterName1/providers/Microsoft.KubernetesConfiguration/extensions/azureVote/operations/{operationId}", | ||
"x-ms-async-operation-timeout": "PT48H" | ||
}, | ||
"description": "Details of the Kubernetes Extension's current status.", | ||
"body": { | ||
"id": "/subscriptions/subId1/resourceGroups/rg1/providers/Microsoft.Kubernetes/connectedClusters/clusterName1/providers/Microsoft.KubernetesConfiguration/extensions/azureVote", | ||
"type": "Microsoft.KubernetesConfiguration/extensions", | ||
"name": "azureVote", | ||
"systemData": { | ||
"createdBy": "string", | ||
"createdByType": "Application", | ||
"createdAt": "2021-09-08T05:10:57.027Z", | ||
"lastModifiedBy": "string", | ||
"lastModifiedByType": "Application", | ||
"lastModifiedAt": "2021-09-08T05:10:57.027Z" | ||
}, | ||
"plan": { | ||
"name": "azure-vote-standard", | ||
"publisher": "Microsoft", | ||
"product": "azure-vote-standard-offer-id" | ||
}, | ||
"properties": { | ||
"extensionType": "azure-vote", | ||
"autoUpgradeMinorVersion": true, | ||
"releaseTrain": "Preview", | ||
"version": "0.1.4", | ||
"scope": { | ||
"cluster": { | ||
"releaseNamespace": "kube-system" | ||
} | ||
}, | ||
"provisioningState": "Creating", | ||
"statuses": [], | ||
"isSystemExtension": false | ||
} | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add currentVersion property here. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files are examples of how API response would look like for version 2022-11-01.