-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release chaos microsoft.chaos 2022 10 01 preview #20610
Release chaos microsoft.chaos 2022 10 01 preview #20610
Conversation
…1-preview to version 2022-10-01-preview
Hi, @brrusino Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.7)] | new version | base version |
---|---|---|
capabilities.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
capabilityTypes.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
experiments.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
operations.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
targetTypes.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
targets.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
capabilities.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
capabilityTypes.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
common.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
experiments.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
targetTypes.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
targets.json | 2022-10-01-preview(67f59ab) | 2022-07-01-preview(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-preview-2022-10 | package-preview-2022-10(67f59ab) | default(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
The operation 'Experiments_Cancel' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Chaos/preview/2022-10-01-preview/experiments.json#L262 |
|
The operation 'Experiments_Start' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Chaos/preview/2022-10-01-preview/experiments.json#L304 |
|
The child tracked resource, 'capabilities' with immediate parent 'target', must have a list by immediate parent operation. Location: preview/2022-10-01-preview/types/capabilities.json#L9 |
|
The child tracked resource, 'statuses' with immediate parent 'experiment', must have a list by immediate parent operation. Location: preview/2022-10-01-preview/types/experiments.json#L470 |
|
The child tracked resource, 'executionDetails' with immediate parent 'experiment', must have a list by immediate parent operation. Location: preview/2022-10-01-preview/types/experiments.json#L614 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: startOnCreation Location: preview/2022-10-01-preview/types/experiments.json#L98 |
|
The tracked resource, 'experiment', must have a list by resource group operation.(This rule does not apply for tenant level resources.) Location: preview/2022-10-01-preview/types/experiments.json#L47 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 61 Errors, 0 Warnings failed [Detail]
Tag package-preview-2022-10; Prod region: Not deployed; Canary region: Deployed
Test run on region: eastus2euap; Operation coverage: total: 24, untested: 0, failed: 23, passed: 1
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
CLIENT_ERROR |
"statusCode: 400, errorCode: NoRegisteredProviderFound, errorMessage: No registered resource provider found for location 'eastus2euap' and API version '2022-10-01-preview' for type 'experiments'. The supported api-versions are '2021-09-15-preview, 2022-07-01-preview'. The supported locations are 'westcentralus, eastus, westus, centralus, uksouth, westeurope, japaneast, northcentralus, eastus2, eastus2euap'." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 400" |
CLIENT_ERROR |
"statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'experiments' could not be found in the namespace 'Microsoft.Chaos' for api version '2022-10-01-preview'. The supported api-versions are '2021-09-15-preview, 2022-07-01-preview'." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'experiments' could not be found in the namespace 'Microsoft.Chaos' for api version '2022-10-01-preview'. The supported api-versions are '2021-09-15-preview, 2022-07-01-preview'." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
PATTERN |
"String does not match pattern ^[a-fA-F0-9]8-[a-fA-F0-9]4-[a-fA-F0-9]4-[a-fA-F0-9]4-[a-fA-F0-9]12$: executiondnw269w" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
PATTERN |
"String does not match pattern ^[a-fA-F0-9]8-[a-fA-F0-9]4-[a-fA-F0-9]4-[a-fA-F0-9]4-[a-fA-F0-9]12$: statusidq95zkr" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: InvalidResourceNamespace, errorMessage: The resource namespace 'parentprovn2m7c4' is invalid." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
PATTERN |
"String does not match pattern ^[a-zA-Z0-9]+\.[a-zA-Z0-9]+$: parentprovn2m7c4" |
CLIENT_ERROR |
"statusCode: 404, errorCode: InvalidResourceNamespace, errorMessage: The resource namespace 'parentprovn2m7c4' is invalid." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
PATTERN |
"String does not match pattern ^[a-zA-Z0-9]+\.[a-zA-Z0-9]+$: parentprovn2m7c4" |
CLIENT_ERROR |
"statusCode: 404, errorCode: InvalidResourceNamespace, errorMessage: The resource namespace 'parentprovn2m7c4' is invalid." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
️⚠️
~[Staging] TrafficValidation: 1 Warnings warning [Detail]
restlerResult: Request coverage (successful / total): 0 / 24 Attempted requests: 9 / 24
Traffic validation failed. Check pipeline artifact for restler output and detail report.
Rule | Message |
---|---|
"Starting task Test...\nUsing python: 'python3' (Python 3.10.5)\nRequest coverage (successful / total): 0 / 24\nAttempted requests: 9 / 24\nNo bugs were found.\nTask Test succeeded.\nCollecting logs...\n" |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/67f59ab9c6ebc6d4a609e2b2d0acfb5f229239cc/specification/chaos/resource-manager/readme.md#tag-package-preview-2022-10">chaos/resource-manager/readme.md#package-preview-2022-10
Rule | Message |
---|---|
"readme":"chaos/resource-manager/readme.md", "tag":"package-preview-2022-10", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi, @brrusino your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Hi @brrusino, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Failing staging checks are expected - looking to get ARM api review done sooner than later. |
There will be another minor change to this PR - will add ARM review tag when completed. |
@lirenhe Yes, this can now be shared with the ARM team for review. |
...ion/chaos/resource-manager/Microsoft.Chaos/preview/2022-10-01-preview/types/experiments.json
Outdated
Show resolved
Hide resolved
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
@lirenhe What else is needed from us to complete this PR? I tried to restart the Service API Readiness test (our RP manifest has now been updated in Eastus2euap) but I don't seem to be able to. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
confirmed with @brrusino that the service is deployed to prod, and will complete rolloutting to all regions tomorrow. |
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.