Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release chaos microsoft.chaos 2022 10 01 preview #20610

Merged

Conversation

brrusino
Copy link
Member

@brrusino brrusino commented Sep 6, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @brrusino Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 6, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.9.7)] new version base version
    capabilities.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    capabilityTypes.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    experiments.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    operations.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    targetTypes.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    targets.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    capabilities.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    capabilityTypes.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    common.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    experiments.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    targetTypes.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    targets.json 2022-10-01-preview(67f59ab) 2022-07-01-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-preview-2022-10 package-preview-2022-10(67f59ab) default(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'Experiments_Cancel' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.Chaos/preview/2022-10-01-preview/experiments.json#L262
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'Experiments_Start' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.Chaos/preview/2022-10-01-preview/experiments.json#L304
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'capabilities' with immediate parent 'target', must have a list by immediate parent operation.
    Location: preview/2022-10-01-preview/types/capabilities.json#L9
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'statuses' with immediate parent 'experiment', must have a list by immediate parent operation.
    Location: preview/2022-10-01-preview/types/experiments.json#L470
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'executionDetails' with immediate parent 'experiment', must have a list by immediate parent operation.
    Location: preview/2022-10-01-preview/types/experiments.json#L614
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: startOnCreation
    Location: preview/2022-10-01-preview/types/experiments.json#L98
    ⚠️ R3027 - TrackedResourceListByResourceGroup The tracked resource, 'experiment', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
    Location: preview/2022-10-01-preview/types/experiments.json#L47
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 61 Errors, 0 Warnings failed [Detail]

    Tag package-preview-2022-10; Prod region: Not deployed; Canary region: Deployed

    Test run on region: eastus2euap; Operation coverage: total: 24, untested: 0, failed: 23, passed: 1

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR "statusCode: 400,
    errorCode: NoRegisteredProviderFound,
    errorMessage: No registered resource provider found for location 'eastus2euap' and API version '2022-10-01-preview' for type 'experiments'. The supported api-versions are '2021-09-15-preview,
    2022-07-01-preview'. The supported locations are 'westcentralus,
    eastus,
    westus,
    centralus,
    uksouth,
    westeurope,
    japaneast,
    northcentralus,
    eastus2,
    eastus2euap'."
    ASSERTION_ERROR "expected response code to be 2XX but found 400"
    CLIENT_ERROR "statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'experiments' could not be found in the namespace 'Microsoft.Chaos' for api version '2022-10-01-preview'. The supported api-versions are '2021-09-15-preview,
    2022-07-01-preview'."
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    CLIENT_ERROR "statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'experiments' could not be found in the namespace 'Microsoft.Chaos' for api version '2022-10-01-preview'. The supported api-versions are '2021-09-15-preview,
    2022-07-01-preview'."
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    PATTERN "String does not match pattern ^[a-fA-F0-9]8-[a-fA-F0-9]4-[a-fA-F0-9]4-[a-fA-F0-9]4-[a-fA-F0-9]12$: executiondnw269w"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    PATTERN "String does not match pattern ^[a-fA-F0-9]8-[a-fA-F0-9]4-[a-fA-F0-9]4-[a-fA-F0-9]4-[a-fA-F0-9]12$: statusidq95zkr"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Chaos/experiments/experimenti3qm9l' under resource group 'apiTest-gdxiFU-20610' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    CLIENT_ERROR "statusCode: 404,
    errorCode: InvalidResourceNamespace,
    errorMessage: The resource namespace 'parentprovn2m7c4' is invalid."
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    PATTERN "String does not match pattern ^[a-zA-Z0-9]+\.[a-zA-Z0-9]+$: parentprovn2m7c4"
    CLIENT_ERROR "statusCode: 404,
    errorCode: InvalidResourceNamespace,
    errorMessage: The resource namespace 'parentprovn2m7c4' is invalid."
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    PATTERN "String does not match pattern ^[a-zA-Z0-9]+\.[a-zA-Z0-9]+$: parentprovn2m7c4"
    CLIENT_ERROR "statusCode: 404,
    errorCode: InvalidResourceNamespace,
    errorMessage: The resource namespace 'parentprovn2m7c4' is invalid."
    ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ️⚠️~[Staging] TrafficValidation: 1 Warnings warning [Detail]

    restlerResult: Request coverage (successful / total): 0 / 24 Attempted requests: 9 / 24
    Traffic validation failed. Check pipeline artifact for restler output and detail report.

    Rule Message
    ⚠️ Traffic validation result. "Starting task Test...\nUsing python: 'python3' (Python 3.10.5)\nRequest coverage (successful / total): 0 / 24\nAttempted requests: 9 / 24\nNo bugs were found.\nTask Test succeeded.\nCollecting logs...\n"
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/67f59ab9c6ebc6d4a609e2b2d0acfb5f229239cc/specification/chaos/resource-manager/readme.md#tag-package-preview-2022-10">chaos/resource-manager/readme.md#package-preview-2022-10
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"chaos/resource-manager/readme.md",
    "tag":"package-preview-2022-10",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 6, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-go - sdk/resourcemanager/chaos/armchaos - Approved - 0.6.0
    +	Function `*ExperimentsClient.BeginCancel` has been removed
    +	Function `*ExperimentsClient.BeginCreateOrUpdate` has been removed
    +	Struct `ExperimentsClientBeginCancelOptions` has been removed
    +	Struct `ExperimentsClientBeginCreateOrUpdateOptions` has been removed

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5263f0b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.15.0 -> 8.19.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.19.2` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-chaos [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model Selector has a new parameter filter
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5263f0b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/chaos/armchaos [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*ExperimentsClient.BeginCreateOrUpdate` has been removed
      info	[Changelog] - Function `*ExperimentsClient.BeginCancel` has been removed
      info	[Changelog] - Struct `ExperimentsClientBeginCancelOptions` has been removed
      info	[Changelog] - Struct `ExperimentsClientBeginCreateOrUpdateOptions` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `FilterTypeSimple`
      info	[Changelog] - New type alias `FilterType`
      info	[Changelog] - New function `*ExperimentsClient.Cancel(context.Context, string, string, *ExperimentsClientCancelOptions) (ExperimentsClientCancelResponse, error)`
      info	[Changelog] - New function `*ExperimentsClient.CreateOrUpdate(context.Context, string, string, Experiment, *ExperimentsClientCreateOrUpdateOptions) (ExperimentsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*Filter.GetFilter() *Filter`
      info	[Changelog] - New function `*SimpleFilter.GetFilter() *Filter`
      info	[Changelog] - New function `PossibleFilterTypeValues() []FilterType`
      info	[Changelog] - New struct `CapabilityTypePropertiesRuntimeProperties`
      info	[Changelog] - New struct `ExperimentsClientCancelOptions`
      info	[Changelog] - New struct `ExperimentsClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `Filter`
      info	[Changelog] - New struct `SimpleFilter`
      info	[Changelog] - New struct `SimpleFilterParameters`
      info	[Changelog] - New field `Filter` in struct `Selector`
      info	[Changelog] - New field `Kind` in struct `CapabilityTypeProperties`
      info	[Changelog] - New field `RuntimeProperties` in struct `CapabilityTypeProperties`
      info	[Changelog]
      info	[Changelog] Total 6 breaking change(s), 22 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5263f0b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-chaos [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface Filter
      info	[Changelog]   - Added Interface SimpleFilter
      info	[Changelog]   - Added Interface SimpleFilterParameters
      info	[Changelog]   - Added Type Alias FilterType
      info	[Changelog]   - Added Type Alias FilterUnion
      info	[Changelog]   - Interface Selector has a new optional parameter filter
      info	[Changelog]   - Added Enum KnownFilterType
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5263f0b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5263f0b. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Chaos [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 6, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/chaos/armchaos Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-chaos Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-chaos Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-chaos Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 6, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @brrusino your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot
    Copy link

    Hi @brrusino, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @brrusino
    Copy link
    Member Author

    brrusino commented Sep 7, 2022

    Failing staging checks are expected - looking to get ARM api review done sooner than later.

    @brrusino brrusino removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 7, 2022
    @brrusino
    Copy link
    Member Author

    brrusino commented Sep 7, 2022

    There will be another minor change to this PR - will add ARM review tag when completed.

    @brrusino
    Copy link
    Member Author

    brrusino commented Sep 21, 2022

    @lirenhe Yes, this can now be shared with the ARM team for review.

    @brrusino brrusino added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 22, 2022
    @mentat9 mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 26, 2022
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 26, 2022
    @brrusino brrusino added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Sep 26, 2022
    @mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 27, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 27, 2022
    @brrusino
    Copy link
    Member Author

    @lirenhe What else is needed from us to complete this PR? I tried to restart the Service API Readiness test (our RP manifest has now been updated in Eastus2euap) but I don't seem to be able to.

    @chunyu3
    Copy link
    Member

    chunyu3 commented Sep 30, 2022

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @xiaoxuqi-ms
    Copy link
    Member

    xiaoxuqi-ms commented Sep 30, 2022

    Hi @jianyexi please help to review the suppression. @tadelesh could you help to take a look at the go breaking change.

    @xiaoxuqi-ms
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @chunyu3 chunyu3 added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Sep 30, 2022
    @chunyu3
    Copy link
    Member

    chunyu3 commented Sep 30, 2022

    confirmed with @brrusino that the service is deployed to prod, and will complete rolloutting to all regions tomorrow.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-FixRequiredOnFailure ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants