-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add overlay vpa swagger #19936
Merged
lirenhe
merged 3 commits into
dev-containerservice-Microsoft.ContainerService-2022-07-02-preview
from
alex-add-overlay-vpa-swagger
Jul 26, 2022
Merged
add overlay vpa swagger #19936
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -6712,6 +6712,9 @@ | |||||
"properties": { | ||||||
"keda": { | ||||||
"$ref": "#/definitions/ManagedClusterWorkloadAutoScalerProfileKeda" | ||||||
}, | ||||||
"verticalPodAutoscaler": { | ||||||
"$ref": "#/definitions/ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler" | ||||||
} | ||||||
} | ||||||
}, | ||||||
|
@@ -6727,6 +6730,78 @@ | |||||
"required": [ | ||||||
"enabled" | ||||||
] | ||||||
}, | ||||||
"ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler": { | ||||||
"type": "object", | ||||||
"properties": { | ||||||
"enabled": { | ||||||
"type": "boolean", | ||||||
"description": "Whether to enable VPA. Default value is false.", | ||||||
"default": false | ||||||
}, | ||||||
"controlledValues": { | ||||||
"type": "string", | ||||||
"enum": [ | ||||||
"RequestsAndLimits", | ||||||
"RequestsOnly" | ||||||
], | ||||||
"x-ms-enum": { | ||||||
"name": "ControlledValues", | ||||||
"modelAsString": true, | ||||||
"values": [ | ||||||
{ | ||||||
"value": "RequestsAndLimits", | ||||||
"description": "Autoscaler will control resource requests and limits." | ||||||
}, | ||||||
{ | ||||||
"value": "RequestsOnly", | ||||||
"description": "Autoscaler will control resource requests only." | ||||||
} | ||||||
] | ||||||
}, | ||||||
"default": "RequestsAndLimits", | ||||||
"description": "Controls which resource value autoscaler will change. Default value is RequestsAndLimits." | ||||||
}, | ||||||
"updateMode": { | ||||||
"type": "string", | ||||||
"enum": [ | ||||||
"Off", | ||||||
"Initial", | ||||||
"Recreate", | ||||||
"Auto" | ||||||
], | ||||||
"x-ms-enum": { | ||||||
"name": "UpdateMode", | ||||||
"modelAsString": true, | ||||||
"values": [ | ||||||
{ | ||||||
"value": "Off", | ||||||
"description": "Autoscaler never changes pod resources but provides recommendation." | ||||||
}, | ||||||
{ | ||||||
"value": "Initial", | ||||||
"description": "Autoscaler only assigns resources on pod creation and doesn't change them during the lifetime of the pod." | ||||||
}, | ||||||
{ | ||||||
"value": "Recreate", | ||||||
"description": "Autoscaler assigns resources on pod creation and update pod during the lifetime of the pod by deleting and recreating." | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the comment! Updated in the latest iteration. |
||||||
}, | ||||||
{ | ||||||
"value": "Auto", | ||||||
"description": "Autoscaler chooses the update mode. Autoscaler currently does the same as Recreate. In the future, it may take advantage of restart-free mechanisms once they are available." | ||||||
} | ||||||
] | ||||||
}, | ||||||
"default": "Off", | ||||||
"title": "The update mode of the autoscaler.", | ||||||
"description": "Each update mode level is a superset of the lower levels. Off<Initial<Recreate<=Auto. For example: if UpdateMode is Initial, it means VPA sets the recommended resources in the VerticalPodAutoscaler Custom Resource (from UpdateMode Off) and also assigns resources on pod creation (from Initial). The default value is Off." | ||||||
} | ||||||
}, | ||||||
"required": [ | ||||||
"enabled", | ||||||
"updateMode", | ||||||
"controlledValues" | ||||||
] | ||||||
} | ||||||
}, | ||||||
"parameters": { | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: should say: "but provides recommendations" OR "but provides a recommendation"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment! Updated in the latest iteration.