Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 #19844

Merged
merged 3 commits into from
Jul 21, 2022
Merged

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 #19844

merged 3 commits into from
Jul 21, 2022

Conversation

susolank
Copy link
Contributor

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your engagement record.

  • Link to engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

  • Design Document:
  • Previous Open API Doc:
  • Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

@openapi-workflow-bot
Copy link

Hi, @susolank Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 19, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.9.6)] new version base version
    keys.json 7.3-preview(004290c) 7.3-preview(main)
    keys.json 7.3(004290c) 7.3(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    compared tags (via openapi-validator v1.13.0) new version base version
    package-7.3 package-7.3(004290c) package-7.3(main)
    package-preview-7.3-preview package-preview-7.3-preview(004290c) package-preview-7.3-preview(main)
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/004290c29aacd3391e737524ed31150a6db6e5fa/specification/keyvault/data-plane/readme.md#tag-package-7.3">keyvault/data-plane/readme.md#package-7.3
      • "https://github.com/Azure/azure-rest-api-specs/blob/004290c29aacd3391e737524ed31150a6db6e5fa/specification/keyvault/data-plane/readme.md#tag-package-preview-7.3-preview">keyvault/data-plane/readme.md#package-preview-7.3-preview
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 19, 2022 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @susolank susolank marked this pull request as ready for review July 19, 2022 23:06
    @susolank susolank requested a review from a team as a code owner July 19, 2022 23:06
    @susolank susolank requested review from tg-msft and mikekistler and removed request for a team July 19, 2022 23:06
    mikekistler
    mikekistler approved these changes Jul 21, 2022
    View reviewed changes
    Copy link
    Member

    @mikekistler mikekistler left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good! 👍

    @lmazuel lmazuel merged commit 9ab027d into Azure:main Jul 21, 2022
    @susolank susolank deleted the dev-keyvault-Microsoft.KeyVault-7.3 branch July 21, 2022 22:13
    akning-ms pushed a commit that referenced this pull request Aug 1, 2022
    @grizzlytheodore @deyaaeldeen
    @FumingZhang @bingosummer @mattstam @zjpjack @orparnes @abatishchev @PatrickTseng @gigigoo0 @Wzb123456789 @AbhishekKrishna123 @ArcturusZhang @divyansh3131 @t-bzhan @cohen-uriel-ms @susolank @bexxx @arpit-gagneja @argagnej @yanjungao718 @mikekistler @heaths @weidongxu-microsoft @Alancere @j-zhong-ms @tfitzmac @neeerajaakula @darkoa-msft @roy-work @amitelran @kazrael2119 @gubalasu
    Compute update folder structure (#19723)
    2dcad6d 
    * update folder structure

* small errors and CI check

* [Language Text] Update swagger titles (#19835)

* [Language Text] Update swagger titles

* edits

* address feedback

* Review request for Microsoft.ContainerService to add version 2022-06-01 (#19848)

* Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01

* Updates readme

* Updates API version in new specs and examples

* update readmes (#19421)

* Add key management service profile of a managed cluster for version 2022-06-01 (#19529)

* Add NetworkPlugin none option to 2022-06-01 (#19510)

* Add NetworkPlugin none option to 2022-06-01

* improve description for none value

* Fix violated rule R4041 for 2022-06-01 managedCluster swagger (#19581)

* remove useless directive

* fix R4041

* GA AKS support for Dedicated Host Group (#19547)

* GA AKS support for Dedicated Host Group

* fit some format minor issue

* add newline in end of files

* Defender updates (#19665)

* Defender updates

* sample

* remove old description

Co-authored-by: Bin Xia <binxi@microsoft.com>
Co-authored-by: Matt Stam <mattstam@live.com>
Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com>
Co-authored-by: Or Parnes <orparnes@microsoft.com>

* Update resources.json (#19861)

* Pattts/predictive autoscale 20221001 (#19765)

* Rev Autoscale API from 2021-05-01-preview to 2022-10-01.

* Fix minor swagger issue. Default should be 'false'

* Fix swagger validation error

* Defining a new package 2022-10

* AutoscaleSettingResource now reference allOf 'resource' which is the actual autoscaleSetting resource definition

* Fix require property issue

* Run prettier against autoscale_API.json

* [Maps - Render & Spatial Services] add v2022-08-01 (#19520)

* copy old swagger to new folders

* set api version to 2022-08-01

* apply api changes

Co-authored-by: Gigi Grajo <gigigrajo@microsoft.com>

* update appconfiguration (#19330)

* update appconfiguration

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* [Hub Generated] Publish private branch 'main' (#19852)

* Add StorageMover specification for PubliC Preview

* SpellCheck fix

* Update custom-words

* Update specification/storagemover/resource-manager/readme.md

Co-authored-by: Abhishek Krishna <abkrish@microsoft.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>

* Merging Dynatrace swagger in stable folder (#19862)

* Committing base swagger version

* Removing preview tag from stable folder api version

* Changing version name in all the files

* Updating readme.go and readme.md files

* [CDN] Fix customDomains property type in Endpoint (#19788)

* [CDN] Fix customDomains property type in Endpoint

* Fix linter error

Co-authored-by: Bo Zhang <bzhan@microsoft.com>

* Adding Microsoft.Sql AdvancedThreatProtectionSettings APIs for MI on v5 tag for 2022-02-01-preview (#19866)

* update folders

* [Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 (#19844)

* Update description of exportable attribute and release_policy.data

* Remove submodule azure-reset-api-specs

* Fix description for exportable

Co-authored-by: Sunny Solanki <Sunny.Solanki@microsoft.com>

* Add latest StorageMover updates (#19876)

* Add StorageMover specification for PubliC Preview

* SpellCheck fix

* Update custom-words

* Update specification/storagemover/resource-manager/readme.md

* Add latest StorageMover updates

Co-authored-by: Abhishek Krishna <abkrish@microsoft.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>

* Update readme.python.md (#19899)

* Update readme.python.md

* Update readme.md

* Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review (#19878)

* Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review

* Add known words

* Removed static IP allocation only from examples (#19858)

* Removed static IP allocation

* Removed static only from examples

Co-authored-by: Arpit Gagneja <argagnej@microsoft.com>

* Update securityinsights readme.python (#19903)

* update securityinsights readme.python

* Update readme.python.md

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>

* fix lint errors in Synapse trigger.json (#19660)

* put json files into RP folders

* update readme

* Add CONTRIBUTING.md (#19257)

* Add CONTRIBUTING.md

* Apply suggestions from PR review

Co-authored-by: Heath Stewart <heaths@outlook.com>

* Apply suggestions from PR review

Co-authored-by: Weidong Xu <weidxu@microsoft.com>

* Regen toc for CONTRIBUTING.md

* Address PR review comments

* Address PR review comments

Co-authored-by: Heath Stewart <heaths@outlook.com>
Co-authored-by: Weidong Xu <weidxu@microsoft.com>

* fix devcenter readme.go.md config (#19906)

* fix readme.go.md config

* rename to SkuInfo

* add annotation for labservices (#19884)

* add to description of OS state (#19764)

* [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#19767)

* Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item

* Update managed hsm private endpoint connection item in mhsm spec for latest api version

* Address LRO_RESPONSE_HEADER violation for managed hsm

Long running operations that are annotated with x-ms-long-running-operation:true
must return location header or azure-AsyncOperation in response.
Added the missing location header for managed hsm update command as well as to the corresponding
examples.

* [Microsoft.DeviceUpdate] Adding first stable API version (#19846)

* Copied the most recent preview version into the first stable version

* Updated api version in new stable version, added the tag to readme.md

* Fixed typo

* Fixed the wrong path in readme.md

* Reverted VS Code automatic breaking change

* Fix broken link (#19688)

* add aadObjectId property to kustoPool (#19856)

Co-authored-by: Amit Elran <amelran@microsoft.com>

* Updata securityinsights readme.python (#19917)

* update securityinsights readme.python

* update readme.python

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>

* modify readme.typescripy.md for compute package (#19607)

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <v-ziweichen@microsoft.com>

* Dev gubalasu frontdoor microsoft.network 2021 06 01 (#19578)

* Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2021-06-01

* Updates readme

* Updates API version in new specs and examples

* update waf configs and examples from 2020-11-01

* Update api version in new specs and examples

* Migration api update

* Update readme

* Fix readme

* update readme

* Fix readme again

* Fix readme

* Fix readme

* update waf policy provisioning state

* Update securityinsights readme.python (#19923)

* update securityinsights readme.python

* update readme.python

* last modify

* Update readme.python.md

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>

* sync with changes made to master

* update folder structure

* small errors and CI check

* update folders

* put json files into RP folders

* update readme

* resolve capitalization and number misplacement accident

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Co-authored-by: Bin Xia <binxi@microsoft.com>
Co-authored-by: Matt Stam <mattstam@live.com>
Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com>
Co-authored-by: Or Parnes <orparnes@microsoft.com>
Co-authored-by: Alexander Batishchev <abatishchev@gmail.com>
Co-authored-by: PatrickTseng <pattts@microsoft.com>
Co-authored-by: gigi <52640944+gigigoo0@users.noreply.github.com>
Co-authored-by: Gigi Grajo <gigigrajo@microsoft.com>
Co-authored-by: zhenbiao wei <424401670@qq.com>
Co-authored-by: Abhishek Krishna <AbhishekKrishna123@users.noreply.github.com>
Co-authored-by: Abhishek Krishna <abkrish@microsoft.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>
Co-authored-by: Divyansh Agarwal <83802474+divyansh3131@users.noreply.github.com>
Co-authored-by: t-bzhan <61817681+t-bzhan@users.noreply.github.com>
Co-authored-by: Bo Zhang <bzhan@microsoft.com>
Co-authored-by: Uriel Cohen <urielc@microsoft.com>
Co-authored-by: susolank <73919400+susolank@users.noreply.github.com>
Co-authored-by: Sunny Solanki <Sunny.Solanki@microsoft.com>
Co-authored-by: Ralf Beckers <bexxx@users.noreply.github.com>
Co-authored-by: arpit-gagneja <gagneja.arpit@gmail.com>
Co-authored-by: Arpit Gagneja <argagnej@microsoft.com>
Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>
Co-authored-by: YanjunGao <85206987+yanjungao718@users.noreply.github.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Heath Stewart <heaths@outlook.com>
Co-authored-by: Weidong Xu <weidxu@microsoft.com>
Co-authored-by: Jiahui Peng <46921893+Alancere@users.noreply.github.com>
Co-authored-by: j-zhong-ms <107880703+j-zhong-ms@users.noreply.github.com>
Co-authored-by: Tom FitzMacken <tomfitz@microsoft.com>
Co-authored-by: neeerajaakula <81248992+neeerajaakula@users.noreply.github.com>
Co-authored-by: darkoa-msft <61987922+darkoa-msft@users.noreply.github.com>
Co-authored-by: Roy Wellington <53838718+roy-work@users.noreply.github.com>
Co-authored-by: Amit Elran <amitelran2110@gmail.com>
Co-authored-by: Amit Elran <amelran@microsoft.com>
Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <v-ziweichen@microsoft.com>
Co-authored-by: gubalasu <59630928+gubalasu@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jackrichins jackrichins jackrichins left review comments

    @dalzhao dalzhao dalzhao approved these changes

    @mikekistler mikekistler mikekistler approved these changes

    @tg-msft tg-msft Awaiting requested review from tg-msft tg-msft was automatically assigned from Azure/api-stewardship-board

    @jkapil jkapil Awaiting requested review from jkapil

    @herveyw-msft herveyw-msft Awaiting requested review from herveyw-msft

    Assignees

    @tjprescott tjprescott

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @susolank @jackrichins @dalzhao @mikekistler @lmazuel @tjprescott