[Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version stable/2022-07-01 #19384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stable/2022-03-01 to version 2022-07-01
|
Hi, @summerhasama Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
1 similar comment
|
Hi, @summerhasama Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: clientCertificateSendChain Location: Microsoft.KubernetesConfiguration/stable/2022-07-01/fluxconfiguration.json#L791 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: clientCertificateSendChain Location: Microsoft.KubernetesConfiguration/stable/2022-07-01/fluxconfiguration.json#L831 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: forceDelete Location: Microsoft.KubernetesConfiguration/stable/2022-07-01/extensions.json#L192 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: forceDelete Location: Microsoft.KubernetesConfiguration/stable/2022-07-01/fluxconfiguration.json#L264 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: insecure Location: Microsoft.KubernetesConfiguration/stable/2022-07-01/fluxconfiguration.json#L569 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: insecure Location: Microsoft.KubernetesConfiguration/stable/2022-07-01/fluxconfiguration.json#L615 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: prune Location: Microsoft.KubernetesConfiguration/stable/2022-07-01/fluxconfiguration.json#L905 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force Location: Microsoft.KubernetesConfiguration/stable/2022-07-01/fluxconfiguration.json#L910 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: prune Location: Microsoft.KubernetesConfiguration/stable/2022-07-01/fluxconfiguration.json#L954 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force Location: Microsoft.KubernetesConfiguration/stable/2022-07-01/fluxconfiguration.json#L959 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.KubernetesConfiguration' for api version '2022-07-01'. The supported api-versions are '2019-11-01-preview, 2020-07-01-preview, 2020-10-01-preview, 2021-03-01, 2021-05-01-preview, 2021-06-01-preview, 2021-09-01, 2021-11-01-preview, 2021-12-01-preview, 2022-01-01-preview, 2022-03-01'." |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 11 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:stable/2022-07-01/extensions.json compared with base:stable/2022-03-01/extensions.json
- current:stable/2022-07-01/extensions.json compared with base:preview/2022-04-02-preview/extensions.json
- current:stable/2022-07-01/fluxconfiguration.json compared with base:stable/2022-03-01/fluxconfiguration.json
- current:stable/2022-07-01/fluxconfiguration.json compared with base:preview/2022-01-01-preview/fluxconfiguration.json
- current:stable/2022-07-01/kubernetesconfiguration.json compared with base:stable/2022-03-01/kubernetesconfiguration.json
- current:stable/2022-07-01/kubernetesconfiguration.json compared with base:preview/2022-01-01-preview/kubernetesconfiguration.json
- current:stable/2022-07-01/operations.json compared with base:stable/2022-03-01/operations.json
- current:stable/2022-07-01/operations.json compared with base:preview/2022-01-01-preview/operations.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Jun 8, 2022
This was referenced Jun 8, 2022
|
Hi, @summerhasama your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
1 similar comment
|
Hi, @summerhasama your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
jonathan-innis
suggested changes
Jun 9, 2022
raosuhas
reviewed
Jun 10, 2022
...ration/resource-manager/Microsoft.KubernetesConfiguration/common/2022-07-01/definitions.json
Outdated
Show resolved
Hide resolved
raosuhas
reviewed
Jun 10, 2022
...uration/resource-manager/Microsoft.KubernetesConfiguration/stable/2022-07-01/extensions.json
Outdated
Show resolved
Hide resolved
|
Added a few comments. Please remove the "ARMChangesRequested" label when you want the API reviewer to look at this review again |
This was referenced Jun 15, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jun 15, 2022
…r Microsoft.KubernetesConfiguration to add version stable/2022-07-01 (#2423) Create to sync Azure/azure-rest-api-specs#19384 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/kubernetesconfiguration?expand=1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.