PublicNetworkAccess Swagger Change #19352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jiansong-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
1 similar comment
|
Hi, @jiansong-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The parameters:resourceGroupName,name,processId,instanceId should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L5522 |
|
The parameters:resourceGroupName,name,processId,instanceId should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L5580 |
|
The parameters:resourceGroupName,name,processId,instanceId should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L5637 |
|
The parameters:resourceGroupName,name,processId,instanceId should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L5697 |
|
The parameters:resourceGroupName,name,processId,baseAddress,instanceId should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L5760 |
|
The parameters:resourceGroupName,name,processId,instanceId should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L5827 |
|
The parameters:resourceGroupName,name,backupId,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L9182 |
|
The parameters:resourceGroupName,name,backupId,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L9236 |
|
The parameters:resourceGroupName,name,backupId,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L9293 |
|
The parameters:resourceGroupName,name,backupId,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L9358 |
|
The parameters:resourceGroupName,name,appSettingKey,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L10437 |
|
The parameters:resourceGroupName,name,connectionStringKey,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L10548 |
|
The parameters:resourceGroupName,name,snapshotId,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L11291 |
|
The parameters:resourceGroupName,name,snapshotId,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L11347 |
|
The parameters:resourceGroupName,name,webJobName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L11562 |
|
The parameters:resourceGroupName,name,webJobName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L11620 |
|
The parameters:resourceGroupName,name,webJobName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L11676 |
|
The parameters:resourceGroupName,name,webJobName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L11733 |
|
The parameters:resourceGroupName,name,id,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L11965 |
|
The parameters:resourceGroupName,name,id,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12019 |
|
The parameters:resourceGroupName,name,id,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12082 |
|
The parameters:resourceGroupName,name,id,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12138 |
|
The parameters:resourceGroupName,name,domainOwnershipIdentifierName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12304 |
|
The parameters:resourceGroupName,name,domainOwnershipIdentifierName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12358 |
|
The parameters:resourceGroupName,name,domainOwnershipIdentifierName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12421 |
|
The parameters:resourceGroupName,name,domainOwnershipIdentifierName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12475 |
|
The parameters:resourceGroupName,name,functionName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12808 |
|
The parameters:resourceGroupName,name,functionName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12866 |
|
The parameters:resourceGroupName,name,functionName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12930 |
|
The parameters:resourceGroupName,name,functionName,keyName,slot should be kept in the same order as they present in the path. Location: Microsoft.Web/stable/2022-03-01/WebApps.json#L12987 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.9.5)
- current:stable/2022-03-01/CommonDefinitions.json compared with base:stable/2021-03-01/CommonDefinitions.json
- current:stable/2022-03-01/StaticSites.json compared with base:stable/2021-03-01/StaticSites.json
- current:stable/2022-03-01/WebApps.json compared with base:stable/2021-03-01/WebApps.json
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=297198&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️✔️azure-sdk-for-go-track2 - armappservice - 2.0.0️✔️azure-sdk-for-js - @azure/arm-appservice - 13.0.0️✔️azure-sdk-for-go - web/mgmt/2021-03-01/web - v65.0.0️✔️azure-sdk-for-go - web/mgmt/2021-02-01/web - v65.0.0️✔️azure-sdk-for-go - web/mgmt/2021-01-15/web - v65.0.0️✔️azure-sdk-for-go - web/mgmt/2020-12-01/web - v65.0.0️✔️azure-sdk-for-go - web/mgmt/2020-09-01/web - v65.0.0️✔️azure-sdk-for-go - web/mgmt/2020-06-01/web - v65.0.0️✔️azure-sdk-for-go - web/mgmt/2019-08-01/web - v65.0.0️✔️azure-sdk-for-go - web/mgmt/2018-02-01/web - v65.0.0️✔️azure-sdk-for-go - web/mgmt/2016-09-01/web - v65.0.0️✔️azure-sdk-for-go - preview/web/mgmt/2015-08-01-preview/web - v65.0.0️❌ azure-sdk-for-net failed [Detail]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-6.0 command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/web/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] No usable version of the libssl was found cmderr [Autorest] FATAL: csharp/simplifier - FAILED cmderr [Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated. cmderr [Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated. error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest warn Skip package processing as generation is failed
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] config global `--global`, `--local` are deprecated. Use `--location=global` instead. warn No file changes detected after generation warn No package detected after generation
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". cmderr [generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation cmderr [generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. cmderr [generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". cmderr [generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation cmderr [generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
️✔️azure-resourcemanager-appservice-generated [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 12 items here, please refer to log for details.
️✔️web/mgmt/2021-03-01/web [View full logs] [Release SDK Changes]info [Changelog] - New function `AppsClient.GetAuthSettingsV2WithoutSecretsSlot(context.Context, string, string, string) (SiteAuthSettingsV2, error)` info [Changelog] - New function `AppsClient.GetOneDeployStatusSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `AppsClient.GetOneDeployStatusResponder(*http.Response) (SetObject, error)` info [Changelog] - New function `AppsClient.GetOneDeployStatusPreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `AppsClient.GetOneDeployStatus(context.Context, string, string) (SetObject, error)` info [Changelog] - New function `AppsClient.CreateOneDeployOperationPreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `AppsClient.GetAuthSettingsV2WithoutSecretsSlotResponder(*http.Response) (SiteAuthSettingsV2, error)` info [Changelog] - New function `AppsClient.GetAuthSettingsV2WithoutSecretsSlotPreparer(context.Context, string, string, string) (*http.Request, error)` info [Changelog] - New function `AppsClient.GetAuthSettingsV2WithoutSecretsSlotSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `AppsClient.CreateOneDeployOperationResponder(*http.Response) (SetObject, error)` info [Changelog] info [Changelog] Total 0 breaking change(s), 12 additive change(s).
- Only show 12 items here, please refer to log for details.
️✔️web/mgmt/2021-02-01/web [View full logs]info [Changelog] - New field `JwtClaimChecks` in struct `AzureActiveDirectoryValidation` info [Changelog] - New field `AllowedAudiences` in struct `AzureActiveDirectoryValidation` info [Changelog] - New field `DefaultAuthorizationPolicy` in struct `AzureActiveDirectoryValidation` info [Changelog] - New field `Registration` in struct `Twitter` info [Changelog] - New field `Enabled` in struct `Twitter` info [Changelog] - New field `AppID` in struct `AppRegistration` info [Changelog] - New field `AppSecretSettingName` in struct `AppRegistration` info [Changelog] - New field `Enabled` in struct `CustomOpenIDConnectProvider` info [Changelog] - New field `Registration` in struct `CustomOpenIDConnectProvider` info [Changelog] - New field `Login` in struct `CustomOpenIDConnectProvider` info [Changelog] info [Changelog] Total 88 breaking change(s), 23 additive change(s).
- Only show 12 items here, please refer to log for details.
️✔️web/mgmt/2021-01-15/web [View full logs]info [Changelog] - New field `GitHub` in struct `IdentityProviders` info [Changelog] - New field `Google` in struct `IdentityProviders` info [Changelog] - New field `LegacyMicrosoftAccount` in struct `IdentityProviders` info [Changelog] - New field `AzureStaticWebApps` in struct `IdentityProviders` info [Changelog] - New field `CustomOpenIDConnectProviders` in struct `IdentityProviders` info [Changelog] - New field `Facebook` in struct `IdentityProviders` info [Changelog] - New field `Twitter` in struct `IdentityProviders` info [Changelog] - New field `Apple` in struct `IdentityProviders` info [Changelog] - New field `ConsumerSecretSettingName` in struct `TwitterRegistration` info [Changelog] - New field `ConsumerKey` in struct `TwitterRegistration` info [Changelog] info [Changelog] Total 190 breaking change(s), 37 additive change(s).
- Only show 12 items here, please refer to log for details.
️✔️web/mgmt/2020-12-01/web [View full logs]info [Changelog] - New field `CustomOpenIDConnectProviders` in struct `IdentityProviders` info [Changelog] - New field `GitHub` in struct `IdentityProviders` info [Changelog] - New field `Twitter` in struct `IdentityProviders` info [Changelog] - New field `Google` in struct `IdentityProviders` info [Changelog] - New field `LegacyMicrosoftAccount` in struct `IdentityProviders` info [Changelog] - New field `AzureStaticWebApps` in struct `IdentityProviders` info [Changelog] - New field `Enabled` in struct `TokenStore` info [Changelog] - New field `TokenRefreshExtensionHours` in struct `TokenStore` info [Changelog] - New field `FileSystem` in struct `TokenStore` info [Changelog] - New field `AzureBlobStorage` in struct `TokenStore` info [Changelog] info [Changelog] Total 190 breaking change(s), 37 additive change(s).
- Only show 12 items here, please refer to log for details.
️✔️web/mgmt/2020-09-01/web [View full logs]info [Changelog] - Function `BaseClient.GenerateGithubAccessTokenForAppserviceCLIAsyncSender` has been removed info [Changelog] - Function `BaseClient.GenerateGithubAccessTokenForAppserviceCLIAsync` has been removed info [Changelog] - Function `BaseClient.GenerateGithubAccessTokenForAppserviceCLIAsyncPreparer` has been removed info [Changelog] - Function `BaseClient.GenerateGithubAccessTokenForAppserviceCLIAsyncResponder` has been removed info [Changelog] - Field `autorest.Response` of struct `AppserviceGithubToken` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New field `AcrUseManagedIdentityCreds` in struct `SiteConfig` info [Changelog] - New field `AcrUserManagedIdentityID` in struct `SiteConfig` info [Changelog] info [Changelog] Total 5 breaking change(s), 1 additive change(s).
️✔️web/mgmt/2020-06-01/web [View full logs]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New field `AcrUserManagedIdentityID` in struct `SiteConfig` info [Changelog] - New field `AcrUseManagedIdentityCreds` in struct `SiteConfig` info [Changelog] info [Changelog] Total 0 breaking change(s), 1 additive change(s).
️✔️web/mgmt/2019-08-01/web [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️web/mgmt/2018-02-01/web [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️web/mgmt/2016-09-01/web [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️preview/web/mgmt/2015-08-01-preview/web [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️armappservice [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - New const `Enum17WindowsFunctions` info [Changelog] - New const `Enum12LinuxFunctions` info [Changelog] - New const `DeploymentBuildStatusBuildSuccessful` info [Changelog] - New const `DeploymentBuildStatusStartPollingWithRestart` info [Changelog] - New const `ResourceNotRenewableReasonSubscriptionNotActive` info [Changelog] - New const `CustomDomainStatusUnhealthy` info [Changelog] - New const `Enum12Linux` info [Changelog] - New const `Enum17LinuxFunctions` info [Changelog] - New const `Enum13All` info [Changelog] - New const `DeploymentBuildStatusRuntimeStarting` info [Changelog] - New const `CustomDNSSuffixProvisioningStateSucceeded` info [Changelog] - New const `DeploymentBuildStatusBuildAborted` info [Changelog] - New const `DeploymentBuildStatusBuildPending` info [Changelog] - New const `CustomDNSSuffixProvisioningStateFailed` info [Changelog] - New const `Enum12Windows` info [Changelog] - New const `Enum12WindowsFunctions` info [Changelog] - New const `ResourceNotRenewableReasonRegistrationStatusNotSupportedForRenewal` info [Changelog] - New const `ResourceNotRenewableReasonExpirationNotInRenewalTimeRange` info [Changelog] - New const `Enum14Windows` info [Changelog] - New const `Enum13Linux` info [Changelog] - New const `Enum12All` info [Changelog] - New const `DeploymentBuildStatusStartPolling` info [Changelog] - New const `CustomDNSSuffixProvisioningStateDegraded` info [Changelog] - New const `DeploymentBuildStatusBuildInProgress` info [Changelog] - New const `DeploymentBuildStatusRuntimeSuccessful` info [Changelog] - New const `Enum14All` info [Changelog] - New const `DeploymentBuildStatusBuildFailed` info [Changelog] - New const `DeploymentBuildStatusTimedOut` info [Changelog] - New const `Enum14Linux` info [Changelog] - New const `DeploymentBuildStatusBuildRequestReceived` info [Changelog] - New const `Enum13Windows` info [Changelog] - New const `DeploymentBuildStatusRuntimeFailed` info [Changelog] - New const `CustomDNSSuffixProvisioningStateInProgress` info [Changelog] - New const `DeploymentBuildStatusPostBuildRestartRequired` info [Changelog] - New function `*StaticSitesClient.UnlinkBackendFromBuild(context.Context, string, string, string, string, *StaticSitesClientUnlinkBackendFromBuildOptions) (StaticSitesClientUnlinkBackendFromBuildResponse, error)` info [Changelog] - New function `*EnvironmentsClient.DeleteAseCustomDNSSuffixConfiguration(context.Context, string, string, *EnvironmentsClientDeleteAseCustomDNSSuffixConfigurationOptions) (EnvironmentsClientDeleteAseCustomDNSSuffixConfigurationResponse, error)` info [Changelog] - New function `*StaticSitesClient.BeginLinkBackend(context.Context, string, string, string, StaticSiteLinkedBackendARMResource, *StaticSitesClientBeginLinkBackendOptions) (*runtime.Poller[StaticSitesClientLinkBackendResponse], error)` info [Changelog] - New function `*WebAppsClient.BeginGetProductionSiteDeploymentStatus(context.Context, string, string, string, *WebAppsClientBeginGetProductionSiteDeploymentStatusOptions) (*runtime.Poller[WebAppsClientGetProductionSiteDeploymentStatusResponse], error)` info [Changelog] - New function `*EnvironmentsClient.GetAseCustomDNSSuffixConfiguration(context.Context, string, string, *EnvironmentsClientGetAseCustomDNSSuffixConfigurationOptions) (EnvironmentsClientGetAseCustomDNSSuffixConfigurationResponse, error)` info [Changelog] - New function `PossibleEnum13Values() []Enum13` info [Changelog] - New function `*EnvironmentsClient.UpdateAseCustomDNSSuffixConfiguration(context.Context, string, string, CustomDNSSuffixConfiguration, *EnvironmentsClientUpdateAseCustomDNSSuffixConfigurationOptions) (EnvironmentsClientUpdateAseCustomDNSSuffixConfigurationResponse, error)` info [Changelog] - New function `*WebAppsClient.BeginGetSlotSiteDeploymentStatusSlot(context.Context, string, string, string, string, *WebAppsClientBeginGetSlotSiteDeploymentStatusSlotOptions) (*runtime.Poller[WebAppsClientGetSlotSiteDeploymentStatusSlotResponse], error)` info [Changelog] - New function `*StaticSitesClient.GetLinkedBackendForBuild(context.Context, string, string, string, string, *StaticSitesClientGetLinkedBackendForBuildOptions) (StaticSitesClientGetLinkedBackendForBuildResponse, error)` info [Changelog] - New function `*StaticSitesClient.BeginValidateBackendForBuild(context.Context, string, string, string, string, StaticSiteLinkedBackendARMResource, *StaticSitesClientBeginValidateBackendForBuildOptions) (*runtime.Poller[StaticSitesClientValidateBackendForBuildResponse], error)` info [Changelog] - New function `*StaticSitesClient.NewGetLinkedBackendsPager(string, string, *StaticSitesClientGetLinkedBackendsOptions) *runtime.Pager[StaticSitesClientGetLinkedBackendsResponse]` info [Changelog] - New function `*WebAppsClient.NewListSlotSiteDeploymentStatusesSlotPager(string, string, string, *WebAppsClientListSlotSiteDeploymentStatusesSlotOptions) *runtime.Pager[WebAppsClientListSlotSiteDeploymentStatusesSlotResponse]` info [Changelog] - New function `*StaticSitesClient.BeginLinkBackendToBuild(context.Context, string, string, string, string, StaticSiteLinkedBackendARMResource, *StaticSitesClientBeginLinkBackendToBuildOptions) (*runtime.Poller[StaticSitesClientLinkBackendToBuildResponse], error)` info [Changelog] - New function `*StaticSitesClient.GetLinkedBackend(context.Context, string, string, string, *StaticSitesClientGetLinkedBackendOptions) (StaticSitesClientGetLinkedBackendResponse, error)` info [Changelog] - New function `PossibleEnum14Values() []Enum14` info [Changelog] - New function `*StaticSitesClient.NewGetLinkedBackendsForBuildPager(string, string, string, *StaticSitesClientGetLinkedBackendsForBuildOptions) *runtime.Pager[StaticSitesClientGetLinkedBackendsForBuildResponse]` info [Changelog] - New function `PossibleCustomDNSSuffixProvisioningStateValues() []CustomDNSSuffixProvisioningState` info [Changelog] - New function `*StaticSitesClient.BeginValidateBackend(context.Context, string, string, string, StaticSiteLinkedBackendARMResource, *StaticSitesClientBeginValidateBackendOptions) (*runtime.Poller[StaticSitesClientValidateBackendResponse], error)` info [Changelog] - New function `PossibleEnum12Values() []Enum12` info [Changelog] - New function `*StaticSitesClient.UnlinkBackend(context.Context, string, string, string, *StaticSitesClientUnlinkBackendOptions) (StaticSitesClientUnlinkBackendResponse, error)` info [Changelog] - New function `PossibleResourceNotRenewableReasonValues() []ResourceNotRenewableReason` info [Changelog] - New function `PossibleDeploymentBuildStatusValues() []DeploymentBuildStatus` info [Changelog] - New function `*WebAppsClient.NewListProductionSiteDeploymentStatusesPager(string, string, *WebAppsClientListProductionSiteDeploymentStatusesOptions) *runtime.Pager[WebAppsClientListProductionSiteDeploymentStatusesResponse]` info [Changelog] - New struct `CsmDeploymentStatus` info [Changelog] - New struct `CsmDeploymentStatusCollection` info [Changelog] - New struct `CsmDeploymentStatusProperties` info [Changelog] - New struct `CustomDNSSuffixConfiguration` info [Changelog] - New struct `CustomDNSSuffixConfigurationProperties` info [Changelog] - New struct `EnvironmentsClientDeleteAseCustomDNSSuffixConfigurationOptions` info [Changelog] - New struct `EnvironmentsClientDeleteAseCustomDNSSuffixConfigurationResponse` info [Changelog] - New struct `EnvironmentsClientGetAseCustomDNSSuffixConfigurationOptions` info [Changelog] - New struct `EnvironmentsClientGetAseCustomDNSSuffixConfigurationResponse` info [Changelog] - New struct `EnvironmentsClientUpdateAseCustomDNSSuffixConfigurationOptions` info [Changelog] - New struct `EnvironmentsClientUpdateAseCustomDNSSuffixConfigurationResponse` info [Changelog] - New struct `StaticSiteLinkedBackend` info [Changelog] - New struct `StaticSiteLinkedBackendARMResource` info [Changelog] - New struct `StaticSiteLinkedBackendARMResourceProperties` info [Changelog] - New struct `StaticSiteLinkedBackendsCollection` info [Changelog] - New struct `StaticSitesClientBeginLinkBackendOptions` info [Changelog] - New struct `StaticSitesClientBeginLinkBackendToBuildOptions` info [Changelog] - New struct `StaticSitesClientBeginValidateBackendForBuildOptions` info [Changelog] - New struct `StaticSitesClientBeginValidateBackendOptions` info [Changelog] - New struct `StaticSitesClientGetLinkedBackendForBuildOptions` info [Changelog] - New struct `StaticSitesClientGetLinkedBackendForBuildResponse` info [Changelog] - New struct `StaticSitesClientGetLinkedBackendOptions` info [Changelog] - New struct `StaticSitesClientGetLinkedBackendResponse` info [Changelog] - New struct `StaticSitesClientGetLinkedBackendsForBuildOptions` info [Changelog] - New struct `StaticSitesClientGetLinkedBackendsForBuildResponse` info [Changelog] - New struct `StaticSitesClientGetLinkedBackendsOptions` info [Changelog] - New struct `StaticSitesClientGetLinkedBackendsResponse` info [Changelog] - New struct `StaticSitesClientLinkBackendResponse` info [Changelog] - New struct `StaticSitesClientLinkBackendToBuildResponse` info [Changelog] - New struct `StaticSitesClientUnlinkBackendFromBuildOptions` info [Changelog] - New struct `StaticSitesClientUnlinkBackendFromBuildResponse` info [Changelog] - New struct `StaticSitesClientUnlinkBackendOptions` info [Changelog] - New struct `StaticSitesClientUnlinkBackendResponse` info [Changelog] - New struct `StaticSitesClientValidateBackendForBuildResponse` info [Changelog] - New struct `StaticSitesClientValidateBackendResponse` info [Changelog] - New struct `WebAppsClientBeginGetProductionSiteDeploymentStatusOptions` info [Changelog] - New struct `WebAppsClientBeginGetSlotSiteDeploymentStatusSlotOptions` info [Changelog] - New struct `WebAppsClientGetProductionSiteDeploymentStatusResponse` info [Changelog] - New struct `WebAppsClientGetSlotSiteDeploymentStatusSlotResponse` info [Changelog] - New struct `WebAppsClientListProductionSiteDeploymentStatusesOptions` info [Changelog] - New struct `WebAppsClientListProductionSiteDeploymentStatusesResponse` info [Changelog] - New struct `WebAppsClientListSlotSiteDeploymentStatusesSlotOptions` info [Changelog] - New struct `WebAppsClientListSlotSiteDeploymentStatusesSlotResponse` info [Changelog] - New field `EmailID` in struct `CertificateEmail` info [Changelog] - New field `TimeStamp` in struct `CertificateEmail` info [Changelog] - New field `ActionType` in struct `CertificateOrderAction` info [Changelog] - New field `CreatedAt` in struct `CertificateOrderAction` info [Changelog] - New field `Hostname` in struct `WebSiteManagementClientListCustomHostNameSitesOptions` info [Changelog] - New field `PublicNetworkAccess` in struct `SiteProperties` info [Changelog] - New field `VnetImagePullEnabled` in struct `SiteProperties` info [Changelog] - New field `VnetContentShareEnabled` in struct `SiteProperties` info [Changelog] - New field `VnetRouteAllEnabled` in struct `SiteProperties` info [Changelog] - New field `NetworkingConfiguration` in struct `Environment` info [Changelog] - New field `CustomDNSSuffixConfiguration` in struct `Environment` info [Changelog] - New field `LinkedBackends` in struct `StaticSiteBuildARMResourceProperties` info [Changelog] - New field `PublicNetworkAccess` in struct `SitePatchResourceProperties` info [Changelog] - New field `LinkedBackends` in struct `StaticSite` info [Changelog] - New field `PublicNetworkAccess` in struct `StaticSite` info [Changelog] - New field `FtpEnabled` in struct `AseV3NetworkingConfigurationProperties` info [Changelog] - New field `InboundIPAddressOverride` in struct `AseV3NetworkingConfigurationProperties` info [Changelog] - New field `RemoteDebugEnabled` in struct `AseV3NetworkingConfigurationProperties` info [Changelog] info [Changelog] Total 48 breaking change(s), 152 additive change(s).
️⚠️ azure-sdk-for-js warning [Detail]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json cmderr [automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist cmderr [automation_init.sh] deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. cmderr [automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js cmderr [automation_init.sh] deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest cmderr [automation_init.sh] @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself. warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️@azure/arm-appservice [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - Added operation StaticSites.beginLinkBackendToBuild info [Changelog] - Added operation StaticSites.beginLinkBackendToBuildAndWait info [Changelog] - Added operation StaticSites.beginValidateBackend info [Changelog] - Added operation StaticSites.beginValidateBackendAndWait info [Changelog] - Added operation StaticSites.beginValidateBackendForBuild info [Changelog] - Added operation StaticSites.beginValidateBackendForBuildAndWait info [Changelog] - Added operation StaticSites.getLinkedBackend info [Changelog] - Added operation StaticSites.getLinkedBackendForBuild info [Changelog] - Added operation StaticSites.listLinkedBackends info [Changelog] - Added operation StaticSites.listLinkedBackendsForBuild info [Changelog] - Added operation StaticSites.unlinkBackend info [Changelog] - Added operation StaticSites.unlinkBackendFromBuild info [Changelog] - Added operation WebApps.beginGetProductionSiteDeploymentStatus info [Changelog] - Added operation WebApps.beginGetProductionSiteDeploymentStatusAndWait info [Changelog] - Added operation WebApps.beginGetSlotSiteDeploymentStatusSlot info [Changelog] - Added operation WebApps.beginGetSlotSiteDeploymentStatusSlotAndWait info [Changelog] - Added operation WebApps.createOneDeployOperation info [Changelog] - Added operation WebApps.getAuthSettingsV2WithoutSecretsSlot info [Changelog] - Added operation WebApps.getOneDeployStatus info [Changelog] - Added operation WebApps.listProductionSiteDeploymentStatuses info [Changelog] - Added operation WebApps.listSlotSiteDeploymentStatusesSlot info [Changelog] - Added Interface AppServiceEnvironmentsDeleteAseCustomDnsSuffixConfigurationOptionalParams info [Changelog] - Added Interface AppServiceEnvironmentsGetAseCustomDnsSuffixConfigurationOptionalParams info [Changelog] - Added Interface AppServiceEnvironmentsUpdateAseCustomDnsSuffixConfigurationOptionalParams info [Changelog] - Added Interface CertificateEmail info [Changelog] - Added Interface CertificateOrderAction info [Changelog] - Added Interface CsmDeploymentStatusCollection info [Changelog] - Added Interface StaticSiteLinkedBackend info [Changelog] - Added Interface StaticSiteLinkedBackendsCollection info [Changelog] - Added Interface StaticSitesGetLinkedBackendForBuildOptionalParams info [Changelog] - Added Interface StaticSitesGetLinkedBackendOptionalParams info [Changelog] - Added Interface StaticSitesGetLinkedBackendsForBuildNextOptionalParams info [Changelog] - Added Interface StaticSitesGetLinkedBackendsForBuildOptionalParams info [Changelog] - Added Interface StaticSitesGetLinkedBackendsNextOptionalParams info [Changelog] - Added Interface StaticSitesGetLinkedBackendsOptionalParams info [Changelog] - Added Interface StaticSitesLinkBackendOptionalParams info [Changelog] - Added Interface StaticSitesLinkBackendToBuildOptionalParams info [Changelog] - Added Interface StaticSitesUnlinkBackendFromBuildOptionalParams info [Changelog] - Added Interface StaticSitesUnlinkBackendOptionalParams info [Changelog] - Added Interface StaticSitesValidateBackendForBuildOptionalParams info [Changelog] - Added Interface StaticSitesValidateBackendOptionalParams info [Changelog] - Added Interface WebAppsCreateOneDeployOperationOptionalParams info [Changelog] - Added Interface WebAppsGetAuthSettingsV2WithoutSecretsSlotOptionalParams info [Changelog] - Added Interface WebAppsGetOneDeployStatusOptionalParams info [Changelog] - Added Interface WebAppsGetProductionSiteDeploymentStatusOptionalParams info [Changelog] - Added Interface WebAppsGetSlotSiteDeploymentStatusSlotOptionalParams info [Changelog] - Added Interface WebAppsListProductionSiteDeploymentStatusesNextOptionalParams info [Changelog] - Added Interface WebAppsListProductionSiteDeploymentStatusesOptionalParams info [Changelog] - Added Interface WebAppsListSlotSiteDeploymentStatusesSlotNextOptionalParams info [Changelog] - Added Interface WebAppsListSlotSiteDeploymentStatusesSlotOptionalParams info [Changelog] - Added Type Alias AppServiceEnvironmentsDeleteAseCustomDnsSuffixConfigurationResponse info [Changelog] - Added Type Alias AppServiceEnvironmentsGetAseCustomDnsSuffixConfigurationResponse info [Changelog] - Added Type Alias AppServiceEnvironmentsUpdateAseCustomDnsSuffixConfigurationResponse info [Changelog] - Added Type Alias CsmDeploymentStatus info [Changelog] - Added Type Alias CustomDnsSuffixConfiguration info [Changelog] - Added Type Alias CustomDnsSuffixProvisioningState info [Changelog] - Added Type Alias DeploymentBuildStatus info [Changelog] - Added Type Alias Enum12 info [Changelog] - Added Type Alias Enum13 info [Changelog] - Added Type Alias Enum14 info [Changelog] - Added Type Alias ResourceNotRenewableReason info [Changelog] - Added Type Alias StaticSiteLinkedBackendARMResource info [Changelog] - Added Type Alias StaticSitesGetLinkedBackendForBuildResponse info [Changelog] - Added Type Alias StaticSitesGetLinkedBackendResponse info [Changelog] - Added Type Alias StaticSitesGetLinkedBackendsForBuildNextResponse info [Changelog] - Added Type Alias StaticSitesGetLinkedBackendsForBuildResponse info [Changelog] - Added Type Alias StaticSitesGetLinkedBackendsNextResponse info [Changelog] - Added Type Alias StaticSitesGetLinkedBackendsResponse info [Changelog] - Added Type Alias StaticSitesLinkBackendResponse info [Changelog] - Added Type Alias StaticSitesLinkBackendToBuildResponse info [Changelog] - Added Type Alias WebAppsCreateOneDeployOperationResponse info [Changelog] - Added Type Alias WebAppsGetAuthSettingsV2WithoutSecretsSlotResponse info [Changelog] - Added Type Alias WebAppsGetOneDeployStatusResponse info [Changelog] - Added Type Alias WebAppsGetProductionSiteDeploymentStatusResponse info [Changelog] - Added Type Alias WebAppsGetSlotSiteDeploymentStatusSlotResponse info [Changelog] - Added Type Alias WebAppsListProductionSiteDeploymentStatusesNextResponse info [Changelog] - Added Type Alias WebAppsListProductionSiteDeploymentStatusesResponse info [Changelog] - Added Type Alias WebAppsListSlotSiteDeploymentStatusesSlotNextResponse info [Changelog] - Added Type Alias WebAppsListSlotSiteDeploymentStatusesSlotResponse info [Changelog] - Interface AppServiceEnvironment has a new optional parameter customDnsSuffixConfiguration info [Changelog] - Interface AppServiceEnvironment has a new optional parameter networkingConfiguration info [Changelog] - Interface ListCustomHostNameSitesNextOptionalParams has a new optional parameter hostname info [Changelog] - Interface ListCustomHostNameSitesOptionalParams has a new optional parameter hostname info [Changelog] - Type Alias AppServiceEnvironmentPatchResource has a new parameter customDnsSuffixConfiguration info [Changelog] - Type Alias AppServiceEnvironmentPatchResource has a new parameter networkingConfiguration info [Changelog] - Type Alias AppServiceEnvironmentResource has a new parameter customDnsSuffixConfiguration info [Changelog] - Type Alias AppServiceEnvironmentResource has a new parameter networkingConfiguration info [Changelog] - Type Alias AseV3NetworkingConfiguration has a new parameter ftpEnabled info [Changelog] - Type Alias AseV3NetworkingConfiguration has a new parameter remoteDebugEnabled info [Changelog] - Type Alias AseV3NetworkingConfiguration has a new parameter inboundIpAddressOverride info [Changelog] - Type Alias Site has a new parameter vnetRouteAllEnabled info [Changelog] - Type Alias Site has a new parameter vnetImagePullEnabled info [Changelog] - Type Alias Site has a new parameter vnetContentShareEnabled info [Changelog] - Type Alias Site has a new parameter publicNetworkAccess info [Changelog] - Type Alias SitePatchResource has a new parameter publicNetworkAccess info [Changelog] - Type Alias StaticSiteARMResource has a new parameter linkedBackends info [Changelog] - Type Alias StaticSiteARMResource has a new parameter publicNetworkAccess info [Changelog] - Type Alias StaticSiteBuildARMResource has a new parameter linkedBackends info [Changelog] - Type Alias StaticSitePatchResource has a new parameter linkedBackends info [Changelog] - Type Alias StaticSitePatchResource has a new parameter publicNetworkAccess info [Changelog] - Added Enum KnownDeploymentBuildStatus info [Changelog] - Added Enum KnownEnum12 info [Changelog] - Added Enum KnownEnum13 info [Changelog] - Added Enum KnownEnum14 info [Changelog] - Added Enum KnownResourceNotRenewableReason info [Changelog] - Enum KnownCustomDomainStatus has a new value Unhealthy info [Changelog] - Enum KnownEnum17 has a new value LinuxFunctions info [Changelog] - Enum KnownEnum17 has a new value WindowsFunctions info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Removed Enum KnownAppServiceCertificateOrderPatchResourcePropertiesAppServiceCertificateNotRenewableReasonsItem info [Changelog] - Removed Enum KnownAppServiceCertificateOrderPropertiesAppServiceCertificateNotRenewableReasonsItem info [Changelog] - Removed Enum KnownDomainPatchResourcePropertiesDomainNotRenewableReasonsItem info [Changelog] - Removed Enum KnownDomainPropertiesDomainNotRenewableReasonsItem info [Changelog] - Removed Enum KnownEnum18 info [Changelog] - Removed Enum KnownEnum19 info [Changelog] - Removed Enum KnownEnum20 info [Changelog] - Enum KnownEnum15 no longer has value LinuxFunctions info [Changelog] - Enum KnownEnum15 no longer has value WindowsFunctions
️🔄 azure-resource-manager-schemas inProgress [Detail]
|
Hi, @jiansong-msft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
1 similar comment
|
Hi, @jiansong-msft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Hi @jiansong-msft, Your PR has some issues. Please fix the CI sequentially by following the order of
|
1 similar comment
|
Hi @jiansong-msft, Your PR has some issues. Please fix the CI sequentially by following the order of
|
specification/web/resource-manager/Microsoft.Web/stable/2022-03-01/CommonDefinitions.json
Outdated
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
Jun 8, 2022
This was referenced Jun 8, 2022
weidongxu-microsoft
added a commit
that referenced
this pull request
Jun 24, 2022
* Adds base for updating Microsoft.Web from version stable/2021-03-01 to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * Carry fwd Microsoft.CertificateRegistration and Microsoft.DomainRegis… (#18460) * Carry fwd Microsoft.CertificateRegistration and Microsoft.DomainRegistration RPs to Api-version 2022-03-01 * Add x-ms-enum for array of inline enums. Fix reference to older api version for common defs * Add examples for App Service Certificate orders * Add suppressions back * Add examples for Microsoft.DomainRegistration RP * Fixes from prettier * Remove unused example * Add Unhealthy CustomDomainStatus for StaticSites (#18557) * Adding VnetRouteAllEnabled, VnetImagePullEnabled, VnetContentShareEnabled site properties to CommonDefinitions (#18627) * Added vnet realted site properties to common definitions * removed tab Co-authored-by: Tanay Bhartia <tanaybhartia@microsoft.com> * Add Ftp/Remote debug properties to Ase network config (#18549) * Add Ftp/Remote debug properties to Ase network config * Switched changes to the right file * Add Networking config to hosting environment creates * Added some of the missing examples * Remove disallowed properties from example Ase GET response * Adjusted responses from other gets * Added a bunch more examples * Added other missing examples for Ase. * Added more missing examples for Ase. * fixed formatting * Edit some examples, add back privatelink apis and try to supress the errors for missing examples. * Fix suppress spelling and fix prettier * Added missing privatelink examples since suppressing did not work * Add Bring your own Backend operations (#18517) * add bring your own backend operations * add missing files * fix json formattin * validation fixes * fix * fix more validation * fix ids * fix model validation * fix descriptions * fix environmentName description * change to 202 * revert change to 202 * customhostnamesites optional param for 2022 API version (#18670) * fix DUPLICATE_PARAMETER * prettier * fix OBJECT_ADDITIONAL_PROPERTIES * fix random sub in examples * add optional hostname param to customHostnameSites RT and add examples * move changes from 2021 api version to 2022 * move examples to 2022 * Revert "add optional hostname param to customHostnameSites RT and add examples" This reverts commit 7fc318e. * remove examples from 2021 * fix lintDiff * prettier fix * model validation fix * suppress model validation in readme Co-authored-by: Elle Tojaroon <patojaro@microsoft.com> * [Microsoft.Web] Add CustomDnsSuffixConfiguration to ASE (#18553) * [Microsoft.Web] Add CustomDnsSuffixConfiguration to AppServiceEnvironments * Add examples * Fix style issues * Add customdnssuffix to custom-words * Add CustomDnsSuffixConfiguration to AppServiceEnvironment definition * Address remaining model validation errors * Adjusted networking configuration definitions * Addressed Arm review feedback Co-authored-by: Jarod Aerts <jarodaerts@microsoft.com> * Fork/web ant97 2022 03 01 (#19259) * Added DeploymentStatus API specs and examples * change status to enum, rm extra dot * suppress missing examples for now * rm id from List Deployment Slot examples * rm location, and rename deploymentId in GetSiteDeploymentStatus examples * change model as string to true, add 202 operations for DeploymentStatus ops to spec * rename operationId to deploymentStatusId, undo deploymentId rename * add long running op, as per linter Co-authored-by: Shubham Dhond <shdhond@microsoft.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> * PublicNetworkAccess Swagger Change (#19352) * add publicNetworkAccess property in site for swagger * add suppression to fix Model Validation CI * Add allowed values in the description * Add specs for Hosting Environment Maintenance Control (#18691) * Add documentation for Hosting Environment Maintenance Control * Update example file name * Make UpgradePreference non-nullable * Correct indentation to 2 spaces * Fix upgradePreference indentation * Address swagger feedback. Add enums with descriptions. * Move testNotification to request body. Update description text * Fix testNotification * Fix example * Replace TestNotification parameter with TestUpgradeNotification API * Rename to TestUpgradeAvailableNotification * Added logic apps operations (#18604) * Added Initial Operations and some definitions * Adding additional objects to support Logic Apps operations * Updated path and parameters to match testing * Prettier Fixes * oav validat-example fixes * Github validation fixes * Prettier * Updated examples and paths * Prettier * Revert "Prettier" This reverts commit da090ad. * Prettier * Fixed model validation errors * Filled in nextLinkName values * Fixing swagger lintdiff errors * added x-ms-long-running to async calls * Adds numberOfWorkers to app service plan (#19475) * Adds numberOfWorkers to app service plan * Add suppression for missing ASP examples * Updating to fix workflow errors (#19490) * Removed conflicting resource definition and added reference to CommonDefinitions.json (#19507) * Removed conflicting resource definition and added reference to CommonDefinitions.json * Updated resource to have workflow version * Updated nextLink object to be correctly tagged (#19560) * Updated nextLink object to be correctly tagged * Adding value placeholder * Updated SKU to remove conflict * Updated x-ms-enum * Added missing model * Adding more missing models * Add suppressions for missing examples (#19563) Co-authored-by: Joseph Lin <54335291+joslinmicrosoft@users.noreply.github.com> Co-authored-by: Tanay Bhartia <tanaybhartia@gmail.com> Co-authored-by: Tanay Bhartia <tanaybhartia@microsoft.com> Co-authored-by: JarodAertsMs <90280240+JarodAertsMs@users.noreply.github.com> Co-authored-by: annikel <92825476+annikel@users.noreply.github.com> Co-authored-by: Paviya (Elle) Tojaroon <pt335@cornell.edu> Co-authored-by: Elle Tojaroon <patojaro@microsoft.com> Co-authored-by: Chris Chen <chrc@microsoft.com> Co-authored-by: Jarod Aerts <jarodaerts@microsoft.com> Co-authored-by: edwin-msft <71858592+edwin-msft@users.noreply.github.com> Co-authored-by: Shubham Dhond <shdhond@microsoft.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: jiansong-msft <77516279+jiansong-msft@users.noreply.github.com> Co-authored-by: Derek Johnson <47129225+dejo-msft@users.noreply.github.com> Co-authored-by: Alex Karcher <alkarche@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
add a new property in site property - poublicNetworkAccess
(https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi021-putpatch-shouldnt-fail-for-readonly-properties)).
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.