Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] - Adding status code 202 to Private endpoints PUT #19125

Merged
merged 1 commit into from
Jul 13, 2022
Merged

[Service Bus] - Adding status code 202 to Private endpoints PUT #19125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...ceBus/preview/2022-01-01-preview/examples/NameSpaces/PrivateEndPointConnectionCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,23 @@
}
}
}
},
"202": {
"body": {
"id": "/subscriptions/dbedb4e0-40e6-4145-81f3-f1314c150774/resourceGroups/SDK-ServiceBus-4794/providers/Microsoft.ServiceBus/namespaces/sdk-Namespace-5828/privateEndpointConnections/928c44d5-b7c6-423b-b6fa-811e0c27b3e0",
"name": "928c44d5-b7c6-423b-b6fa-811e0c27b3e0",
"type": "Microsoft.ServiceBus/Namespaces/PrivateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/dbedb4e0-40e6-4145-81f3-f1314c150774/resourceGroups/SDK-ServiceBus-4794/providers/Microsoft.Network/privateEndpoints/sdk-Namespace-5828"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved"
}
}
}
}
}
}
6 changes: 6 additions & 0 deletions ...s/resource-manager/Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,12 @@
"$ref": "#/definitions/PrivateEndpointConnection"
}
},
"202": {
"description": "Request to update Status of PrivateEndPoint Connection accepted.",
"schema": {
"$ref": "#/definitions/PrivateEndpointConnection"
}
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PUTs should not be returning 202s. Why do you need to make this change in existing API ? :

Please read through the details here :
https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creating-or-updating-resources-asynchronously

Copy link
Member

@damodaravadhani damodaravadhani Jul 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raosuhas , we have made this change in a previous api version as well in this PR #19155 and no questions were raised. The reason we made this change is that otherwise it renders out CreateOrUpdate command useless since it majorly returns 202. And it would be difficult to work on a service side fix for this now. We have already released the fix in 2021-11-01 SDK, please allow it in 2022-01-01-preview as well. Thank you.

"default": {
"description": "ServiceBus error response describing why the operation failed.",
"schema": {
Expand Down