Add keyVaultNetworkAccess and keyVaultResourceId into securityProfile.azureKeyVaultKms to support key vault with private link #19086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….azureKeyVaultKms to support key vault with private link
|
Hi, @bingosummer Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The read only property has changed from 'true' to 'false'. New: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L3257:9 Old: Microsoft.ContainerService/stable/2022-04-01/managedClusters.json#L2673:9 |
|
The read only property has changed from 'true' to 'false'. New: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L3257:9 Old: Microsoft.ContainerService/stable/2022-04-01/managedClusters.json#L2673:9 |
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced May 16, 2022
FumingZhang
reviewed
May 16, 2022
| ], | ||
| "default": "Public", | ||
| "x-ms-enum": { | ||
| "name": "KeyVaultNetworkAccess", |
There was a problem hiding this comment.
Better to distinguish it from the property name. Maybe something like KeyVaultNetworkAccessTypes.
There was a problem hiding this comment.
Sure. What's the purpose of "x-ms-enum"?
There was a problem hiding this comment.
See details of "x-ms-enum".
One example would be the following snippet from Python SDK, the name in x-ms-enum would be the class name.
class TrustedAccessRoleBindingProvisioningState(with_metaclass(CaseInsensitiveEnumMeta, str, Enum)):
"""The current provisioning state of trusted access role binding.
"""
SUCCEEDED = "Succeeded"
FAILED = "Failed"
UPDATING = "Updating"
DELETING = "Deleting"
| "modelAsString": true | ||
| }, | ||
| "title": "Network access of the key vault", | ||
| "description": "network access of key vault. The possible values are `Public` and `Private`. `Public` means the key vault allows public access from all networks. `Private` means the key vault disables public access and enables private link. The default value is `Public`." |
There was a problem hiding this comment.
Capitalize network access ...?
| }, | ||
| "keyVaultResourceId": { | ||
| "type": "string", | ||
| "description": "Resource ID of key vault. When keyVaultNetworkAccess is Private, this field is required and must be a valid resource ID. When keyVaultNetworkAccess is Public, leave the field empty." |
There was a problem hiding this comment.
Also use `` to mark the value of keyVaultNetworkAccess?
|
By the way, I have notified the feature owner of currentOrchestratorVersion (the error in Cross-Version Breaking Changes) to check the reason why the stable and preview API definitions are different. |
|
@FumingZhang Q: In the check "SDK azure-sdk-for-go", the error seems not related to this PR. Could you please have a check? |
Yes, that's a known issue, pending fix by GO SDK owner. |
6c1cb5e
into
Azure:dev-containerservice-Microsoft.ContainerService-2022-05-02-preview
honghr
pushed a commit
that referenced
this pull request
Jun 2, 2022
…02-preview (#19262) * Adds base for updating Microsoft.ContainerService from version preview/2022-04-02-preview to version 2022-05-02-preview * Updates readme * Updates API version in new specs and examples * update readmes (#19081) * add blob csi driver into 0502preview (#19095) Co-authored-by: weizhichen <weizhichen@microsoft.com> * Add read only field for `currentOrchestratorVersion` (#19107) * currentOrchestratorVersion is read-only property * Only apply change to 2022-05-02-preview * Add keyVaultNetworkAccess and keyVaultResourceId into securityProfile.azureKeyVaultKms to support key vault with private link (#19086) * Add keyVaultNetworkAccess and keyVaultResourceId into securityProfile.azureKeyVaultKms to support key vault with private link * fix * Add KEDA configuration options (#19153) * 2022-05-02-preview defender updates (#19172) * 2022-05-02-preview defender updates * update example * Typo * Update sample * typo * another typo Co-authored-by: weizhi <ftdchenwz@gmail.com> Co-authored-by: weizhichen <weizhichen@microsoft.com> Co-authored-by: Thalia Wang <58485997+wenxuan0923@users.noreply.github.com> Co-authored-by: Bin Xia <binxi@microsoft.com> Co-authored-by: Jatin Sanghvi <20547963+JatinSanghvi@users.noreply.github.com> Co-authored-by: Or Parnes <orparnes@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.