Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specificationRepositoryConfiguration.json #18391

Closed
wants to merge 2 commits into from

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Mar 24, 2022

Python has dropped track1 so there is no need to run pipeline for track1.
Azure/azure-sdk-for-python#23423

@msyyc msyyc self-assigned this Mar 24, 2022
@openapi-workflow-bot
Copy link

Hi, @msyyc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 24, 2022

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/50a4654bc9b95bd96e66c41c29d5f690481adc77/specificationRepositoryConfiguration.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specificationRepositoryConfiguration.json",
    "details":"Command failed: node /home/vsts/work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.27/common/temp/node_modules/.pnpm/@Azure+oad@0.9.3/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: File 'file:///home/vsts/work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')\n Error: File 'file:///home/vsts/work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')\n"
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    unacceptable kind of an object to dump [object Error] "role":"Model Validation",
    "url":"https://github.com/Azure/azure-rest-api-specs/blob/50a4654bc9b95bd96e66c41c29d5f690481adc77/specificationRepositoryConfiguration.json"
    ️❌SemanticValidation: 7 Errors, 0 Warnings failed [Detail]
    Rule Message
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: swagger
    JsonUrl: azure-rest-api-specs/blob/50a4654bc9b95bd96e66c41c29d5f690481adc77/specificationRepositoryConfiguration.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: info
    JsonUrl: azure-rest-api-specs/blob/50a4654bc9b95bd96e66c41c29d5f690481adc77/specificationRepositoryConfiguration.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: paths
    JsonUrl: azure-rest-api-specs/blob/50a4654bc9b95bd96e66c41c29d5f690481adc77/specificationRepositoryConfiguration.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: $schema
    JsonUrl: azure-rest-api-specs/blob/50a4654bc9b95bd96e66c41c29d5f690481adc77/specificationRepositoryConfiguration.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: pipelineName
    JsonUrl: azure-rest-api-specs/blob/50a4654bc9b95bd96e66c41c29d5f690481adc77/specificationRepositoryConfiguration.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: sdkRepositoryMappings
    JsonUrl: azure-rest-api-specs/blob/50a4654bc9b95bd96e66c41c29d5f690481adc77/specificationRepositoryConfiguration.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: overrides
    JsonUrl: azure-rest-api-specs/blob/50a4654bc9b95bd96e66c41c29d5f690481adc77/specificationRepositoryConfiguration.json
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 24, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @msyyc, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @ghost
    Copy link

    ghost commented Apr 10, 2022

    Hi, @msyyc. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Apr 10, 2022
    @msyyc msyyc closed this Apr 11, 2022
    @msyyc msyyc deleted the update-python-config branch April 11, 2022 05:09
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants