[Microsoft.KubernetesConfiguration] Release Stable Api-Version 2022-03-01 #17678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preview/2022-01-01-preview to version 2022-03-01
Swagger Generation Artifacts
|
|
Hi, @jonathan-innis Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
|
Hi @jonathan-innis, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 5, 2022
9b983b4 to
a40a3d5
Compare
This was referenced Feb 5, 2022
ae1e562 to
a20f26f
Compare
a20f26f to
338a39c
Compare
ruowan
approved these changes
Feb 15, 2022
ArcturusZhang
requested changes
Feb 22, 2022
|
Also I would like to know that what is the relationship between this PR and this? The other PR is introducing an api-version 2022-01-15-preview which is apparently older than this one. Could we say that our PR supersedes that one? |
ArcturusZhang
requested changes
Feb 22, 2022
There was a problem hiding this comment.
I marked some breaking changes that are possible to resolve at this level.
Also I noticed that this stable api-version does not have the entityTypes.json swagger, which also results in a lot of things are removed in the generated SDK.
Is it possible that we could introduce a composite tag to include everything in our stable api-version and the left-overs in the previous preview api-version, such as entityTypes.json?
Also there are some changes in definitions.FluxConfiguration.properties.properties, we are adding something new and removing something else. Please make sure we apply the same to new preview api-versions, I believe the customers would not like things in SDKs to change back and forth.
...uration/resource-manager/Microsoft.KubernetesConfiguration/common/2022-03-01/parameters.json
Show resolved
Hide resolved
...uration/resource-manager/Microsoft.KubernetesConfiguration/common/2022-03-01/parameters.json
Show resolved
Hide resolved
| "type": "array", | ||
| "items": { | ||
| "description": "Kustomization name of dependency.", | ||
| "type": "string" |
There was a problem hiding this comment.
Previously the type of the item here is DependsOnDefinition(see here), but now it is just a string. This is a breaking change to the SDKs and it breaks backward compatibility because it changes the structure of the json payload as well. Previously, the JSON looks like
"dependsOn": [ { "kustomizationName": "something" } ]
and now it should look like
"dependsOn": [ "something" ]
Please double confirm this change, especially from the service code side - and, if possible, please consider revert this.
There was a problem hiding this comment.
We are coming from a preview version. As far as I am aware, we are allowed to make breaking changes between preview and GA? Is there some additional requirement here?
There was a problem hiding this comment.
It is allowed. I am just here to double confirm this breaking change with you.
There was a problem hiding this comment.
Got it, we will be taking this breaking change
It doesn't necessarily supersede that one. They are covering completely different resource types which are not included in the GA stable release. |
What is |
ArcturusZhang
approved these changes
Feb 23, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 8, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Mar 8, 2022
…n] Release Stable Api-Version 2022-03-01 (#2241) Create to sync Azure/azure-rest-api-specs#17678 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/kubernetesconfiguration?expand=1)
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
…3-01 (Azure#17678) * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2022-01-01-preview to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * Update fluxConfigurations and common file for dynamic rp provider * Update readme for sdk generation * Add kustomization name to object model * Change property names for Flux and add statusUpdatedAt * Add x-ms-identifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.