Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure App Configuration] Add 2021-10-01-preview version #17444

Merged
merged 5 commits into from
Jan 24, 2022
Merged

[Azure App Configuration] Add 2021-10-01-preview version #17444

merged 5 commits into from
Jan 24, 2022

Conversation

x9xu
Copy link
Contributor

@x9xu x9xu commented Jan 21, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @x9xu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 21, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @x9xu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 21, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 4 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enablePurgeProtection
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1319
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: purgeProtectionEnabled
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L2188
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationStores_CheckNameAvailable
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1191
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationStores_CheckNameNotAvailable
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1191


    The following errors/warnings exist before current PR submission:

    Rule Message
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L559
    R4009 - RequiredReadOnlySystemData The response of operation:'KeyValues_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L868
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L606
    R4009 - RequiredReadOnlySystemData The response of operation:'KeyValues_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L915
    R4037 - MissingTypeObject The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1886
    R4037 - MissingTypeObject The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1919
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1681
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: fillGapWithZero
    Location: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1796
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 16 Errors, 24 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/ListKeys' removed or restructured?
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L365:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/RegenerateKey' removed or restructured?
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L417:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/listKeyValue' removed or restructured?
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L507:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ListKeyValueParameters' removed or renamed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1202:3
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L861:3
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1912:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1362:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1912:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1362:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'key' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1573:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'label' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1573:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'value' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1573:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'contentType' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1573:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'eTag' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1573:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'lastModified' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1573:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'locked' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1573:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tags' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1573:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'location' renamed or removed?
    New: common-types/resource-management/v2/types.json#L13:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1378:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tags' renamed or removed?
    New: common-types/resource-management/v2/types.json#L13:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1378:7
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L49:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L49:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L98:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L98:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L143:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L143:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L198:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L198:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L248:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L245:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L304:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L301:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L356:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L350:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L502:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L496:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L543:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L588:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L595:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L640:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L657:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L702:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L708:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L753:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L751:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L796:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L803:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L848:13


    The following breaking changes are detected by comparison with latest preview version:

    Rule Message
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1308:9
    Old: Microsoft.AppConfiguration/preview/2021-03-01-preview/appconfiguration.json#L1130:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 21, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armappconfiguration - 0.3.0
    +	Function `ErrorDetails.MarshalJSON` has been removed
    +	Struct `ErrorAdditionalInfo` has been removed
    +	Struct `ErrorDetails` has been removed
    +	Struct `ErrorResponse` has been removed
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-appconfiguration - 2.0.0
    ️✔️azure-sdk-for-go - appconfiguration/mgmt/2020-06-01/appconfiguration - v61.3.0
    ️✔️azure-sdk-for-go - appconfiguration/mgmt/2019-10-01/appconfiguration - v61.3.0
    ️✔️azure-sdk-for-go - preview/appconfiguration/mgmt/2021-03-01-preview/appconfiguration - v61.3.0
    ️✔️azure-sdk-for-go - preview/appconfiguration/mgmt/2020-07-01-preview/appconfiguration - v61.3.0
    ️✔️azure-sdk-for-go - preview/appconfiguration/mgmt/2019-11-01-preview/appconfiguration - v61.3.0
    ️✔️azure-sdk-for-go - preview/appconfiguration/mgmt/2019-02-01-preview/appconfiguration - v61.3.0
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 07a5e29. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      Resource not accessible by integration
      HttpError: Resource not accessible by integration
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit+request@5.6.0/node_modules/@octokit/request/dist-node/index.js:86:21
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:346:21)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️Az.AppConfiguration [View full logs
      error	Fatal error: Resource not accessible by integration
      error	The following packages are still pending:
      error		Az.AppConfiguration
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 07a5e29. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh]  New minor version of npm available! 8.1.2 -> 8.3.2
      cmderr	[automation_generate.sh]  Changelog: <https://github.com/npm/cli/releases/tag/v8.3.2>
      cmderr	[automation_generate.sh]  Run `npm install -g npm@8.3.2` to update!
      cmderr	[automation_generate.sh]
    • ️✔️track2_azure-mgmt-appconfiguration [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation ConfigurationStoresOperations.begin_purge_deleted
      info	[Changelog]   - Added operation ConfigurationStoresOperations.get_deleted
      info	[Changelog]   - Added operation ConfigurationStoresOperations.list_deleted
      info	[Changelog]   - Added operation Operations.regional_check_name_availability
      info	[Changelog]   - Model ConfigurationStore has a new parameter create_mode
      info	[Changelog]   - Model ConfigurationStore has a new parameter enable_purge_protection
      info	[Changelog]   - Model ConfigurationStore has a new parameter soft_delete_retention_in_days
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 07a5e29. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Automation-Sdk-Generate.ps1] �[91mWrite-Error: �[91mError occurred while generating code for Azure.ResourceManager.AppConfiguration
      cmderr	[Automation-Sdk-Generate.ps1] �[0m
    • Azure.ResourceManager.AppConfiguration [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 07a5e29. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2022-01-24 06:35:54 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-appconfiguration;1.0.0-beta.3;1.0.0-beta.4"
      cmderr	[generate.py] 2022-01-24 06:35:54 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.4"
      cmderr	[generate.py] 2022-01-24 06:35:54 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/appconfiguration/azure-resourcemanager-appconfiguration --java.namespace=com.azure.resourcemanager.appconfiguration   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/appconfiguration/resource-manager/readme.md
      cmderr	[generate.py] 2022-01-24 06:36:21 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-appconfiguration
      cmderr	[generate.py] 2022-01-24 06:36:21 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2022-01-24 06:36:21 INFO [POM][Skip] pom already has module azure-resourcemanager-appconfiguration
      cmderr	[generate.py] 2022-01-24 06:36:21 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2022-01-24 06:36:21 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2022-01-24 06:36:21 INFO [POM][Skip] pom already has module sdk/appconfiguration
      cmderr	[generate.py] 2022-01-24 06:36:21 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-appconfiguration [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2022-01-24 06:37:55 DEBUG Got artifact_id: azure-resourcemanager-appconfiguration
      cmderr	[Inst] 2022-01-24 06:37:55 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2022-01-24 06:37:55 DEBUG Got artifact: azure-resourcemanager-appconfiguration-1.0.0-beta.4.jar
      cmderr	[Inst] 2022-01-24 06:37:55 DEBUG Match jar package: azure-resourcemanager-appconfiguration-1.0.0-beta.4.jar
      cmderr	[Inst] 2022-01-24 06:37:55 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17444/azure-sdk-for-java/azure-resourcemanager-appconfiguration/azure-resourcemanager-appconfiguration-1.0.0-beta.4.jar\" -o azure-resourcemanager-appconfiguration-1.0.0-beta.4.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-appconfiguration -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-appconfiguration-1.0.0-beta.4.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 07a5e29. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/appconfiguration/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      Server Error
      HttpError: Server Error
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit+request@5.6.0/node_modules/@octokit/request/dist-node/index.js:86:21
          at runMicrotasks (<anonymous>)
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:326:9)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️Microsoft.Azure.Management.AppConfiguration [View full logs
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
      error	Fatal error: Server Error
      error	The following packages are still pending:
      error		Microsoft.Azure.Management.AppConfiguration
    ️❌ azure-sdk-for-js failed [Detail]
    • Failed [Logs]Release - Generate from 07a5e29. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      Server Error
      HttpError: Server Error
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit+request@5.6.0/node_modules/@octokit/request/dist-node/index.js:86:21
          at runMicrotasks (<anonymous>)
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:326:9)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:87:13)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️track2_@azure/arm-appconfiguration [View full logs
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
      error	Fatal error: Server Error
      error	The following packages are still pending:
      error		track2_@azure/arm-appconfiguration
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 07a5e29. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️appconfiguration/mgmt/2020-06-01/appconfiguration [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️appconfiguration/mgmt/2019-10-01/appconfiguration [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/appconfiguration/mgmt/2021-03-01-preview/appconfiguration [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/appconfiguration/mgmt/2020-07-01-preview/appconfiguration [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/appconfiguration/mgmt/2019-11-01-preview/appconfiguration [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/appconfiguration/mgmt/2019-02-01-preview/appconfiguration [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 07a5e29. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armappconfiguration [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `ErrorDetails.MarshalJSON` has been removed
      info	[Changelog] - Struct `ErrorAdditionalInfo` has been removed
      info	[Changelog] - Struct `ErrorDetails` has been removed
      info	[Changelog] - Struct `ErrorResponse` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `CreateModeDefault`
      info	[Changelog] - New const `CreateModeRecover`
      info	[Changelog] - New function `*OperationsClient.RegionalCheckNameAvailability(context.Context, string, CheckNameAvailabilityParameters, *OperationsClientRegionalCheckNameAvailabilityOptions) (OperationsClientRegionalCheckNameAvailabilityResponse, error)`
      info	[Changelog] - New function `*ConfigurationStoresClientListDeletedPager.NextPage(context.Context) bool`
      info	[Changelog] - New function `*ConfigurationStoresClientPurgeDeletedPoller.Poll(context.Context) (*http.Response, error)`
      info	[Changelog] - New function `PossibleCreateModeValues() []CreateMode`
      info	[Changelog] - New function `ConfigurationStoresClientPurgeDeletedPollerResponse.PollUntilDone(context.Context, time.Duration) (ConfigurationStoresClientPurgeDeletedResponse, error)`
      info	[Changelog] - New function `*ConfigurationStoresClientPurgeDeletedPoller.ResumeToken() (string, error)`
      info	[Changelog] - New function `*ConfigurationStoresClient.BeginPurgeDeleted(context.Context, string, string, *ConfigurationStoresClientBeginPurgeDeletedOptions) (ConfigurationStoresClientPurgeDeletedPollerResponse, error)`
      info	[Changelog] - New function `*ConfigurationStoresClientPurgeDeletedPollerResponse.Resume(context.Context, *ConfigurationStoresClient, string) error`
      info	[Changelog] - New function `*ConfigurationStoresClient.GetDeleted(context.Context, string, string, *ConfigurationStoresClientGetDeletedOptions) (ConfigurationStoresClientGetDeletedResponse, error)`
      info	[Changelog] - New function `*ConfigurationStoresClientPurgeDeletedPoller.FinalResponse(context.Context) (ConfigurationStoresClientPurgeDeletedResponse, error)`
      info	[Changelog] - New function `*ConfigurationStoresClient.ListDeleted(*ConfigurationStoresClientListDeletedOptions) *ConfigurationStoresClientListDeletedPager`
      info	[Changelog] - New function `DeletedConfigurationStoreProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `CreateMode.ToPtr() *CreateMode`
      info	[Changelog] - New function `*ConfigurationStoresClientListDeletedPager.Err() error`
      info	[Changelog] - New function `*ConfigurationStoresClientPurgeDeletedPoller.Done() bool`
      info	[Changelog] - New function `*DeletedConfigurationStoreProperties.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `*ConfigurationStoresClientListDeletedPager.PageResponse() ConfigurationStoresClientListDeletedResponse`
      info	[Changelog] - New function `DeletedConfigurationStoreListResult.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `ConfigurationStoresClientBeginPurgeDeletedOptions`
      info	[Changelog] - New struct `ConfigurationStoresClientGetDeletedOptions`
      info	[Changelog] - New struct `ConfigurationStoresClientGetDeletedResponse`
      info	[Changelog] - New struct `ConfigurationStoresClientGetDeletedResult`
      info	[Changelog] - New struct `ConfigurationStoresClientListDeletedOptions`
      info	[Changelog] - New struct `ConfigurationStoresClientListDeletedPager`
      info	[Changelog] - New struct `ConfigurationStoresClientListDeletedResponse`
      info	[Changelog] - New struct `ConfigurationStoresClientListDeletedResult`
      info	[Changelog] - New struct `ConfigurationStoresClientPurgeDeletedPoller`
      info	[Changelog] - New struct `ConfigurationStoresClientPurgeDeletedPollerResponse`
      info	[Changelog] - New struct `ConfigurationStoresClientPurgeDeletedResponse`
      info	[Changelog] - New struct `DeletedConfigurationStore`
      info	[Changelog] - New struct `DeletedConfigurationStoreListResult`
      info	[Changelog] - New struct `DeletedConfigurationStoreProperties`
      info	[Changelog] - New struct `OperationsClientRegionalCheckNameAvailabilityOptions`
      info	[Changelog] - New struct `OperationsClientRegionalCheckNameAvailabilityResponse`
      info	[Changelog] - New struct `OperationsClientRegionalCheckNameAvailabilityResult`
      info	[Changelog] - New field `CreateMode` in struct `ConfigurationStoreProperties`
      info	[Changelog] - New field `EnablePurgeProtection` in struct `ConfigurationStoreProperties`
      info	[Changelog] - New field `SoftDeleteRetentionInDays` in struct `ConfigurationStoreProperties`
      info	[Changelog]
      info	[Changelog] Total 7 breaking change(s), 55 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 07a5e29. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️appconfiguration [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @x9xu
    Copy link
    Contributor Author

    x9xu commented Jan 21, 2022

    Link to approved private PR: #17410

    @openapi-workflow-bot
    Copy link

    Hi @x9xu, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @jianyexi
    Copy link
    Contributor

    Link to approved private PR: #17410

    Sure ? , seem these two PRs are not relevant

    @x9xu
    Copy link
    Contributor Author

    x9xu commented Jan 21, 2022

    Link to approved private PR: #17410

    Sure ? , seem these two PRs are not relevant

    @jianyexi Sorry about this, I linked to wrong one, here is the correct PR https://github.com/Azure/azure-rest-api-specs-pr/pull/5230

    "x-ms-client-flatten": true
    }
    },
    "x-ms-azure-resource": true
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    "x-ms-azure-resource": true

    All ARM resources should support systemData.
    https://armwiki.azurewebsites.net/api_contracts/ResourceSystemData.html

    Please consider referencing the "Resource" definition in /specification/common-types/resource-management/v3/types.json.

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks @j5lim.

    This resource is a data plane resource surfaced through our management plane to enable ARM template scenarios. Since it lives it originates from our data plane, no system data has been, or is planned to be, tracked for it. We do not plan on adding it. Is it possible to note the planned omission?

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approving for now since the api version is preview and the resource is modifiable via data plane as well.

    @j5lim j5lim added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 21, 2022
    Copy link
    Contributor

    @j5lim j5lim left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approved from ARM side.

    @j5lim j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jan 21, 2022
    @jianyexi jianyexi merged commit 07a5e29 into Azure:main Jan 24, 2022
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    * Add 2021-10-01 folder
    
    * Update readme
    
    * Remove wrong folder
    
    * Add 2021-10-01-preview folder
    
    * Update enum value
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    * Add 2021-10-01 folder
    
    * Update readme
    
    * Remove wrong folder
    
    * Add 2021-10-01-preview folder
    
    * Update enum value
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants