Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 09 01 #15593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… common/2021-05-01-preview to version 2021-09-01
…etesConfiguration-2021-09-01
…ration-2021-09-01' of https://github.com/NarayanThiru/azure-rest-api-specs into dev-kubernetesconfiguration-Microsoft.KubernetesConfiguration-2021-09-01
|
Hi, @NarayanThiru Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
|
Hi, @NarayanThiru your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'operations' with immediate parent 'Extension', must have a list by immediate parent operation. Location: Microsoft.KubernetesConfiguration/stable/2021-09-01/extensions.json#L783 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: forceDelete Location: Microsoft.KubernetesConfiguration/stable/2021-09-01/extensions.json#L192 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.KubernetesConfiguration/stable/2021-09-01/extensions.json#L752 |
|
| 'identity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: common-types/resource-management/v2/types.json#L163 |
|
| 'sku' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: common-types/resource-management/v2/types.json#L170 |
|
| 'plan' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: common-types/resource-management/v2/types.json#L177 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 2 Errors, 10 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.0)
- current:stable/2021-09-01/extensions.json compared with base:preview/2021-05-01-preview/extensions.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- kubernetesconfiguration/resource-manager/readme.md#package-preview-2021-05
- kubernetesconfiguration/resource-manager/readme.md#package-2021-03
- kubernetesconfiguration/resource-manager/readme.md#package-preview-2020-10
- kubernetesconfiguration/resource-manager/readme.md#package-2020-07-01-preview
- kubernetesconfiguration/resource-manager/readme.md#package-2019-11-01-preview
- kubernetesconfiguration/resource-manager/readme.md#package-2021-09
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @NarayanThiru, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Aug 10, 2021
jianyexi
reviewed
Sep 16, 2021
jianyexi
reviewed
Sep 17, 2021
specification/kubernetesconfiguration/resource-manager/readme.md
Outdated
Show resolved
Hide resolved
|
@akning-ms , can you please merge the PR? |
This was referenced Sep 18, 2021
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Sep 18, 2021
…soft.kubernetes configuration 2021 09 01 (#1923) Create to sync Azure/azure-rest-api-specs#15593 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/kubernetesconfiguration?expand=1)
Hardell
pushed a commit
to Hardell/azure-rest-api-specs
that referenced
this pull request
Sep 27, 2021
…9 01 (Azure#15593) * Add blockchain to latest profile * Add additional types * Adds base for updating Microsoft.KubernetesConfiguration from version common/2021-05-01-preview to version 2021-09-01 * Updates readme * Updates API version in new specs and examples * Extension GA - apiversion 2021-09-01 * Move definitions.json to the correct folder * Add Patch example * Prettier fix * Patch response fix * Avocado fixes * Additional fixes * Fixes for Model and Semantic validations * Additional fixes * Fix patch example * Prettier fix for definitions.json * Readme.md spacing fix * Add AKSIdentity object * Prettier and Lint Diff fixes * Change Patch response to 202, per review * Update Patch response body to adhere to API guidance * Added Suppression for Patch 202 response * Fix linter issues * Fix linter issues * Fix Linter and Model validation errors * Fix ModelValidation and Prettier issues * Move suppression to the GA version * Move suppression to global * Move suppression back to the GA version * Update suppression * Fix errors from SDK generation * Prettier fix * Remove definitions.json and move the defs. into extensions.json * Remove azure-validator Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…9 01 (Azure#15593) * Add blockchain to latest profile * Add additional types * Adds base for updating Microsoft.KubernetesConfiguration from version common/2021-05-01-preview to version 2021-09-01 * Updates readme * Updates API version in new specs and examples * Extension GA - apiversion 2021-09-01 * Move definitions.json to the correct folder * Add Patch example * Prettier fix * Patch response fix * Avocado fixes * Additional fixes * Fixes for Model and Semantic validations * Additional fixes * Fix patch example * Prettier fix for definitions.json * Readme.md spacing fix * Add AKSIdentity object * Prettier and Lint Diff fixes * Change Patch response to 202, per review * Update Patch response body to adhere to API guidance * Added Suppression for Patch 202 response * Fix linter issues * Fix linter issues * Fix Linter and Model validation errors * Fix ModelValidation and Prettier issues * Move suppression to the GA version * Move suppression to global * Move suppression back to the GA version * Update suppression * Fix errors from SDK generation * Prettier fix * Remove definitions.json and move the defs. into extensions.json * Remove azure-validator Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Sep 2021
08/25/2021
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.