TextAnalytics 3.1 GA #14624
Merged
TextAnalytics 3.1 GA #14624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.md Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
…azure-rest-api-specs-pr into sumeh/textanalytics-3.1
|
Hi, @suhas92 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Guid used in model definition 'JobMetadata' for property 'jobId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: TextAnalytics/stable/v3.1/TextAnalytics.json#L2117 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 24 Errors, 2 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
- current:stable/v3.1/TextAnalytics.json compared with base:preview/v3.1-preview.5/TextAnalytics.json
- current:stable/v3.1/TextAnalytics.json compared with base:stable/v3.0/TextAnalytics.json
| Rule | Message |
|---|---|
|
The new version has a different 'enum' value than the previous one. New: TextAnalytics/stable/v3.1/TextAnalytics.json#L730:9 Old: TextAnalytics/stable/v3.0/TextAnalytics.json#L405:9 |
|
The new version has a different 'enum' value than the previous one. New: TextAnalytics/stable/v3.1/TextAnalytics.json#L889:9 Old: TextAnalytics/stable/v3.0/TextAnalytics.json#L476:9 |
The following breaking changes are detected by comparison with latest preview version:
Only 10 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"cognitiveservices/data-plane/TextAnalytics/readme.md",
"tag":"release_3_1",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"cognitiveservices/data-plane/TextAnalytics/readme.md",
"tag":"release_3_1",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"cognitiveservices/data-plane/TextAnalytics/readme.md",
"tag":"release_3_1",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
jhendrixMSFT
requested changes
Jun 2, 2021
There was a problem hiding this comment.
The addition of the ApiVersion parameter needs corresponding changes to the examples, see the model validation failure link for more info.
specification/cognitiveservices/data-plane/TextAnalytics/stable/v3.1/TextAnalytics.json
Outdated
Show resolved
Hide resolved
|
@jhendrixMSFT I think the check is failing for incorrect reasons, so I'm OK to ignore it @allenjzhang I think there's an issue in this check. Basically, in track 1 libraries, the version file generated as |
iscai-msft
approved these changes
Jun 8, 2021
|
approved for when breaking changes are fixed. As a general rule @suhas92, there isn't really a need to break all of the error codes into separate errors and add Also side note, but I think service's shouldn't return |
jhendrixMSFT
approved these changes
Jun 8, 2021
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
* initial commit - WIP * WIP - updated healthcare entity * WIP - fix indent * WIP - update readme * wip - update 3.1 * wip - update 3.1 * update piicategories as string * update partiallyCompleted * update analyzerequest * update healthcare entity category * update partiallySucceeded * remove partiallySucceeded * remove partiallyCompleted * Update specification/cognitiveservices/data-plane/TextAnalytics/readme.md Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> * address comments * Update TextAnalytics.json * add taskName to all input tasks * Update SuccessfulAnalyzeStatusRequest.json * update piicategories in query to be an array * run prettier * resolve build errors * fix lint errors * resolve build errors * resolve build errors * remove errors from response examples * resolve comments Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* initial commit - WIP * WIP - updated healthcare entity * WIP - fix indent * WIP - update readme * wip - update 3.1 * wip - update 3.1 * update piicategories as string * update partiallyCompleted * update analyzerequest * update healthcare entity category * update partiallySucceeded * remove partiallySucceeded * remove partiallyCompleted * Update specification/cognitiveservices/data-plane/TextAnalytics/readme.md Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> * address comments * Update TextAnalytics.json * add taskName to all input tasks * Update SuccessfulAnalyzeStatusRequest.json * update piicategories in query to be an array * run prettier * resolve build errors * fix lint errors * resolve build errors * resolve build errors * remove errors from response examples * resolve comments Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.