[Hub Generated] Review request for Microsoft.Synapse to add version preview/2021-04-01-preview #13484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01 to version 2021-04-01-preview
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Based on the response model schema, operation 'KustoPools_ListByWorkspace' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Synapse/preview/2021-04-01-preview/kustoPool.json#L19 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get a privateLinkHub Location: Microsoft.Synapse/preview/2021-04-01-preview/privatelinkhub.json#L397 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: synapse/common/v1/privateEndpointConnection.json#L326 |
|
The response of operation:'BigDataPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-04-01-preview/bigDataPool.json#L25 |
|
The response of operation:'IpFirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-04-01-preview/firewallRule.json#L203 |
|
The response of operation:'IntegrationRuntimes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-04-01-preview/integrationRuntime.json#L85 |
|
The response of operation:'Keys_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-04-01-preview/keys.json#L75 |
|
The response of operation:'Library_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-04-01-preview/library.json#L25 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-04-01-preview/privateEndpointConnections.json#L46 |
|
The response of operation:'PrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-04-01-preview/privateLinkResources.json#L75 |
|
The response of operation:'PrivateLinkHubPrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-04-01-preview/privateLinkResources.json#L175 |
|
The response of operation:'PrivateLinkHubs_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-04-01-preview/privatelinkhub.json#L86 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-04-01-preview/workspace.json |
️❌ModelValidation: 3 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Additional properties not allowed: networkSettings Url: Microsoft.Synapse/preview/2021-04-01-preview/workspace.json#L1132 |
|
Additional properties not allowed: networkSettings Url: Microsoft.Synapse/preview/2021-04-01-preview/workspace.json#L1132 JsonUrl: preview/2021-04-01-preview/examples/CreateOrUpdateWorkspace.json#L69 |
|
Additional properties not allowed: networkSettings Url: Microsoft.Synapse/preview/2021-04-01-preview/workspace.json#L1132 JsonUrl: preview/2021-04-01-preview/examples/CreateOrUpdateWorkspace.json#L136 |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross Version BreakingChange (Base on preview version): 179 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
- original: preview/2019-06-01-preview/bigDataPool.json <---> new: preview/2021-04-01-preview/bigDataPool.json
- original: preview/2019-06-01-preview/checkNameAvailability.json <---> new: preview/2021-04-01-preview/checkNameAvailability.json
- original: preview/2019-06-01-preview/firewallRule.json <---> new: preview/2021-04-01-preview/firewallRule.json
- original: preview/2019-06-01-preview/integrationRuntime.json <---> new: preview/2021-04-01-preview/integrationRuntime.json
- original: preview/2019-06-01-preview/keys.json <---> new: preview/2021-04-01-preview/keys.json
- original: preview/2020-04-01-preview/operations.json <---> new: preview/2021-04-01-preview/operations.json
- original: preview/2019-06-01-preview/privateEndpointConnections.json <---> new: preview/2021-04-01-preview/privateEndpointConnections.json
- original: preview/2019-06-01-preview/privateLinkResources.json <---> new: preview/2021-04-01-preview/privateLinkResources.json
- original: preview/2019-06-01-preview/privatelinkhub.json <---> new: preview/2021-04-01-preview/privatelinkhub.json
- original: preview/2020-04-01-preview/sqlPool.json <---> new: preview/2021-04-01-preview/sqlPool.json
- original: preview/2019-06-01-preview/sqlServer.json <---> new: preview/2021-04-01-preview/sqlServer.json
- original: preview/2019-06-01-preview/workspace.json <---> new: preview/2021-04-01-preview/workspace.json
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/recoverableSqlpools' removed or restructured? Old: Microsoft.Synapse/preview/2019-06-01-preview/sqlServer.json#L848:5 |
|
The new version is missing a definition that was found in the old version. Was 'SqlPoolProperties' removed or renamed? New: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L5230:3 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L275:3 |
|
The new version is missing a definition that was found in the old version. Was 'SqlPoolV3' removed or renamed? New: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L5230:3 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L275:3 |
|
The new version is missing a definition that was found in the old version. Was 'SqlPoolUpdate' removed or renamed? New: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L5230:3 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L275:3 |
|
The new version is missing a definition that was found in the old version. Was 'SystemData' removed or renamed? New: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L5230:3 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L275:3 |
|
The new version is missing a client parameter that was found in the old version. Was 'WorkspaceNameParameter' removed or renamed? New: azure-rest-api-specs/blob/92e4abaeb6af026e92583026ce6c803a70e22b9c/revision:1974:2 Old: azure-rest-api-specs/blob/master/revision:1818:2 |
|
The new version is missing a client parameter that was found in the old version. Was 'WorkspaceNameParameter' removed or renamed? New: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L7604:3 Old: azure-rest-api-specs/blob/master/revision:844:2 |
|
The new version is missing a client parameter that was found in the old version. Was 'SqlPoolNameParameter' removed or renamed? New: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L7604:3 Old: azure-rest-api-specs/blob/master/revision:844:2 |
|
The operation id has been changed from 'SqlV3Operations_List' to 'Operations_List'. This will impact generated code. New: Microsoft.Synapse/preview/2021-04-01-preview/operations.json#L25:7 Old: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L25:7 |
|
The operation id has been changed from 'SqlV3Operations_GetLocationHeaderResult' to 'Operations_GetLocationHeaderResult'. This will impact generated code. New: Microsoft.Synapse/preview/2021-04-01-preview/operations.json#L62:7 Old: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L62:7 |
️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.9)
- original: stable/2021-03-01/bigDataPool.json <---> new: preview/2021-04-01-preview/bigDataPool.json
- original: stable/2021-03-01/checkNameAvailability.json <---> new: preview/2021-04-01-preview/checkNameAvailability.json
- original: stable/2021-03-01/firewallRule.json <---> new: preview/2021-04-01-preview/firewallRule.json
- original: stable/2021-03-01/integrationRuntime.json <---> new: preview/2021-04-01-preview/integrationRuntime.json
- original: stable/2021-03-01/keys.json <---> new: preview/2021-04-01-preview/keys.json
- original: stable/2021-03-01/library.json <---> new: preview/2021-04-01-preview/library.json
- original: stable/2021-03-01/operations.json <---> new: preview/2021-04-01-preview/operations.json
- original: stable/2021-03-01/privateEndpointConnections.json <---> new: preview/2021-04-01-preview/privateEndpointConnections.json
- original: stable/2021-03-01/privateLinkResources.json <---> new: preview/2021-04-01-preview/privateLinkResources.json
- original: stable/2021-03-01/privatelinkhub.json <---> new: preview/2021-04-01-preview/privatelinkhub.json
- original: stable/2021-03-01/sqlPool.json <---> new: preview/2021-04-01-preview/sqlPool.json
- original: stable/2021-03-01/sqlServer.json <---> new: preview/2021-04-01-preview/sqlServer.json
- original: stable/2021-03-01/workspace.json <---> new: preview/2021-04-01-preview/workspace.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 16 Warnings warning [Detail]
- The following tags are being changed in this PR
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.id.$ref: undefined => "#/components/schemas/schemas:1208", properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => " |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:812" " |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:816" " |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.id.$ref: undefined => "#/components/schemas/schemas:1109", properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => " |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Deduplicating schema name: 'CloudError' -> 'CloudErrorAutoGenerated'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.id.$ref: undefined => "#/components/schemas/schemas:1206", properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => " |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
Hi, @amitelran Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=207232&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory" |
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from fdc0739a291325efc51d0139e9e1f6317fae2460. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it! warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️synapse [View full logs] [Preview Schema Changes]
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from fdc0739a291325efc51d0139e9e1f6317fae2460. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Synapse [View full logs] [Preview SDK Changes]
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning [Logs] Generate from fdc0739a291325efc51d0139e9e1f6317fae2460. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-synapse [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added operation PrivateEndpointConnectionsPrivateLinkHubOperations.get info [Changelog] - Added operation group KustoPoolsOperations
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from fdc0739a291325efc51d0139e9e1f6317fae2460. SDK Automation 14.0.0warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
️✔️@azure/arm-synapse [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js... cmderr [npmPack] created ./dist/arm-synapse.js in 1.5s
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from fdc0739a291325efc51d0139e9e1f6317fae2460. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-04-11 09:34:29 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-synapse;1.0.0-beta.1;1.0.0-beta.1" cmderr [generate.py] 2021-04-11 09:34:29 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-04-11 09:34:29 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.23 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md cmderr [generate.py] 2021-04-11 09:35:59 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-synapse cmderr [generate.py] 2021-04-11 09:35:59 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-04-11 09:35:59 INFO [POM][Skip] pom already has module azure-resourcemanager-synapse cmderr [generate.py] 2021-04-11 09:35:59 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-04-11 09:35:59 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-04-11 09:35:59 INFO [POM][Skip] pom already has module sdk/synapse cmderr [generate.py] 2021-04-11 09:35:59 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-synapse [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-synapse-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-synapse-1.0.0-beta.1.jar
- azure-resourcemanager-synapse-1.0.0-beta.1-sources.jar
cmderr [Inst] 2021-04-11 09:40:56 DEBUG Got artifact_id: azure-resourcemanager-synapse cmderr [Inst] 2021-04-11 09:40:56 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-04-11 09:40:56 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.1-javadoc.jar cmderr [Inst] 2021-04-11 09:40:56 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.1.jar cmderr [Inst] 2021-04-11 09:40:56 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.1.jar cmderr [Inst] 2021-04-11 09:40:56 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13484/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.1.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from fdc0739a291325efc51d0139e9e1f6317fae2460. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️synapse/mgmt/2021-03-01/synapse [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️synapse/mgmt/2020-12-01/synapse [View full logs] [Preview SDK Changes]info [Changelog] ### New Content info [Changelog] info [Changelog] - New function `LibraryListResponsePage.Response() LibraryListResponse` info [Changelog] - New function `*LibraryListResponsePage.Next() error` info [Changelog] - New function `LibrariesClient.ListByWorkspaceSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `LibraryListResponseIterator.Response() LibraryListResponse` info [Changelog] - New function `*LibraryListResponseIterator.Next() error` info [Changelog] - New function `LibraryListResponseIterator.NotDone() bool` info [Changelog] - New function `LibraryClient.GetSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `LibraryListResponseIterator.Value() LibraryResource` info [Changelog] - New function `LibrariesClient.ListByWorkspaceComplete(context.Context, string, string) (LibraryListResponseIterator, error)` info [Changelog] - New function `LibraryClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)` info [Changelog] - New function `LibraryResource.MarshalJSON() ([]byte, error)` info [Changelog] - New function `LibraryListResponsePage.Values() []LibraryResource` info [Changelog] - New function `*LibraryListResponseIterator.NextWithContext(context.Context) error` info [Changelog] - New function `*LibraryResource.UnmarshalJSON([]byte) error` info [Changelog] - New function `NewLibrariesClientWithBaseURI(string, string) LibrariesClient` info [Changelog] - New function `LibraryClient.Get(context.Context, string, string, string) (LibraryResource, error)` info [Changelog] - New function `LibrariesClient.ListByWorkspacePreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `NewLibraryClient(string) LibraryClient` info [Changelog] - New function `LibrariesClient.ListByWorkspace(context.Context, string, string) (LibraryListResponsePage, error)` info [Changelog] - New function `NewLibraryListResponseIterator(LibraryListResponsePage) LibraryListResponseIterator` info [Changelog] - New function `LibraryClient.GetResponder(*http.Response) (LibraryResource, error)` info [Changelog] - New function `NewLibrariesClient(string) LibrariesClient` info [Changelog] - New function `NewLibraryListResponsePage(LibraryListResponse, func(context.Context, LibraryListResponse) (LibraryListResponse, error)) LibraryListResponsePage` info [Changelog] - New function `LibraryListResponsePage.NotDone() bool` info [Changelog] - New function `NewLibraryClientWithBaseURI(string, string) LibraryClient` info [Changelog] - New function `LibrariesClient.ListByWorkspaceResponder(*http.Response) (LibraryListResponse, error)` info [Changelog] - New function `*LibraryListResponsePage.NextWithContext(context.Context) error` info [Changelog] - New function `LibraryListResponse.IsEmpty() bool` info [Changelog] - New struct `LibrariesClient` info [Changelog] - New struct `LibraryClient` info [Changelog] - New struct `LibraryListResponse` info [Changelog] - New struct `LibraryListResponseIterator` info [Changelog] - New struct `LibraryListResponsePage` info [Changelog] - New struct `LibraryResource` info [Changelog] info [Changelog] Total 0 breaking change(s), 40 additive change(s). info [Changelog]
- Only show 40 items here, please refer to log for details.
️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `SQLPoolRecommendedSensitivityLabelsClient.Update(context.Context, string, string, string, RecommendedSensitivityLabelUpdateList) (autorest.Response, error)` info [Changelog] - New function `SQLPoolRecommendedSensitivityLabelsClient.UpdateSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListResponder(*http.Response) (PrivateLinkResourceListResult, error)` info [Changelog] - New function `SQLPoolSensitivityLabelsClient.UpdateResponder(*http.Response) (autorest.Response, error)` info [Changelog] - New struct `DynamicExecutorAllocation` info [Changelog] - New struct `LibraryInfo` info [Changelog] - New struct `MaintenanceWindowOptions` info [Changelog] - New struct `MaintenanceWindowOptionsProperties` info [Changelog] - New struct `MaintenanceWindowTimeRange` info [Changelog] - New struct `MaintenanceWindows` info [Changelog] - New struct `MaintenanceWindowsProperties` info [Changelog] - New struct `ManagedVirtualNetworkReference` info [Changelog] - New struct `PrivateLinkHubPrivateLinkResourcesClient` info [Changelog] - New struct `RecommendedSensitivityLabelUpdate` info [Changelog] - New struct `RecommendedSensitivityLabelUpdateList` info [Changelog] - New struct `RecommendedSensitivityLabelUpdateProperties` info [Changelog] - New struct `SQLPoolMaintenanceWindowOptionsClient` info [Changelog] - New struct `SQLPoolMaintenanceWindowsClient` info [Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient` info [Changelog] - New struct `SensitivityLabelUpdate` info [Changelog] - New struct `SensitivityLabelUpdateList` info [Changelog] - New struct `SensitivityLabelUpdateProperties` info [Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime` info [Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties` info [Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `LastSucceededTimestamp` in struct `BigDataPoolResourceProperties` info [Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties` info [Changelog] - New field `Rank` in struct `SensitivityLabelProperties` info [Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties` info [Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties` info [Changelog] - New field `TableName` in struct `SensitivityLabelProperties` info [Changelog] - New field `ManagedBy` in struct `SensitivityLabel` info [Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration` info [Changelog] info [Changelog] Total 1 breaking change(s), 119 additive change(s). info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from fdc0739a291325efc51d0139e9e1f6317fae2460. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-synapse [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added operation PrivateEndpointConnectionsPrivateLinkHubOperations.get info [Changelog] - Added operation group KustoPoolsOperations
|
Hi @amitelran, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 17, 2021
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
...resource-manager/Microsoft.Synapse/preview/2021-04-01-preview/examples/KustoPoolsDelete.json
Outdated
Show resolved
Hide resolved
ruowan
approved these changes
Apr 8, 2021
|
PR is approved. |
26 tasks
|
@idear1203 |
|
The model validation failed. Could you pls fix the model validation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.