Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed Services Swagger Consistency Fixes #11471

Merged
merged 12 commits into from
Nov 20, 2020
Merged

Managed Services Swagger Consistency Fixes #11471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
752ed70
Updated 2018-06-01-preview specs
skayani Oct 30, 2020
7c14d46
Updated 2019-04-01-preview specs
skayani Oct 30, 2020
6d45d0a
Updated 2018-06-01-preview specs
skayani Oct 30, 2020
718eb44
Updated 2020-02-01-preview specs
skayani Oct 30, 2020
ea3d04e
Updated 2019-06-01 specs
skayani Oct 30, 2020
112318a
Updated 2019-09-01 specs
skayani Oct 30, 2020
2a2aa45
Updated 2018-06-01-preview examples
skayani Oct 30, 2020
5e4c0bc
Updated ErrorResponse model
skayani Oct 30, 2020
3a0168a
Model validation fix
skayani Oct 30, 2020
7b38d55
Removed readOnly=true for ErrorResponse
skayani Oct 30, 2020
36e7630
Updated type specification for error
skayani Oct 31, 2020
8277f20
Removed old type reference for ErrorResponse
skayani Oct 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...rosoft.ManagedServices/preview/2018-06-01-preview/examples/GetRegistrationAssignment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@
"authorizations": [
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand Down
9 changes: 9 additions & 0 deletions ...osoft.ManagedServices/preview/2018-06-01-preview/examples/GetRegistrationAssignments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,16 @@
"authorizations": [
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand Down
9 changes: 9 additions & 0 deletions ...rosoft.ManagedServices/preview/2018-06-01-preview/examples/GetRegistrationDefinition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,16 @@
"authorizations": [
{
"principalId": "f98g86a2-4cc4-4e6d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand Down
9 changes: 9 additions & 0 deletions ...osoft.ManagedServices/preview/2018-06-01-preview/examples/GetRegistrationDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,16 @@
"authorizations": [
{
"principalId": "f98g86a2-4cc4-4e6d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand Down
29 changes: 28 additions & 1 deletion ...rosoft.ManagedServices/preview/2018-06-01-preview/examples/PutRegistrationDefinition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,21 @@
"requestBody": {
"properties": {
"registrationDefinitionName": "DefinitionName",
"description": "Tes1t",
"description": "Test",
"managedByTenantId": "83abe5cd-bcc3-441a-bd86-e6a75360cecc",
"authorizations": [
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
]
},
Expand All @@ -33,7 +42,16 @@
"authorizations": [
{
"principalId": "f98g86a2-4cc4-4e6d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand All @@ -59,7 +77,16 @@
"authorizations": [
{
"principalId": "f98g86a2-4cc4-4e6d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand Down
61 changes: 42 additions & 19 deletions ...esource-manager/Microsoft.ManagedServices/preview/2018-06-01-preview/managedservices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,9 +759,21 @@
"type": "string",
"description": "Principal Id of the security group/service principal/user that would be assigned permissions to the projected subscription"
},
"principalIdDisplayName": {
"type": "string",
"description": "Display name of the principal Id."
},
"roleDefinitionId": {
"type": "string",
"description": "The role definition identifier. This role will define all the permissions that the security group/service principal/user must have on the projected subscription. This role cannot be an owner role."
},
"delegatedRoleDefinitionIds": {
"type": "array",
"description": "The delegatedRoleDefinitionIds field is required when the roleDefinitionId refers to the User Access Administrator Role. It is the list of role definition ids which define all the permissions that the user in the authorization can assign to other security groups/service principals/users.",
"items": {
"format": "uuid",
"type": "string"
}
}
},
"required": [
Expand All @@ -771,29 +783,40 @@
"type": "object",
"description": "Authorization tuple containing principal Id (of user/service principal/security group) and role definition id."
},
"ErrorDefinition": {
"properties": {
"code": {
"type": "string",
"description": "Error code."
},
"message": {
"type": "string",
"description": "Error message indicating why the operation failed."
},
"details": {
"description": "Internal error details.",
"type": "array",
"items": {
"$ref": "#/definitions/ErrorDefinition"
}
}
},
"required": [
"code",
"message"
],
"type": "object",
"description": "Error response indicates Azure Resource Manager is not able to process the incoming request. The reason is provided in the error message."
},
"ErrorResponse": {
"description": "Error response.",
"properties": {
"error": {
"readOnly": true,
"properties": {
"code": {
"type": "string",
"description": "Error code."
},
"message": {
"type": "string",
"description": "Error message indicating why the operation failed."
}
},
"required": [
"code",
"message"
],
"type": "object",
"description": "Error response indicates Azure Resource Manager is not able to process the incoming request. The reason is provided in the error message."
"$ref": "#/definitions/ErrorDefinition",
"description": "The error details.",
"type": "object"
}
},
"description": "Error response."
}
}
},
"parameters": {
Expand Down
9 changes: 9 additions & 0 deletions ...rosoft.ManagedServices/preview/2019-04-01-preview/examples/GetRegistrationAssignment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@
"authorizations": [
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand Down
9 changes: 9 additions & 0 deletions ...osoft.ManagedServices/preview/2019-04-01-preview/examples/GetRegistrationAssignments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,16 @@
"authorizations": [
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand Down
9 changes: 9 additions & 0 deletions ...rosoft.ManagedServices/preview/2019-04-01-preview/examples/GetRegistrationDefinition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,16 @@
"authorizations": [
{
"principalId": "f98g86a2-4cc4-4e6d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand Down
9 changes: 9 additions & 0 deletions ...osoft.ManagedServices/preview/2019-04-01-preview/examples/GetRegistrationDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,16 @@
"authorizations": [
{
"principalId": "f98g86a2-4cc4-4e6d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand Down
26 changes: 26 additions & 0 deletions ...rosoft.ManagedServices/preview/2019-04-01-preview/examples/PutRegistrationDefinition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,15 @@
"authorizations": [
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
]
},
Expand All @@ -33,7 +41,16 @@
"authorizations": [
{
"principalId": "f98g86a2-4cc4-4e6d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand All @@ -59,7 +76,16 @@
"authorizations": [
{
"principalId": "f98g86a2-4cc4-4e6d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "Support User",
"roleDefinitionId": "acdd72a7-3385-48ef-bd42-f606fba81ae7"
},
{
"principalId": "f98d86a2-4cc4-4e9d-ad47-b3e80a1bcdfc",
"principalIdDisplayName": "User Access Administrator",
"roleDefinitionId": "18d7d88d-d35e-4fb5-a5c3-7773c20a72d9",
"delegatedRoleDefinitionIds": [
"b24988ac-6180-42a0-ab88-20f7382dd24c"
]
}
],
"provisioningState": "Succeeded",
Expand Down
Loading