Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick Windows VM usernamepassword change #11381

Closed
wants to merge 0 commits into from
Closed

Cherrypick Windows VM usernamepassword change #11381

wants to merge 0 commits into from

Conversation

paulgmiller
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 26, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️❌BreakingChange: 48 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'UserArtifactManage' removed or renamed?
New: Microsoft.Compute/preview/2020-09-30/gallery.json#L1698:3
Old: Microsoft.Compute/preview/2020-09-30/gallery.json#L1698:3
❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'resourceCollectionName' removed or renamed?
New: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L315:3
Old: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L315:3
❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'monitorNameFilter' removed or renamed?
New: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L315:3
Old: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L315:3
❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'heartbeatFilter' removed or renamed?
New: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L315:3
Old: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L315:3
❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'providerName' removed or renamed?
New: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L315:3
Old: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L315:3
❌ 1008 - ModifiedOperationId The operation id has been changed from 'Alerts_UpdateResourceGroupLevelAlertStateToDismiss' to 'Alerts_UpdateResourceGroupLevelStateToDismiss'. This will impact generated code.
New: Microsoft.Security/stable/2020-01-01/alerts.json#L452:7
Old: Microsoft.Security/stable/2020-01-01/alerts.json#L452:7
❌ 1008 - ModifiedOperationId The operation id has been changed from 'HealthMonitors_ListStateChanges' to 'Monitors_ListStateChanges'. This will impact generated code.
New: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L173:7
Old: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L173:7
❌ 1008 - ModifiedOperationId The operation id has been changed from 'Alerts_GetResourceGroupLevelAlerts' to 'Alerts_GetResourceGroupLevel'. This will impact generated code.
New: Microsoft.Security/stable/2020-01-01/alerts.json#L248:7
Old: Microsoft.Security/stable/2020-01-01/alerts.json#L248:7
❌ 1008 - ModifiedOperationId The operation id has been changed from 'HealthMonitors_GetStateChange' to 'Monitors_GetStateChange'. This will impact generated code.
New: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L255:7
Old: Microsoft.WorkloadMonitor/preview/2020-01-13-preview/Microsoft.WorkloadMonitor.json#L255:7
❌ 1008 - ModifiedOperationId The operation id has been changed from 'Alerts_UpdateSubscriptionLevelAlertStateToReactivate' to 'Alerts_UpdateSubscriptionLevelStateToActivate'. This will impact generated code.
New: Microsoft.Security/stable/2020-01-01/alerts.json#L371:7
Old: Microsoft.Security/stable/2020-01-01/alerts.json#L371:7
️❌LintDiff: 1 Errors, 0 Warnings [Detail] [Expand]
Rule Message
❌ AutoRest Exception "details":" "Channel": "fatal",
"Text": "swagger-document/compose - FAILED" "Channel": "fatal",
"Text": "Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---\n>-\n Gets subscription credentials which uniquely identify Microsoft Azure\n subscription. The subscription ID forms part of the URI for every service\n call.\n,
---\nThe workspace's resource subscription ID.\n)."(node:9602) UnhandledPromiseRejectionWarning: Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (--->-",
"location":"https://github.com/Azure/azure-rest-api-specs/blob/4d9cd8fcddc3a9ecf1b5cddf399302726fae82c8/specification/operationalinsights/resource-manager/readme.md"
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
️️✔️ModelValidation [Detail] 
 Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail] 
 Validation passes for SemanticValidation.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulgmiller paulgmiller changed the base branch from master to dev-containerservice-Microsoft.ContainerService-2020-11-01 October 26, 2020 16:28
@paulgmiller paulgmiller changed the title Cherrypick Cherrypick Windows VM usernamepassword change Oct 26, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 26, 2020 •
edited
Loading

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 26, 2020 •
edited
Loading

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 26, 2020 •
edited
Loading

azure-sdk-for-java

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 26, 2020 •
edited
Loading

azure-sdk-for-net

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 4d9cd8fcddc3a9ecf1b5cddf399302726fae82c8 with merge commit 59847bfb2f05a1221dceba03dc8e7a428dc4d3bd. SDK Automation 13.0.17.20200918.2 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ❌Microsoft.Azure.Management.ContainerService [View full logs]  [Preview SDK Changes] 
      Failed to create the package Microsoft.Azure.Management.ContainerService.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=containerservice /v:n /p:SkipTests=true , {}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 26, 2020 •
    edited
    Loading

    azure-sdk-for-python

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 4d9cd8fcddc3a9ecf1b5cddf399302726fae82c8 with merge commit 59847bfb2f05a1221dceba03dc8e7a428dc4d3bd. SDK Automation 13.0.17.20200918.2 
      [azure-mgmt-containerservice][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-07-01'} in label v2017_07_01
[azure-mgmt-containerservice][after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
    • ⚠️azure-mgmt-containerservice [View full logs]  [Preview SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-containerservice
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-containerservice
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-07-01'} in label v2017_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 0.777% size of original (original: 65746 chars, delta: 511 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation AgentPoolsOperations.upgrade_node_image_version
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Removed operation ManagedClustersOperations.upgrade_node_image_version

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 26, 2020 •
    edited
    Loading

    azure-sdk-for-js

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 4d9cd8fcddc3a9ecf1b5cddf399302726fae82c8 with merge commit 59847bfb2f05a1221dceba03dc8e7a428dc4d3bd. SDK Automation 13.0.17.20200918.2
    • ️✔️@azure/arm-containerservice [View full logs]  [Preview SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
[npmPack] created ./dist/arm-containerservice.js in 399ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/arm-containerservice@11.2.0
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 13.3kB  esm/operations/agentPools.js                          
[npmPack] npm notice 1.6kB   esm/models/agentPoolsMappers.js                       
[npmPack] npm notice 154.4kB dist/arm-containerservice.js                          
[npmPack] npm notice 54.5kB  dist/arm-containerservice.min.js                      
[npmPack] npm notice 2.0kB   esm/containerServiceClient.js                         
[npmPack] npm notice 2.7kB   esm/containerServiceClientContext.js                  
[npmPack] npm notice 345B    esm/models/index.js                                   
[npmPack] npm notice 579B    esm/operations/index.js                               
[npmPack] npm notice 28.1kB  esm/operations/managedClusters.js                     
[npmPack] npm notice 1.6kB   esm/models/managedClustersMappers.js                  
[npmPack] npm notice 64.1kB  esm/models/mappers.js                                 
[npmPack] npm notice 1.6kB   esm/operations/operations.js                          
[npmPack] npm notice 442B    esm/models/operationsMappers.js                       
[npmPack] npm notice 2.5kB   esm/models/parameters.js                              
[npmPack] npm notice 7.2kB   esm/operations/privateEndpointConnections.js          
[npmPack] npm notice 1.5kB   esm/models/privateEndpointConnectionsMappers.js       
[npmPack] npm notice 2.0kB   esm/operations/privateLinkResources.js                
[npmPack] npm notice 468B    esm/models/privateLinkResourcesMappers.js             
[npmPack] npm notice 2.3kB   esm/operations/resolvePrivateLinkServiceId.js         
[npmPack] npm notice 443B    esm/models/resolvePrivateLinkServiceIdMappers.js      
[npmPack] npm notice 1.0kB   rollup.config.js                                      
[npmPack] npm notice 1.7kB   package.json                                          
[npmPack] npm notice 457B    tsconfig.json                                         
[npmPack] npm notice 3.7kB   esm/operations/agentPools.d.ts.map                    
[npmPack] npm notice 6.3kB   esm/operations/agentPools.js.map                      
[npmPack] npm notice 678B    esm/models/agentPoolsMappers.d.ts.map                 
[npmPack] npm notice 691B    esm/models/agentPoolsMappers.js.map                   
[npmPack] npm notice 306.2kB dist/arm-containerservice.js.map                      
[npmPack] npm notice 42.8kB  dist/arm-containerservice.min.js.map                  
[npmPack] npm notice 811B    esm/containerServiceClient.d.ts.map                   
[npmPack] npm notice 1.0kB   esm/containerServiceClient.js.map                     
[npmPack] npm notice 511B    esm/containerServiceClientContext.d.ts.map            
[npmPack] npm notice 1.4kB   esm/containerServiceClientContext.js.map              
[npmPack] npm notice 22.0kB  esm/models/index.d.ts.map                             
[npmPack] npm notice 250B    esm/operations/index.d.ts.map                         
[npmPack] npm notice 126B    esm/models/index.js.map                               
[npmPack] npm notice 265B    esm/operations/index.js.map                           
[npmPack] npm notice 7.1kB   esm/operations/managedClusters.d.ts.map               
[npmPack] npm notice 13.2kB  esm/operations/managedClusters.js.map                 
[npmPack] npm notice 711B    esm/models/managedClustersMappers.d.ts.map            
[npmPack] npm notice 724B    esm/models/managedClustersMappers.js.map              
[npmPack] npm notice 2.8kB   esm/models/mappers.d.ts.map                           
[npmPack] npm notice 34.1kB  esm/models/mappers.js.map                             
[npmPack] npm notice 663B    esm/operations/operations.d.ts.map                    
[npmPack] npm notice 908B    esm/operations/operations.js.map                      
[npmPack] npm notice 202B    esm/models/operationsMappers.d.ts.map                 
[npmPack] npm notice 215B    esm/models/operationsMappers.js.map                   
[npmPack] npm notice 588B    esm/models/parameters.d.ts.map                        
[npmPack] npm notice 1.8kB   esm/models/parameters.js.map                          
[npmPack] npm notice 2.3kB   esm/operations/privateEndpointConnections.d.ts.map    
[npmPack] npm notice 3.4kB   esm/operations/privateEndpointConnections.js.map      
[npmPack] npm notice 658B    esm/models/privateEndpointConnectionsMappers.d.ts.map 
[npmPack] npm notice 671B    esm/models/privateEndpointConnectionsMappers.js.map   
[npmPack] npm notice 819B    esm/operations/privateLinkResources.d.ts.map          
[npmPack] npm notice 1.1kB   esm/operations/privateLinkResources.js.map            
[npmPack] npm notice 225B    esm/models/privateLinkResourcesMappers.d.ts.map       
[npmPack] npm notice 238B    esm/models/privateLinkResourcesMappers.js.map         
[npmPack] npm notice 934B    esm/operations/resolvePrivateLinkServiceId.d.ts.map   
[npmPack] npm notice 1.2kB   esm/operations/resolvePrivateLinkServiceId.js.map     
[npmPack] npm notice 226B    esm/models/resolvePrivateLinkServiceIdMappers.d.ts.map
[npmPack] npm notice 239B    esm/models/resolvePrivateLinkServiceIdMappers.js.map  
[npmPack] npm notice 3.2kB   README.md                                             
[npmPack] npm notice 11.2kB  esm/operations/agentPools.d.ts                        
[npmPack] npm notice 20.4kB  src/operations/agentPools.ts                          
[npmPack] npm notice 1.3kB   esm/models/agentPoolsMappers.d.ts                     
[npmPack] npm notice 1.7kB   src/models/agentPoolsMappers.ts                       
[npmPack] npm notice 1.4kB   esm/containerServiceClient.d.ts                       
[npmPack] npm notice 2.2kB   src/containerServiceClient.ts                         
[npmPack] npm notice 923B    esm/containerServiceClientContext.d.ts                
[npmPack] npm notice 2.4kB   src/containerServiceClientContext.ts                  
[npmPack] npm notice 76.9kB  esm/models/index.d.ts                                 
[npmPack] npm notice 263B    esm/operations/index.d.ts                             
[npmPack] npm notice 73.9kB  src/models/index.ts                                   
[npmPack] npm notice 547B    src/operations/index.ts                               
[npmPack] npm notice 23.2kB  esm/operations/managedClusters.d.ts                   
[npmPack] npm notice 42.1kB  src/operations/managedClusters.ts                     
[npmPack] npm notice 1.3kB   esm/models/managedClustersMappers.d.ts                
[npmPack] npm notice 1.7kB   src/models/managedClustersMappers.ts                  
[npmPack] npm notice 4.3kB   esm/models/mappers.d.ts                               
[npmPack] npm notice 51.1kB  src/models/mappers.ts                                 
[npmPack] npm notice 1.1kB   esm/operations/operations.d.ts                        
[npmPack] npm notice 2.3kB   src/operations/operations.ts                          
[npmPack] npm notice 132B    esm/models/operationsMappers.d.ts                     
[npmPack] npm notice 404B    src/models/operationsMappers.ts                       
[npmPack] npm notice 690B    esm/models/parameters.d.ts                            
[npmPack] npm notice 2.5kB   src/models/parameters.ts                              
[npmPack] npm notice 7.1kB   esm/operations/privateEndpointConnections.d.ts

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 26, 2020 •
    edited
    Loading

    Trenton Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 26, 2020 •
    edited
    Loading

    azure-sdk-for-python-track2

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 26, 2020 •
    edited
    Loading

    azure-resource-manager-schemas

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 4d9cd8fcddc3a9ecf1b5cddf399302726fae82c8 with merge commit 59847bfb2f05a1221dceba03dc8e7a428dc4d3bd. Schema Automation 13.0.17.20200918.2 
      [containerservice][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[containerservice][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[containerservice][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    • ⚠️containerservice [View full logs]  
        [after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5786 passing (1m)
AzureResourceSchema has no registered package commands.
No file is changed.

      This was referenced Oct 26, 2020
      Open
      Open
      Open
      This was referenced Oct 26, 2020
      Open
      Open
      Open
      Open
      Open
      Open
      Open
      Open
      Open
      Open
      Open
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers
      No reviews
      Assignees

      @PhoenixHe-NV PhoenixHe-NV

      Labels
      CI-BreakingChange-Python
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      2 participants
      @paulgmiller @PhoenixHe-NV