Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev kubernetesconfiguration microsoft.kubernetes configuration 2020 10 01 preview #11057

Merged
merged 14 commits into from
Oct 16, 2020
Merged

Dev kubernetesconfiguration microsoft.kubernetes configuration 2020 10 01 preview #11057

merged 14 commits into from
Oct 16, 2020

Conversation

NarayanThiru
Copy link
Member

@NarayanThiru NarayanThiru commented Oct 6, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 6, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NarayanThiru NarayanThiru added the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Oct 6, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 6, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from c311e0d with merge commit d0e81d2. SDK Automation 13.0.17.20200918.2
  • ️✔️@azure/arm-kubernetesconfiguration [View full logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/sourceControlConfigurationClient.js → ./dist/arm-kubernetesconfiguration.js...
    [npmPack] created ./dist/arm-kubernetesconfiguration.js in 214ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-kubernetesconfiguration@2.0.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 38.6kB dist/arm-kubernetesconfiguration.js                   
    [npmPack] npm notice 12.6kB dist/arm-kubernetesconfiguration.min.js               
    [npmPack] npm notice 345B   esm/models/index.js                                   
    [npmPack] npm notice 428B   esm/operations/index.js                               
    [npmPack] npm notice 12.0kB esm/models/mappers.js                                 
    [npmPack] npm notice 2.3kB  esm/operations/operations.js                          
    [npmPack] npm notice 497B   esm/models/operationsMappers.js                       
    [npmPack] npm notice 2.3kB  esm/models/parameters.js                              
    [npmPack] npm notice 1.0kB  rollup.config.js                                      
    [npmPack] npm notice 1.8kB  esm/sourceControlConfigurationClient.js               
    [npmPack] npm notice 2.7kB  esm/sourceControlConfigurationClientContext.js        
    [npmPack] npm notice 10.1kB esm/operations/sourceControlConfigurations.js         
    [npmPack] npm notice 595B   esm/models/sourceControlConfigurationsMappers.js      
    [npmPack] npm notice 1.8kB  package.json                                          
    [npmPack] npm notice 457B   tsconfig.json                                         
    [npmPack] npm notice 86.9kB dist/arm-kubernetesconfiguration.js.map               
    [npmPack] npm notice 11.8kB dist/arm-kubernetesconfiguration.min.js.map           
    [npmPack] npm notice 4.9kB  esm/models/index.d.ts.map                             
    [npmPack] npm notice 160B   esm/operations/index.d.ts.map                         
    [npmPack] npm notice 126B   esm/models/index.js.map                               
    [npmPack] npm notice 175B   esm/operations/index.js.map                           
    [npmPack] npm notice 843B   esm/models/mappers.d.ts.map                           
    [npmPack] npm notice 6.8kB  esm/models/mappers.js.map                             
    [npmPack] npm notice 1.0kB  esm/operations/operations.d.ts.map                    
    [npmPack] npm notice 1.4kB  esm/operations/operations.js.map                      
    [npmPack] npm notice 218B   esm/models/operationsMappers.d.ts.map                 
    [npmPack] npm notice 231B   esm/models/operationsMappers.js.map                   
    [npmPack] npm notice 590B   esm/models/parameters.d.ts.map                        
    [npmPack] npm notice 1.7kB  esm/models/parameters.js.map                          
    [npmPack] npm notice 679B   esm/sourceControlConfigurationClient.d.ts.map         
    [npmPack] npm notice 773B   esm/sourceControlConfigurationClient.js.map           
    [npmPack] npm notice 531B   esm/sourceControlConfigurationClientContext.d.ts.map  
    [npmPack] npm notice 1.4kB  esm/sourceControlConfigurationClientContext.js.map    
    [npmPack] npm notice 3.5kB  esm/operations/sourceControlConfigurations.d.ts.map   
    [npmPack] npm notice 4.4kB  esm/operations/sourceControlConfigurations.js.map     
    [npmPack] npm notice 315B   esm/models/sourceControlConfigurationsMappers.d.ts.map
    [npmPack] npm notice 328B   esm/models/sourceControlConfigurationsMappers.js.map  
    [npmPack] npm notice 4.2kB  README.md                                             
    [npmPack] npm notice 14.4kB esm/models/index.d.ts                                 
    [npmPack] npm notice 112B   esm/operations/index.d.ts                             
    [npmPack] npm notice 14.0kB src/models/index.ts                                   
    [npmPack] npm notice 396B   src/operations/index.ts                               
    [npmPack] npm notice 1.1kB  esm/models/mappers.d.ts                               
    [npmPack] npm notice 9.8kB  src/models/mappers.ts                                 
    [npmPack] npm notice 2.2kB  esm/operations/operations.d.ts                        
    [npmPack] npm notice 4.4kB  src/operations/operations.ts                          
    [npmPack] npm notice 187B   esm/models/operationsMappers.d.ts                     
    [npmPack] npm notice 461B   src/models/operationsMappers.ts                       
    [npmPack] npm notice 697B   esm/models/parameters.d.ts                            
    [npmPack] npm notice 2.3kB  src/models/parameters.ts                              
    [npmPack] npm notice 1.3kB  esm/sourceControlConfigurationClient.d.ts             
    [npmPack] npm notice 1.7kB  src/sourceControlConfigurationClient.ts               
    [npmPack] npm notice 921B   esm/sourceControlConfigurationClientContext.d.ts      
    [npmPack] npm notice 2.4kB  src/sourceControlConfigurationClientContext.ts        
    [npmPack] npm notice 14.0kB esm/operations/sourceControlConfigurations.d.ts       
    [npmPack] npm notice 21.2kB src/operations/sourceControlConfigurations.ts         
    [npmPack] npm notice 285B   esm/models/sourceControlConfigurationsMappers.d.ts    
    [npmPack] npm notice 554B   src/models/sourceControlConfigurationsMappers.ts      
    [npmPack] npm notice 1.1kB  LICENSE.txt                                           
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-kubernetesconfiguration         
    [npmPack] npm notice version:       2.0.0                                      
    [npmPack] npm notice filename:      azure-arm-kubernetesconfiguration-2.0.0.tgz
    [npmPack] npm notice package size:  43.0 kB                                    
    [npmPack] npm notice unpacked size: 314.0 kB                                   
    [npmPack] npm notice shasum:        b6ad9b80c0242e4bc3544bfa678113451ee4c133   
    [npmPack] npm notice integrity:     sha512-ydyimfeBK9+wh[...]Wuc+TstU1SpMg==   
    [npmPack] npm notice total files:   59                                         
    [npmPack] npm notice 
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 16 Oct 2020 10:01:56 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:4247:D31561:24590C0:5F896F94","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 6, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from c311e0d with merge commit d0e81d2. SDK Automation 13.0.17.20200918.2
  • ⚠️sdk/kubernetesconfiguration/mgmt-v2019_11_01_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/kubernetesconfiguration/mgmt-v2019_11_01_preview/src/main/java/com/microsoft/azure/management/kubernetesconfiguration/v2019_11_01_preview/implementation/SourceControlConfigurationImpl.java:[44,32] cannot find symbol
      [mvn]   symbol:   method fromString(java.lang.String)
      [mvn]   location: class java.lang.String
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/kubernetesconfiguration/mgmt-v2019_11_01_preview/src/main/java/com/microsoft/azure/management/kubernetesconfiguration/v2019_11_01_preview/implementation/SourceControlConfigurationImpl.java:[46,42] cannot find symbol
      [mvn]   symbol:   method fromString(java.lang.String)
      [mvn]   location: class java.lang.String
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-kubernetesconfiguration: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/kubernetesconfiguration/mgmt-v2019_11_01_preview/src/main/java/com/microsoft/azure/management/kubernetesconfiguration/v2019_11_01_preview/implementation/SourceControlConfigurationImpl.java:[44,32] cannot find symbol
      [mvn] [ERROR]   symbol:   method fromString(java.lang.String)
      [mvn] [ERROR]   location: class java.lang.String
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/kubernetesconfiguration/mgmt-v2019_11_01_preview/src/main/java/com/microsoft/azure/management/kubernetesconfiguration/v2019_11_01_preview/implementation/SourceControlConfigurationImpl.java:[46,42] cannot find symbol
      [mvn] [ERROR]   symbol:   method fromString(java.lang.String)
      [mvn] [ERROR]   location: class java.lang.String
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 16 Oct 2020 10:03:58 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C2:27F2:50EF0FD:8635475:5F89700E","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 6, 2020

    azure-sdk-for-go - Release

    ⚠️ warning [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 6, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 6, 2020

    azure-sdk-for-net - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 6, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from c311e0d with merge commit d0e81d2. SDK Automation 13.0.17.20200918.2
    • ⚠️azure-mgmt-kubernetesconfiguration [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-kubernetesconfiguration
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-kubernetesconfiguration
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 16 Oct 2020 10:02:54 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C1:4495:2AE3E00:60A14FF:5F896FCE","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 27.716% size of original (original: 9067 chars, delta: 2513 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model SourceControlConfiguration has a new parameter ssh_known_hosts_contents
      [ChangeLog]   - Model SourceControlConfiguration has a new parameter system_data
      [ChangeLog]   - Model SourceControlConfiguration has a new parameter configuration_protected_settings
      [ChangeLog]   - Model ProxyResource has a new parameter system_data
      [ChangeLog]   - Model Resource has a new parameter system_data
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Model ErrorDefinition has a new signature

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 6, 2020

    azure-resource-manager-schemas - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from c311e0d with merge commit d0e81d2. Schema Automation 13.0.17.20200918.2
      [kubernetesconfiguration][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
      [kubernetesconfiguration][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
      [kubernetesconfiguration][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    • ️✔️kubernetesconfiguration [View full logs]  [Release Schema Changes]
        [after_scripts|node] PostProcessor finished successfully.
        [after_scripts|node]   5782 passing (1m)
        AzureResourceSchema has no registered package commands.
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 16 Oct 2020 10:08:11 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0781:71EE:1905B9:436838:5F89710B","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 7, 2020

      azure-sdk-for-python-track2 - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 7, 2020

      Trenton Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @NarayanThiru NarayanThiru added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 7, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      No pipelines are associated with this pull request.

      @NarayanThiru
      Copy link
      Member Author

      Hi @markcowl , @Descatles , @allenjzhang , can you please review this Swagger? Also, the validation job has been stuck for a day now. Can any of you please restart this?

      @markcowl
      Copy link
      Member

      /azp run

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 3 pipeline(s).

      @markcowl
      Copy link
      Member

      @NarayanThiru This PR is marked for needing an ARM review, please foloow the process outlined in the PR reviuew checklist if you need to have this review expedited. LMK if you have any questions

      @NarayanThiru
      Copy link
      Member Author

      /azp run

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 3 pipeline(s).

      @markcowl markcowl assigned akning-ms and unassigned markcowl Oct 14, 2020
      @ravbhatnagar
      Copy link
      Contributor

      Signing off from ARM side.

      @ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 15, 2020
      @akning-ms akning-ms merged commit d0e81d2 into Azure:master Oct 16, 2020
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      4 participants