Resolve Comments for Event driven jobs (#23729)

* Resolve Comments for Event driven jobs * change scaling rule to azure-servicebus * update example --------- Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Azure · Apr 27, 2023 · dbd7b63 · dbd7b63
1 parent f8b4b9a
commit dbd7b63
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 9 deletions.
diff --git a/specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/Jobs.json b/specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/Jobs.json
@@ -200,7 +200,7 @@
           "Create or Update Container Apps Job": {
             "$ref": "./examples/Job_CreateorUpdate.json"
           },
-          "Create or Update Container Apps Job With Event Driver Trigger": {
+          "Create or Update Container Apps Job With Event Driven Trigger": {
             "$ref": "./examples/Job_CreateorUpdate_EventTrigger.json"
           }
         },

diff --git a/...er/Microsoft.App/preview/2023-04-01-preview/examples/Job_CreateorUpdate_EventTrigger.json b/...er/Microsoft.App/preview/2023-04-01-preview/examples/Job_CreateorUpdate_EventTrigger.json
@@ -19,9 +19,9 @@
               "maxReplicas": 5,
               "rules": [
                 {
-                  "name": "httpscalingrule",
+                  "name": "servicebuscalingrule",
                   "custom": {
-                    "type": "http",
+                    "type": "azure-servicebus",
                     "metadata": {
                       "concurrentRequests": "50"
                     }
@@ -91,11 +91,26 @@
           "configuration": {
             "replicaTimeout": 10,
             "replicaRetryLimit": 10,
-            "manualTriggerConfig": {
+            "eventTriggerConfig": {
               "replicaCompletionCount": 1,
-              "parallelism": 4
+              "parallelism": 4,
+              "scale": {
+                "minReplicas": 1,
+                "maxReplicas": 5,
+                "rules": [
+                  {
+                    "name": "servicebuscalingrule",
+                    "custom": {
+                      "type": "azure-servicebus",
+                      "metadata": {
+                        "concurrentRequests": "50"
+                      }
+                    }
+                  }
+                ]
+              }
             },
-            "triggerType": "Manual"
+            "triggerType": "Event"
           },
           "template": {
             "containers": [
@@ -162,11 +177,26 @@
           "configuration": {
             "replicaTimeout": 10,
             "replicaRetryLimit": 10,
-            "manualTriggerConfig": {
+            "eventTriggerConfig": {
               "replicaCompletionCount": 1,
-              "parallelism": 4
+              "parallelism": 4,
+              "scale": {
+                "minReplicas": 1,
+                "maxReplicas": 5,
+                "rules": [
+                  {
+                    "name": "servicebuscalingrule",
+                    "custom": {
+                      "type": "azure-servicebus",
+                      "metadata": {
+                        "concurrentRequests": "50"
+                      }
+                    }
+                  }
+                ]
+              }
             },
-            "triggerType": "Manual"
+            "triggerType": "Event"
           },
           "template": {
             "containers": [