Service Bus : fix for issues 5058 and 5055 #6911
Conversation
|
@MiYanni , the CI failed with message 'Starting test execution, please wait... The job exceeded the maximum time limit for jobs, and has been terminated.' can you please restart the CI. |
|
@v-Ajnava You'll need to merge in latest preview into your fork. We've removed some tests from NetCore so the Travis CI process can pass. Right now, I don't think you'll have those changes. |
|
@v-Ajnava It seems I'm incorrect. Your branch is already up to date with preview. Let me investigate. |
|
@v-Ajnava I got it working. The issue was not related to your PR. |
|
@MiYanni Thanks ! |
| public static ErrorRecord WriteErrorforBadrequest(ErrorResponseException ex) | ||
| { | ||
| ErrorResponseContent errorExtract = new ErrorResponseContent(); | ||
| errorExtract = JsonConvert.DeserializeObject<ErrorResponseContent>(ex.Response.Content); |
There was a problem hiding this comment.
@v-Ajnava can we do some null-checking in this function to ensure that ex, ex.Response, and ex.Response.Content have a value?
…nto preview_local # Conflicts: # tools/CredScanSuppressions.json
…ershell into preview_local # Conflicts: # tools/CredScanSuppressions.json
|
|
||
| public static ErrorRecord WriteErrorforBadrequest(ErrorResponseException ex) | ||
| { | ||
| if (ex != null && !string.IsNullOrEmpty(ex.Response.Content)) |
There was a problem hiding this comment.
Is Response guaranteed to be non-null?
There was a problem hiding this comment.
yes, response will not be null
Description
Checklist
CONTRIBUTING.mdplatyPSmodule