Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eng] Added necessary tools/pipelines update to migrate main to future #27104

Merged
merged 262 commits into from
Feb 14, 2025

Conversation

VeryEarly
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@VeryEarly VeryEarly requested a review from Copilot February 13, 2025 07:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 30 out of 43 changed files in this pull request and generated 1 comment.

Files not reviewed (13)
  • .azure-pipelines/PipelineSteps/analyze-steps.ps1: Language not supported
  • .azure-pipelines/PipelineSteps/build-steps.ps1: Language not supported
  • .azure-pipelines/PipelineSteps/test-steps.ps1: Language not supported
  • .azure-pipelines/util/get-pr-changed-files.yml: Language not supported
  • .ci-config.json: Language not supported
  • build.proj: Language not supported
  • src/Az.autorest.props: Language not supported
  • .azure-pipelines/daily-build.yml: Evaluated as low risk
  • .azure-pipelines/util/build-steps.yml: Evaluated as low risk
  • .azure-pipelines/security-tools.yml: Evaluated as low risk
  • .azure-pipelines/azure-powershell-ci.yml: Evaluated as low risk
  • documentation/Update-PR-to-fit-new-main-branch.md: Evaluated as low risk
  • .azure-pipelines/windows-powershell.yml: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/helpers/KeyVault/readme.noprofile.md:18

  • [nitpick] The directive to set 'subject-prefix' to an empty string might be unnecessary and could lead to ambiguity in the naming of cmdlets. Consider removing this directive or setting a more descriptive prefix.
subject-prefix: ''

#subject-prefix: ''
#title: AppInsights
#module-version: 4.0.0
apprepo: https://github.com/Azure/azure-rest-api-specs/blob/resource-hybrid-profile
Copy link
Preview

Copilot AI Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL 'https://github.com/Azure/azure-rest-api-specs/blob/resource-hybrid-profile' might be incorrect. It should be 'https://github.com/Azure/azure-rest-api-specs/blob/main/resource-hybrid-profile'. Please verify the correct URL.

Suggested change
apprepo: https://github.com/Azure/azure-rest-api-specs/blob/resource-hybrid-profile
apprepo: https://github.com/Azure/azure-rest-api-specs/blob/main/resource-hybrid-profile

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@dolauli dolauli merged commit ada2778 into main Feb 14, 2025
1 of 6 checks passed
@dolauli dolauli deleted the eng/archive-test branch February 14, 2025 01:45
@VeryEarly VeryEarly restored the eng/archive-test branch February 14, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants