PowerShell Support for ResiliencyPolicy (including ResilientVMCreationPolicy, ResilientVMDeletionPolicy) on VMSS #25928

haagha · 2024-08-23T15:39:33Z

Description

Introduced EnableResilientVMCreate and EnableResilientVMDelete parameters to Update-AzVmss and New-AzVmssConfig cmdlets for enhanced VM resilience options.

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2024-08-23T15:39:36Z

️✔️Az.Accounts

⚠️Az.Compute

️✔️Az.KeyVault

️✔️Az.ManagedServiceIdentity

️✔️Az.Monitor

️✔️Az.Network

️✔️Az.OperationalInsights

️✔️Az.PrivateDns

️✔️Az.RecoveryServices

️✔️Az.Security

️✔️Az.Sql

️✔️Az.Ssh

️✔️Az.Storage

grizzlytheodore · 2024-08-23T16:56:03Z

src/Compute/Compute/ChangeLog.md

@@ -20,6 +20,7 @@

 -->
 ## Upcoming Release
+* Introduced `EnableResilientVMCreate` and `EnableResilientVMDelete` parameters to `Update-AzVmss` and `New-AzVmssConfig` cmdlets for enhanced VM resilience options.


let's keep this consistent with other lines.
Ex: * Added parameter -ResourceIdsOnly to Get-AzCapacityReservationGroup cmdlet.

This is AI generated, so I've marked it as improvements to make on ps cmd assistant. and also fixed this

grizzlytheodore · 2024-08-23T16:57:28Z

src/Compute/Compute/help/Update-AzVmss.md

@@ -776,6 +806,21 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```

+### -ProgressAction


to be removed

grizzlytheodore · 2024-08-23T16:59:48Z

src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs

+        [Parameter(
+            Mandatory = false,
+            HelpMessage = "Enable or disable resilient VM creation.")]
+        public SwitchParameter EnableResilientVMCreate { get; set; }


should this be a bool as well?

Addressed with design author and changed, Switch is for New-Azvmssconfig and Update is for Update-Azvmss

grizzlytheodore · 2024-08-23T17:00:21Z

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs

+        [Parameter(
+            Mandatory = false,
+            HelpMessage = "Enable or disable resilient VM deletion.")]
+        public bool EnableResilientVMDelete { get; set; }


why is the other one Switch and this one bool ?

Addressed with design author and changed, Switch is for New-Azvmssconfig and Update is for Update-Azvmss

Sandido · 2024-08-23T17:41:05Z

src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1

+.SYNOPSIS
+    Create a VMSS 
+    Test ResilientVMCreationPolicy


Improve the test description.

Added a few descriptors

Sandido · 2024-08-23T17:41:50Z

src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1

+        $vmssName = 'vmssResiliencyPolicy' + $rgname;
+
+        $adminUsername = 'Foo12';


you could use Get-ComputeTestResourceName here instead. Might be better security wise.

how is it better security wise? The resource will be deleted after the test is ran.

then there's no established pattern or hardcoded string to learn our username from. The cleanup should happen, but this would further obfuscate the credentials and make them non-deterministic.

Sandido · 2024-08-23T17:47:50Z

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs

+                {
+                    vResiliencyPolicy = new ResiliencyPolicy();
+                }
+                vResiliencyPolicy.ResilientVMCreationPolicy = new ResilientVMCreationPolicy(this.EnableResilientVMCreate.IsPresent);


we shouldn't use IsPResent even on SwitchParameters because users can pass switchParameters as false as -Parameter:$false. It's rare but it does happen so you should check to see if it is $true.

I see interesting, corrected.

Sandido · 2024-08-23T17:49:05Z

src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs

+                {
+                    this.VirtualMachineScaleSetUpdate.ResiliencyPolicy = new ResiliencyPolicy();
+                }
+                this.VirtualMachineScaleSetUpdate.ResiliencyPolicy.ResilientVMCreationPolicy = new ResilientVMCreationPolicy(this.EnableResilientVMCreate.IsPresent);


same ispresent concern here as above.

Sandido · 2024-08-23T17:51:10Z

src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs

+                {
+                    this.VirtualMachineScaleSet.ResiliencyPolicy = new ResiliencyPolicy();
+                }
+                this.VirtualMachineScaleSet.ResiliencyPolicy.ResilientVMCreationPolicy = new ResilientVMCreationPolicy(this.EnableResilientVMCreate.IsPresent);


same ispresent concern

src/Compute/Compute/Manual/PSVirtualMachineScaleSet.cs

src/Compute/Compute/help/New-AzVmssConfig.md

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs

Sandido · 2024-08-27T16:48:00Z

src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1

+        $vmssName = 'vmssResiliencyPolicy' + $rgname;
+
+        $adminUsername = 'Foo12';


then there's no established pattern or hardcoded string to learn our username from. The cleanup should happen, but this would further obfuscate the credentials and make them non-deterministic.

src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1

src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs

…nPolicy, ResilientVMDeletionPolicy) on VMSS (#25928) * Autogen code * Update ChangeLog.md * fixing autogenerated changes * adding test and help * More changes * changing help * changes with help * fixed test case * Adding static analysis suppression --------- Co-authored-by: PSCmdAssistant <pscmdassistant@microsoft.com> Co-authored-by: Xiaogang <xidi@microsoft.com>

…nPolicy, ResilientVMDeletionPolicy) on VMSS (#25928) (#25987) * Autogen code * Update ChangeLog.md * fixing autogenerated changes * adding test and help * More changes * changing help * changes with help * fixed test case * Adding static analysis suppression --------- Co-authored-by: Haider Agha <64601174+haagha@users.noreply.github.com> Co-authored-by: PSCmdAssistant <pscmdassistant@microsoft.com> Co-authored-by: Xiaogang <xidi@microsoft.com>

PSCmdAssistant and others added 4 commits August 20, 2024 22:43

Autogen code

4edd352

Update ChangeLog.md

c866362

fixing autogenerated changes

35a3dd3

adding test and help

b416e69

haagha requested review from bilaakpan-ms, Sandido and grizzlytheodore as code owners August 23, 2024 15:39

grizzlytheodore reviewed Aug 23, 2024

View reviewed changes

Sandido requested changes Aug 23, 2024

View reviewed changes

haagha added 2 commits August 26, 2024 15:55

More changes

a765cf2

changing help

8a94202

haagha requested review from Sandido and grizzlytheodore August 26, 2024 21:19

dolauli self-assigned this Aug 27, 2024

grizzlytheodore reviewed Aug 27, 2024

View reviewed changes

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs Show resolved Hide resolved

grizzlytheodore reviewed Aug 27, 2024

View reviewed changes

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs Show resolved Hide resolved

changes with help

c30ba62

grizzlytheodore previously approved these changes Aug 27, 2024

View reviewed changes

Sandido requested changes Aug 27, 2024

View reviewed changes

fixed test case

16f7d78

haagha requested a review from Sandido August 27, 2024 17:36

haagha dismissed grizzlytheodore’s stale review via 16f7d78 August 27, 2024 17:36

Adding static analysis suppression

4ceecb9

Sandido previously approved these changes Aug 28, 2024

View reviewed changes

Merge branch 'main' into cmdassistant-1437-10480208476-1

901aad5

dolauli dismissed Sandido’s stale review via 901aad5 August 29, 2024 09:07

dolauli approved these changes Aug 30, 2024

View reviewed changes

dolauli merged commit ec4f0e8 into Azure:main Aug 30, 2024
12 checks passed

VeryEarly mentioned this pull request Sep 2, 2024

PowerShell Support for ResiliencyPolicy (including ResilientVMCreatio… #25987

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PowerShell Support for ResiliencyPolicy (including ResilientVMCreationPolicy, ResilientVMDeletionPolicy) on VMSS #25928

PowerShell Support for ResiliencyPolicy (including ResilientVMCreationPolicy, ResilientVMDeletionPolicy) on VMSS #25928

haagha commented Aug 23, 2024 •

edited by grizzlytheodore

Loading

azure-client-tools-bot-prd bot commented Aug 23, 2024 •

edited

Loading

grizzlytheodore Aug 23, 2024

haagha Aug 26, 2024 •

edited

Loading

grizzlytheodore Aug 23, 2024

haagha Aug 26, 2024

grizzlytheodore Aug 23, 2024

haagha Aug 26, 2024

grizzlytheodore Aug 23, 2024

haagha Aug 26, 2024

Sandido Aug 23, 2024

haagha Aug 26, 2024

Sandido Aug 23, 2024

haagha Aug 26, 2024

Sandido Aug 27, 2024

haagha Aug 27, 2024

Sandido Aug 23, 2024

haagha Aug 26, 2024

Sandido Aug 23, 2024

haagha Aug 26, 2024

Sandido Aug 23, 2024

haagha Aug 26, 2024

Sandido Aug 27, 2024

		$vmssName = 'vmssResiliencyPolicy' + $rgname;

		$adminUsername = 'Foo12';

PowerShell Support for ResiliencyPolicy (including ResilientVMCreationPolicy, ResilientVMDeletionPolicy) on VMSS #25928

PowerShell Support for ResiliencyPolicy (including ResilientVMCreationPolicy, ResilientVMDeletionPolicy) on VMSS #25928

Conversation

haagha commented Aug 23, 2024 • edited by grizzlytheodore Loading

Description

Mandatory Checklist

azure-client-tools-bot-prd bot commented Aug 23, 2024 • edited Loading

Choose a reason for hiding this comment

haagha Aug 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

haagha commented Aug 23, 2024 •

edited by grizzlytheodore

Loading

azure-client-tools-bot-prd bot commented Aug 23, 2024 •

edited

Loading

haagha Aug 26, 2024 •

edited

Loading