Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in ChangeLog.md #22818

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fixed typo in ChangeLog.md #22818

merged 2 commits into from
Sep 19, 2023

Conversation

BethanyZhou
Copy link
Contributor

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 19, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@vidai-msft vidai-msft merged commit edba315 into release-2023-09-26 Sep 19, 2023
@BethanyZhou BethanyZhou deleted the BethanyZhou-patch-1 branch September 19, 2023 07:57
VeryEarly pushed a commit that referenced this pull request Sep 21, 2023
* Migrate ResourceMover from generation to main (#22748)

* Move ResourceMover to main

* Update ChangeLog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* Fixed typo in ChangeLog.md (#22818)

* Update ChangeLog.md

* Update ChangeLog.md

* Migrate HdInsightOnAks from generation to release-2023-09-26 (#22819)

* Move HdInsightOnAks to release-2023-09-26

* Create SignatureIssues.csv

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* [Az.KeyVault] Security domain Upload Split (#22671)

* 0825 update

* 0825 update2

* Security Domain Upload Split

* Update ChangeLog

* Polish code

* Polish code

* Polish code

* Help files generate

* Add online version in help files

* Rename super class from SecurityDomainCmdletClient to SecurityDomainCmdletBase

* Supress Static Analysis

* Suppress Static Analysis

* Suppress Static Analysis

* Sytax in help files

* Align the new design

* Update changelog

* Update Pester test

* ByRestoredBlob

* Resolve comments

* SecurityDomainRestoredBlob

* Update help files

* Update src/KeyVault/KeyVault/ChangeLog.md

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* Rename files

* Update help file

* suppress signature issue

* suppress signature issue

* ExchangeKey

* ExchangeKeyPath, OutFile

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* Added support for AlwaysOn soft delete state (#22817)

* Added support for AlwaysOn soft delete state

* suppressed false positive example issues

* upgrade common version to 1.3.86 (#22820)

* [Az.KeyVault] Add help example title for Import-AzKeyVaultSecurityDomain (#22831)

* Add help example title

* Update src/KeyVault/KeyVault/help/Import-AzKeyVaultSecurityDomain.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* update changelog for queue breaking change (#22833)

* release-2023-09-26 (#22821)

---------

Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com>
Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com>
Co-authored-by: Yan Xu <yanxu1@microsoft.com>
Co-authored-by: yifanz7 <131133995+yifanz7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants