Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot suppress example analysis #20512

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

isra-fel
Copy link
Member

@isra-fel isra-fel commented Dec 26, 2022

Description

Try to fix example analysis error in #20469

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

caused by duplicated "Az." prefix of module name
@isra-fel isra-fel force-pushed the yeming/test-example-ana branch from 093403e to 3c90103 Compare December 26, 2022 10:20
@@ -564,7 +564,7 @@ function Get-NonExceptionRecord{
$errors = @()
foreach($record in $records){
$needAdd = $true
$exceptionPath = Join-Path -Path $exceptionPaths -ChildPath "Az.$($record.Module)" -AdditionalChildPath "ExampleIssues.csv"
$exceptionPath = Join-Path -Path $exceptionPaths -ChildPath (EnsureModuleName($record.Module)) -AdditionalChildPath "ExampleIssues.csv"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously -ChildPath will be "Az.Az.***". That's why suppression did not work.

@isra-fel isra-fel changed the title Try to fix example exceptions Fix cannot suppress example analysis Dec 26, 2022
@isra-fel isra-fel marked this pull request as ready for review December 26, 2022 10:22
@wyunchi-ms wyunchi-ms merged commit 21dbafd into main Dec 27, 2022
@isra-fel isra-fel deleted the yeming/test-example-ana branch December 27, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants