Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit proxy for azure firewall policy #18642

Merged
merged 25 commits into from
Jul 26, 2022
Merged

Explicit proxy for azure firewall policy #18642

merged 25 commits into from
Jul 26, 2022

Conversation

Gizachew-Eshetie
Copy link
Contributor

@Gizachew-Eshetie Gizachew-Eshetie commented Jun 20, 2022 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly self-assigned this Jun 23, 2022
@BethanyZhou BethanyZhou assigned BethanyZhou and unassigned VeryEarly Jul 20, 2022
@BethanyZhou
Copy link
Contributor

Hi @Gizachew-Eshetie , please resolve conflicts. Microsoft.Azure.Management.Network is upgraded to 2.23.0

BethanyZhou
BethanyZhou reviewed Jul 25, 2022
View reviewed changes
src/Network/Network/help/Set-AzFirewallPolicy.md Outdated
$exProxy = New-AzFirewallPolicyExplicitProxy -EnableExplicitProxy -HttpPort 100 -HttpsPort 101 -EnablePacFile -PacFilePort 130 -PacFile "sampleurlfortesting.blob.core.windowsnet/nothing"
Set-AzFirewallPolicy -Name firewallPolicy1 -ResourceGroupName TestRg -Location westcentralus -ExplicitProxy $exProxy
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add sample if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added sample output.

@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou merged commit eadb0bc into Azure:network-2022-01-01 Jul 26, 2022
@girishmotwani girishmotwani mentioned this pull request Oct 11, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly left review comments

@BethanyZhou BethanyZhou BethanyZhou approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@BethanyZhou BethanyZhou

Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gizachew-Eshetie @BethanyZhou @VeryEarly