Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Resize Gateway cmdlet and adding SetIPsecParameters and GetIPsecParameters #15

Merged
merged 17 commits into from Dec 3, 2014
Merged

Fixing Resize Gateway cmdlet and adding SetIPsecParameters and GetIPsecParameters #15

merged 17 commits into from Dec 3, 2014

Conversation

ghost
Copy link

@ghost ghost commented Nov 26, 2014

No description provided.

@azurecla
Copy link

Hi @daschult, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (daschult). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

stankovski
stankovski reviewed Nov 26, 2014
View reviewed changes
...agement/Compute/Commands.ServiceManagement.Preview/Commands.ServiceManagement.Preview.csproj
@@ -82,11 +82,11 @@
</Reference>
<Reference Include="Microsoft.WindowsAzure.Common, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Common.1.4.0\lib\net45\Microsoft.WindowsAzure.Common.dll</HintPath>
<HintPath>..\..\..\packages\Microsoft.WindowsAzure.Common.1.4.1\lib\net45\Microsoft.WindowsAzure.Common.dll</HintPath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating only one project out of the solution to a newer NuGet package may cause run-time issues. Please update all projects in the AzurePowerShell.sln solution with the latest package.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@stankovski
Copy link
Member

Please add mock scenario tests

@stankovski
Copy link
Member

Please update documentation xml file

Daniel Schulte added 10 commits December 1, 2014 08:58
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
916b62c
Updating all of the projects to have the latest Microsoft.WindowsAzur…
1454931 
…e.Common and Microsoft.WindowsAzure.Common.Dependencies project references.
Moving "using" statements outside of the namespace.
8d8373c
Attempting to fix the build errors I'm getting in my pull request, bu…
88ccfd7 
…t not on my local machine.
Trying to fix the pull request build errors again (adding PublicKeyTo…
860fa8e 
…ken to Reference element in Commands.Utilities.csproj)
Trying again to fix the pull request build.
f1adcf5
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
6f6347e
Missed a couple more.
5d70a71
Missed a typo.
a921c0f
Changing csproj files back to what they were before I started, except…
5cc4704 
… the update to the version numbers.
@markcowl
Copy link
Member

markcowl commented Dec 2, 2014

Build is failing, Loks like a removed reference to common?

@ghost
Copy link
Author

ghost commented Dec 2, 2014

retest this please

ogail
ogail reviewed Dec 2, 2014
View reviewed changes
src/ServiceManagement/Network/Commands.Network/Microsoft.Azure.Commands.Network.dll-help.psd1
@@ -0,0 +1,93 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a new psd1 file is added?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it didn't exist previously. I don't know why I didn't have it, but I do now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for it as the cmdlets are being loaded via https://github.com/Azure/azure-powershell/blob/master/src/ServiceManagement/Services/Commands.Utilities/Azure.psd1#L86

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this makes it easier to edit our powershell help file. I'd like to keep it around.

ogail added a commit that referenced this pull request Dec 3, 2014
@ogail
Merge pull request #15 from daschult/dev
18dd916 
Fixing Resize Gateway cmdlet and adding SetIPsecParameters and GetIPsecParameters
@ogail ogail merged commit 18dd916 into Azure:dev Dec 3, 2014
ogail pushed a commit that referenced this pull request Feb 25, 2015
@sanjkuma
Merge pull request #15 from AsrOneSdk/neha-dev
0e0cb60 
Bug fixes and Associate protection profile skeleton
huangpf referenced this pull request in huangpf/azure-powershell Mar 5, 2015
@AzureRT
Merge pull request #15 from avijitgupta/dev
870a8a4 
removing commented code and credentials
ogail pushed a commit that referenced this pull request Mar 18, 2015
@jtlibing
Merge pull request #15 from Azure/dev
94acd74 
pull from dev branch of azure/azure-powershell
akromm-zz pushed a commit to akromm-zz/azure-powershell that referenced this pull request Apr 18, 2015
@AzureRT
Merge pull request Azure#15 from huangpf/crp2
de1e95e 
PR
stankovski pushed a commit that referenced this pull request May 19, 2015
@sethusrinivasan
Merge pull request #15 from Azure/dev
3518a23 
Dev
huangpf added a commit that referenced this pull request Jun 8, 2015
@huangpf
Merge pull request #15 from huangpf/fixdep
452308f 
Fixdep
ogail pushed a commit that referenced this pull request Jul 7, 2015
@avirupch
Merge pull request #15 from AzCiS/parvezah
157e148 
Fixing the Error Messages shown when decrytion fails with the given regi...
stankovski pushed a commit that referenced this pull request Jul 10, 2015
@panbha
Merge pull request #15 from MabOneSdk/panbha3
7d73389 
changes few function names
hovsepm pushed a commit that referenced this pull request Jan 28, 2016
@safeermohammed
Merge pull request #15 from balukambala/dev
363e815 
Added DSC delete cmdlets
markcowl pushed a commit that referenced this pull request Dec 10, 2016
@viananth @markcowl
Refactoring Invoke-RestMethod to facilitate mocking. This closes #15
9008cdd
viananth pushed a commit to viananth/azure-powershell that referenced this pull request Mar 29, 2018
@deathly809
Merge pull request Azure#15 from deathly809/deepthbranch
430f61d 
Fixing examples for Commerce, Compute, Fabric, Gallery and Bridge
cormacpayne pushed a commit that referenced this pull request Apr 16, 2019
@leonardbf
NFSAAS-1707 add signed package (#15)
f7589aa
isra-fel pushed a commit that referenced this pull request Apr 25, 2022
@ChenglongLiu
Merge pull request #15 from ChenglongLiu/feature/Cdndev
24f8ec9 
Add Update tests
dantecit0 added a commit to dantecit0/azure-powershell that referenced this pull request Jul 3, 2023
@dantecit0
Update Set-AzFirewall.md
294de41 
Added exmple Azure#15 which shows how to properly add or remove Availability zones to an Azure Firewall.
@dantecit0 dantecit0 mentioned this pull request Jul 3, 2023
Merged
Nickcandy pushed a commit that referenced this pull request Jul 4, 2023
@dantecit0
Update Set-AzFirewall.md (#22224)
e294537 
Added exmple #15 which shows how to properly add or remove Availability zones to an Azure Firewall.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azurecla @stankovski @markcowl @ogail