Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: ListByResourceAsync returns null, ListByResource doesn't #272

Closed
bjornsallarp opened this issue Apr 16, 2018 · 3 comments
Closed

Bug: ListByResourceAsync returns null, ListByResource doesn't #272

bjornsallarp opened this issue Apr 16, 2018 · 3 comments
Assignees
@hovsepm
Milestone
v1.9

Comments

@bjornsallarp
Copy link

Reason is async method has incorrect result model. Check:
Microsoft.Azure.Management.Monitor.Fluent.IMetricDefinitions
Microsoft.Azure.Management.Monitor.Fluent.MetricDefinitionsImpl

ListByResource returns IReadOnlyList (Correct)
ListByResourceAsync return Task<Microsoft.Azure.Management.Monitor.Fluent.IMetricDefinition> (Incorrect)

Was introduced in commit 50bfca3

It's super simple/quick fix
@hovsepm hovsepm self-assigned this Apr 16, 2018
@hovsepm
Copy link
Contributor

hovsepm commented Apr 16, 2018

Thanks for catching this :). I'll make sure fix will go out with release 1.9

@hovsepm hovsepm added this to the v1.9 milestone Apr 16, 2018
hovsepm pushed a commit that referenced this issue Apr 16, 2018
Fix for #272 (#273)
af2feba
@hovsepm
Copy link
Contributor

hovsepm commented Apr 16, 2018

Fixed. Will be available in v1.9 due this week,

@hovsepm hovsepm closed this as completed Apr 16, 2018
@hovsepm
Copy link
Contributor

hovsepm commented Apr 17, 2018

@bjornsallarp FYI release 1.9 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hovsepm hovsepm

Labels
None yet
Projects
None yet
Milestone
v1.9
Development

No branches or pull requests
2 participants
@bjornsallarp @hovsepm